[dpdk-dev] net/nfp: fix memory allocation
Checks
Commit Message
If the function actually returns a null value, a null pointer
dereference will occur.
Fixes: dd63df2bfff3 ("net/nfp: add NSP symbol resolution command")
Coverity: 195013
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_nspu.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On 11/8/2017 4:07 AM, Alejandro Lucero wrote:
> If the function actually returns a null value, a null pointer
> dereference will occur.
>
> Fixes: dd63df2bfff3 ("net/nfp: add NSP symbol resolution command")
> Coverity: 195013
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk/master, thanks.
@@ -411,6 +411,9 @@
int ret = 0;
sym_buf = malloc(desc->buf_size);
+ if (!sym_buf)
+ return -ENOMEM;
+
strncpy(sym_buf, symbl, strlen(symbl));
ret = nspu_command(desc, NSP_CMD_GET_SYMBOL, 1, 1, sym_buf,
NFP_SYM_DESC_LEN, strlen(symbl));