[dpdk-dev,v1,net/pcap] fix the NUMA id display in logs.

Message ID 1513917500-9143-1-git-send-email-vipin.varghese@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Varghese, Vipin Dec. 22, 2017, 4:38 a.m. UTC
  On single NUMA device the log information shows as boundary value
instead of -1. The change brings in unsinged to signed.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 drivers/net/pcap/rte_eth_pcap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Ferruh Yigit Jan. 11, 2018, 6:06 p.m. UTC | #1
On 12/22/2017 4:38 AM, Vipin Varghese wrote:
> On single NUMA device the log information shows as boundary value
> instead of -1. The change brings in unsinged to signed.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
  
Ferruh Yigit Jan. 11, 2018, 6:10 p.m. UTC | #2
On 1/11/2018 6:06 PM, Ferruh Yigit wrote:
> On 12/22/2017 4:38 AM, Vipin Varghese wrote:
>> On single NUMA device the log information shows as boundary value
>> instead of -1. The change brings in unsinged to signed.
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.
  

Patch

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 5a86752..f2f1e44 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -806,7 +806,7 @@  struct pmd_devargs {
 	const char *name;
 
 	name = rte_vdev_device_name(vdev);
-	RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %u\n",
+	RTE_LOG(INFO, PMD, "Creating pcap-backed ethdev on numa socket %d\n",
 		numa_node);
 
 	/* now do all data allocation - for eth_dev structure
@@ -1036,7 +1036,7 @@  struct pmd_devargs {
 {
 	struct rte_eth_dev *eth_dev = NULL;
 
-	RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %u\n",
+	RTE_LOG(INFO, PMD, "Closing pcap ethdev on numa socket %d\n",
 			rte_socket_id());
 
 	if (!dev)