diff mbox

[dpdk-dev,06/18] net/avp: align dynamic log names with standard

Message ID 1516870870-168223-7-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Van Haaren, Harry Jan. 25, 2018, 9 a.m. UTC 
  This commit aligns the names for dynamic logging with
the newly defined logging format.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

---

Maintainer:
Cc: allain.legacy@windriver.com
Cc: matt.peters@windriver.com
---
 drivers/net/avp/avp_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Allain Legacy Jan. 25, 2018, 12:05 p.m. UTC | #1 
> -----Original Message-----
> From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> Sent: Thursday, January 25, 2018 4:01 AM
> Subject: [PATCH 06/18] net/avp: align dynamic log names with standard
> 
> This commit aligns the names for dynamic logging with the newly defined
> logging format.
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> ---
> 
> Maintainer:
> Cc: allain.legacy@windriver.com
> Cc: matt.peters@windriver.com
> ---
>  drivers/net/avp/avp_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> index e4ad7b0..dba9912 100644
> --- a/drivers/net/avp/avp_ethdev.c
> +++ b/drivers/net/avp/avp_ethdev.c
> @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log);  static void
>  avp_init_log(void)
>  {
> -	avp_logtype_driver = rte_log_register("pmd.avp.driver");
> +	avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
>  	if (avp_logtype_driver >= 0)
>  		rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);  }
> --
> 2.7.4

Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
Van Haaren, Harry Jan. 25, 2018, 5:05 p.m. UTC | #2 
> From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> Sent: Thursday, January 25, 2018 12:06 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Peters, Matt (Wind
> River) <matt.peters@windriver.com>
> Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with standard
> 
> > -----Original Message-----
> > From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> > Sent: Thursday, January 25, 2018 4:01 AM
> > Subject: [PATCH 06/18] net/avp: align dynamic log names with standard
> >
> > This commit aligns the names for dynamic logging with the newly defined
> > logging format.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > Maintainer:
> > Cc: allain.legacy@windriver.com
> > Cc: matt.peters@windriver.com
> > ---
> >  drivers/net/avp/avp_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
> > index e4ad7b0..dba9912 100644
> > --- a/drivers/net/avp/avp_ethdev.c
> > +++ b/drivers/net/avp/avp_ethdev.c
> > @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log);  static void
> >  avp_init_log(void)
> >  {
> > -	avp_logtype_driver = rte_log_register("pmd.avp.driver");
> > +	avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
> >  	if (avp_logtype_driver >= 0)
> >  		rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);  }
> > --
> > 2.7.4
> 
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>


Hi Allain,

I presume you meant "Acked-by" above, not "Signed off by"?
If so, please Ack :)

Thanks, -Harry
Allain Legacy Jan. 25, 2018, 5:46 p.m. UTC | #3 
> -----Original Message-----
> From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com]
> Sent: Thursday, January 25, 2018 12:06 PM
> Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with standard
> 
> > From: Legacy, Allain [mailto:Allain.Legacy@windriver.com]
> > Sent: Thursday, January 25, 2018 12:06 PM
> > To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Peters, Matt (Wind
> > River) <matt.peters@windriver.com>
> > Subject: RE: [PATCH 06/18] net/avp: align dynamic log names with
> > standard
> >
> > > -----Original Message-----
> > > From: Harry van Haaren [mailto:harry.van.haaren@intel.com]
> > > Sent: Thursday, January 25, 2018 4:01 AM
> > > Subject: [PATCH 06/18] net/avp: align dynamic log names with
> > > standard
> > >
> > > This commit aligns the names for dynamic logging with the newly
> > > defined logging format.
> > >
> > > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> > >
> > > ---
> > >
> > > Maintainer:
> > > Cc: allain.legacy@windriver.com
> > > Cc: matt.peters@windriver.com
> > > ---
> > >  drivers/net/avp/avp_ethdev.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/avp/avp_ethdev.c
> > > b/drivers/net/avp/avp_ethdev.c index e4ad7b0..dba9912 100644
> > > --- a/drivers/net/avp/avp_ethdev.c
> > > +++ b/drivers/net/avp/avp_ethdev.c
> > > @@ -2318,7 +2318,7 @@ RTE_INIT(avp_init_log);  static void
> > >  avp_init_log(void)
> > >  {
> > > -	avp_logtype_driver = rte_log_register("pmd.avp.driver");
> > > +	avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
> > >  	if (avp_logtype_driver >= 0)
> > >  		rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);  }
> > > --
> > > 2.7.4
> >
> > Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> 
> 
> Hi Allain,
> 
> I presume you meant "Acked-by" above, not "Signed off by"?
> If so, please Ack :)
> 
> Thanks, -Harry

Yes, sorry!

Acked-by:  Allain Legacy <allain.legacy@windriver.com>
diff mbox

Patch

diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c
index e4ad7b0..dba9912 100644
--- a/drivers/net/avp/avp_ethdev.c
+++ b/drivers/net/avp/avp_ethdev.c
@@ -2318,7 +2318,7 @@  RTE_INIT(avp_init_log);
 static void
 avp_init_log(void)
 {
-	avp_logtype_driver = rte_log_register("pmd.avp.driver");
+	avp_logtype_driver = rte_log_register("pmd.net.avp.driver");
 	if (avp_logtype_driver >= 0)
 		rte_log_set_level(avp_logtype_driver, RTE_LOG_NOTICE);
 }