[dpdk-dev,3/4] app/pdump: call eal finalize before exit

Message ID 1517077877-53654-3-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Van Haaren, Harry Jan. 27, 2018, 6:31 p.m. UTC
  This patch adds a call to the newly introduced finalize()
function just before quitting the pdump app.

Adding this function call before quitting from a secondary processes
is important, as otherwise it will leak hugepage memory. For a secondary
process that is run multiple times, this could cause hugepage memory
to become depleted and stop a secondary process from starting.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

---

Cc: thomas@monjalon.net
Cc: vipin.varghese@intel.com
---
 app/pdump/main.c | 5 +++++
 1 file changed, 5 insertions(+)
  

Patch

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 0f70c75..6c58cda 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -882,5 +882,10 @@  main(int argc, char **argv)
 	/* dump debug stats */
 	print_pdump_stats();
 
+	ret = rte_eal_finalize();
+	if (ret)
+		printf("Error from rte_eal_finalize(), %d\n", ret);
+
+
 	return 0;
 }