diff mbox

[dpdk-dev,v5,1/4] service: move finalize to internal

Message ID 1517243852-34142-1-git-send-email-harry.van.haaren@intel.com (mailing list archive)
State Accepted, archived
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Van Haaren, Harry Jan. 29, 2018, 4:37 p.m. UTC 
  This commit moves the rte_service_finalize() function
to be in the component header, and marks it as @internal.
The function is only called internally by rte_eal_finalize().

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
Acked-by: Vipin Varghese <vipin.varghese@intel.com>

---

v4:
- Include Ack

Cc: thomas@monjalon.net
Cc: vipin.varghese@intel.com
---
 lib/librte_eal/common/include/rte_service.h           | 11 -----------
 lib/librte_eal/common/include/rte_service_component.h | 11 +++++++++++
 2 files changed, 11 insertions(+), 11 deletions(-)

Comments

Thomas Monjalon Jan. 29, 2018, 6:28 p.m. UTC | #1 
29/01/2018 17:37, Harry van Haaren:
> This commit moves the rte_service_finalize() function
> to be in the component header, and marks it as @internal.
> The function is only called internally by rte_eal_finalize().
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Vipin Varghese <vipin.varghese@intel.com>

Series applied with a minor change, thanks
diff mbox

Patch

diff --git a/lib/librte_eal/common/include/rte_service.h b/lib/librte_eal/common/include/rte_service.h
index 5e3e3a6..02b1512 100644
--- a/lib/librte_eal/common/include/rte_service.h
+++ b/lib/librte_eal/common/include/rte_service.h
@@ -429,17 +429,6 @@  int32_t rte_service_attr_get(uint32_t id, uint32_t attr_id,
  */
 int32_t rte_service_attr_reset_all(uint32_t id);
 
-/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
- * Free up the memory that has been initialized. This routine
- * is to be invoked prior to process termination.
- *
- * @retval None
- */
-void rte_service_finalize(void);
-
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_eal/common/include/rte_service_component.h b/lib/librte_eal/common/include/rte_service_component.h
index 849c71d..f881ac0 100644
--- a/lib/librte_eal/common/include/rte_service_component.h
+++ b/lib/librte_eal/common/include/rte_service_component.h
@@ -139,4 +139,15 @@  int32_t rte_service_component_runstate_set(uint32_t id, uint32_t runstate);
  */
 int32_t rte_service_init(void);
 
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice
+ *
+ * @internal Free up the memory that has been initialized.
+ * This routine is to be invoked prior to process termination.
+ *
+ * @retval None
+ */
+void rte_service_finalize(void);
+
 #endif /* _RTE_SERVICE_PRIVATE_H_ */