[dpdk-dev] net/e1000: fix flow RSS queue index error
Checks
Commit Message
Igb has a bug about queue index for rss rule flow
configuration when set redirection table.
Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
drivers/net/e1000/igb_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi,
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, March 21, 2018 3:18 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/e1000: fix flow RSS queue index error
>
> Igb has a bug about queue index for rss rule flow configuration when set
> redirection table.
>
> Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Monday, March 26, 2018 9:37 AM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix flow RSS queue index error
>
> Hi,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, March 21, 2018 3:18 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/e1000: fix flow RSS queue index error
> >
> > Igb has a bug about queue index for rss rule flow configuration when
> > set redirection table.
> >
> > Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
@@ -2794,9 +2794,9 @@ igb_config_rss_filter(struct rte_eth_dev *dev,
} reta;
uint8_t q_idx;
- q_idx = conf->queue[j];
if (j == conf->num)
j = 0;
+ q_idx = conf->queue[j];
reta.bytes[i & 3] = (uint8_t)(q_idx << shift);
if ((i & 3) == 3)
E1000_WRITE_REG(hw, E1000_RETA(i >> 2), reta.dword);