diff mbox

[dpdk-dev] doc/vhost: update zero copy perfromance tip

Message ID 1524730400-252654-1-git-send-email-junjie.j.chen@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

junjie.j.chen@intel.com April 26, 2018, 8:13 a.m. UTC 
In VM2NIC case zero copy may need some tuning to get best performance. This
patch describes the zero copy starved case and provides a tuning tip.

Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
---
 doc/guides/prog_guide/vhost_lib.rst | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Maxime Coquelin May 4, 2018, 12:49 p.m. UTC | #1 
On 04/26/2018 10:13 AM, junjie.j.chen@intel.com wrote:
> In VM2NIC case zero copy may need some tuning to get best performance. This
> patch describes the zero copy starved case and provides a tuning tip.
> 
> Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> ---
>   doc/guides/prog_guide/vhost_lib.rst | 20 ++++++++++++--------
>   1 file changed, 12 insertions(+), 8 deletions(-)
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin May 4, 2018, 3:12 p.m. UTC | #2 
On 04/26/2018 10:13 AM, Junjie Chen wrote:
> In VM2NIC case zero copy may need some tuning to get best performance. This
> patch describes the zero copy starved case and provides a tuning tip.
> 
> Signed-off-by: Junjie Chen<junjie.j.chen@intel.com>
> ---
>   doc/guides/prog_guide/vhost_lib.rst | 20 ++++++++++++--------
>   1 file changed, 12 insertions(+), 8 deletions(-)

Applied to dpdk-next-virtio/master.

Thanks,
Maxime
diff mbox

Patch

diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
index ef9a178..92dcdb5 100644
--- a/doc/guides/prog_guide/vhost_lib.rst
+++ b/doc/guides/prog_guide/vhost_lib.rst
@@ -65,14 +65,18 @@  The following is an overview of some key Vhost API functions:
     * zero copy is really good for VM2VM case. For iperf between two VMs, the
       boost could be above 70% (when TSO is enableld).
 
-    * for VM2NIC case, the ``nb_tx_desc`` has to be small enough: <= 64 if virtio
-      indirect feature is not enabled and <= 128 if it is enabled.
-
-      This is because when dequeue zero copy is enabled, guest Tx used vring will
-      be updated only when corresponding mbuf is freed. Thus, the nb_tx_desc
-      has to be small enough so that the PMD driver will run out of available
-      Tx descriptors and free mbufs timely. Otherwise, guest Tx vring would be
-      starved.
+    * For zero copy in VM2NIC case, guest Tx used vring may be starved if the
+      PMD driver consume the mbuf but not release them timely.
+
+      For example, i40e driver has an optimization to maximum NIC pipeline which
+      postpones returning transmitted mbuf until only tx_free_threshold free
+      descs left. The virtio TX used ring will be starved if the formula
+      (num_i40e_tx_desc - num_virtio_tx_desc > tx_free_threshold) is true, since
+      i40e will not return back mbuf.
+
+      A performance tip for tuning zero copy in VM2NIC case is to adjust the
+      frequency of mbuf free (i.e. adjust tx_free_threshold of i40e driver) to
+      balance consumer and producer.
 
     * Guest memory should be backended with huge pages to achieve better
       performance. Using 1G page size is the best.