diff mbox

[dpdk-dev] net/axgbe: fix coverity issue 277239

Message ID 1525250844-127252-1-git-send-email-Ravi1.kumar@amd.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kumar, Ravi1 May 2, 2018, 8:47 a.m. UTC 
  Stored register value to enable jumbo frame was always
overwritten. Assigning value based on rx_buf_size.

Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
---
 drivers/net/axgbe/axgbe_dev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ferruh Yigit May 2, 2018, 11:01 a.m. UTC | #1 
On 5/2/2018 9:47 AM, Ravi Kumar wrote:
> Stored register value to enable jumbo frame was always
> overwritten. Assigning value based on rx_buf_size.
> 
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>

Updated as:
    net/axgbe: fix value always overwritten

    Stored register value to enable jumbo frame was always
    overwritten. Assigning value based on rx_buf_size.

    Coverity issue: 277239
    Fixes: 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop")

    Signed-off-by: Ravi Kumar <ravi1.kumar@amd.com>

Applied to dpdk-next-net/master, thanks.
diff mbox

Patch

diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c
index d05f9c8..707f1ee 100644
--- a/drivers/net/axgbe/axgbe_dev.c
+++ b/drivers/net/axgbe/axgbe_dev.c
@@ -1019,7 +1019,6 @@  static void axgbe_config_jumbo_enable(struct axgbe_port *pdata)
 	unsigned int val;
 
 	val = (pdata->rx_buf_size > AXGMAC_STD_PACKET_MTU) ? 1 : 0;
-	val = 1;
 
 	AXGMAC_IOWRITE_BITS(pdata, MAC_RCR, JE, val);
 }