From patchwork Mon May 7 15:11:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 39424 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52D962E81; Mon, 7 May 2018 17:11:38 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30048.outbound.protection.outlook.com [40.107.3.48]) by dpdk.org (Postfix) with ESMTP id 480C823A for ; Mon, 7 May 2018 17:11:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=a+B4Oen6og2+HZfmNpyUlc9r5LueX+etH4Qnuu7VFEo=; b=Oebz+CnN4ZtsELq1PDSngtj9ke/XtDABzZq3m4N8ZzSRkbtgLsO1J23xX5QbP47mfjuNEIjfJPZ3rn6lO2TvvUNGS4r6b0BEMPtTmOHqdWEGT+WHaG30aJg+lTZnGjXJT/0dZxz0Kshms4H2XQduBRR74HQPr98KJ4lrsgj9VCU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by DB5PR05MB1253.eurprd05.prod.outlook.com (2a01:111:e400:51cb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.17; Mon, 7 May 2018 15:11:31 +0000 From: Raslan Darawsheh To: gaetan.rivet@6wind.com Cc: dev@dpdk.org, matan@mellanox.com, thomas@monjalon.net, ophirmu@mellanox.com, rasland@mellanox.com Date: Mon, 7 May 2018 18:11:17 +0300 Message-Id: <1525705877-8646-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1P195CA0054.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:5a::43) To DB5PR05MB1253.eurprd05.prod.outlook.com (2a01:111:e400:51cb::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:DB5PR05MB1253; X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1253; 3:9bparT6NOxFKmVD8+nGYiukNb9qq98//Om/iaRTQo+nkektqyz2OcIBne0vwzSkekDfooBSHRlw0200RBEmjLmQzOa8AY0yc2BgsuERAkfxfnD+7dkWOAH3N3KrW6QEZj+Y0FngIqBUM3E4SPqETFafAVO+UmxLVqcsXc76yNXc1OHzBs2zROqA48rEoXE/+zfeNz4e3NlV74vSgrmiHry2ZGi5B3RtTT6UQTEaG/IKd/PVqvl5kSILvzLZnkNBl; 25:WsJWSVa81xQz/xRv9G81TcP7FVej6foptwg6yjk1QjEt1Q7d6nXhX74ZklRqHCpj8Xsu427k1HX0Dox2XaDxM6LeuuDUoxzMuVZropsEkeDR2FQW5I+hPe3otbHPZxlB4dbt3zvZ2RMjENR0Mga5+/mwXEjIAtK2IkaaGUDhWXpipURUXjhJWtDNNB3rFcM6ddPUPtYXiRcTwuJ4iP0oRTJD+z4Q05vvH3UBePOMOfxS7uqCtD0YDlxpsFlUFP6fSQsCM1r/jlzk5fbsgLi1PD5xRLXfwf+pFolPcP+RhKbxyUGOV4rfhrE4tv2QKfKvLo3ZUYfRjFct71/SHNt1fw==; 31:k7RsjDQCtO/ZeIq2LZFC58bzHNGilwm8lfVu8T4ZKo0IZv34AOFZpdSbD6VhrbRvzon8lKu/QX2NVpSoY7iMnmDOP8OK4f8TQCYhVsOB1pliX1zBdjEvELqZPW/vTm3CU6PX9RU5fSPxrHE0+9teLSa3M3w0AVdN3k4262rEb6/G6OQnjCLzpX64Qr15aX1YAfzVbwEv2Y6+JYOInJ9Nf/SZojQTFIdr0BwpyDgQe+w= X-MS-TrafficTypeDiagnostic: DB5PR05MB1253: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1253; 20:RV4kJyaZm8niP2yAvCqw91o38xdZQxbJkrycvHdvmO1E6+cJ5ufx7ywkgRoaBXPVTcWv5ggZloxcEGD2vvYrvARZwqYhAgCaxJXPOLR+NJ/b6O4Cwz24GINnMeDurcpDES+J+ag+QTSGG+cywiAkDfRhJwpLuBgFCS9yNGu2qq47Vul6Fiwz8n3i/LCLenM3j5YdkSJ5OIwaFzQE3HfyBx4Ucaqmv88lM9YgueZmgADiOy2DUfajlJtPYiRozUsNV1LRyxpQHss+jPW6NLHT3iN3e6tjzPICKWOf6QjmK6QU+YCUHtyMyivQb5XcCI7dLeo5BU/WWaK7wqetTSYXQQqsvyqTHYheZVeg1iHuuEmgoCkxglyzObqd0KdGy5O6VwROHuqFstFdQEJNnci5ytLIltyYFhWkGyCi0MQqNlGnfAe5NgSt3C/l/vnhMJk1+My0t+9BN2588FysZfdD6GVmIc0ZyKBwoJDSxSQDO1ZYFCtqB8ykuT3+YVZvPhBX; 4:Mk0rT5EDzJ62quuUlP/ZYt9GBpcOfpe+JVZXj3LRJ/vwJliWk2OCP/PbmYs1Y/kpbwISllClkAIW8pGJPlt17IBRXQ7VNFmgewxoedFDAXxADDiJHxdfa2FUnStmh6KQPCVXjuFrB+JDjEOSfu4CK0xbiYnf1FXQxjpE9WlvjIEDqacFrzKzrnUB+9w1E1llbzXyYernBdgpO8oXon5e/8tb2kGZN+hT6gz4l88CaBqYDgntv5/KSH+JXPQ1zCpDV9Ay9Ituv2nEpWnPG8Pfaw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231254)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DB5PR05MB1253; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1253; X-Forefront-PRVS: 066517B35B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(39380400002)(199004)(189003)(305945005)(68736007)(21086003)(97736004)(4326008)(186003)(47776003)(59450400001)(386003)(2906002)(66066001)(52116002)(16526019)(51416003)(26005)(7696005)(33026002)(6666003)(53936002)(16586007)(316002)(55016002)(36756003)(6916009)(7736002)(478600001)(107886003)(50466002)(48376002)(105586002)(106356001)(5660300001)(6116002)(25786009)(3846002)(2361001)(8936002)(486006)(2616005)(476003)(86362001)(956004)(81156014)(69596002)(50226002)(8676002)(2351001)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1253; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB5PR05MB1253; 23:emL28m+p6c1m4FSUdkq/EwVgVtrI1dBVc2J+bw+Rn?= dLklcy5cAZryEzwLbcxTDko74M5ErR/K1cu7V6Vx1Ps1OERQsdBZSqhXWPvZlIZVqf4Q527SBDUr5HetuoKPmDcAbB6vgJwyKA1VFEw4WAaNkbKyVbg+yZYLCvLYbzCoKZ3D4a0m0UarnFyS9LOgxxWSA6iHZLr4wvHLez4K61twzEidoyUtjCzlOpf3+M9stjQDsQSyYk4LwfzwFsj1mcBGC2VYtrCP5g2lD74HRy1pk82+7vcyHXvMt9y0DxcDT+dFywNfTvAN4JtUykXCf74H3+emFxONb6mX0aHwUbgZBoMoFABHnEHKkBVfcjY71Ar6qYb6i8iQW2zDfTwhppe5xjmLf4yLz/sKFANfxAEyBv5w5M7hKJFaqhSuFbd5OhSAjrnaK4qpOwSAOjlRFYvsqz7oJZzXwuicQmKLpo1xVz+WiM/1nu3qDojFcpTqZsVPTZELPMorBnNwbx2Ydwqzc5otVKnRYnkaVjvT3Pckh5qK1uSXggvpSDxznWKsY/5kNs3jHXHIbMs+sG12aExRzKhu8Ekx11rUaLhTmXyCkpsOLvG+YVXbDv1mXZ9jT51qbsK7dzJhKn6v1kZSJmfYuerx0CnDphB++TFWqRfguE7QxZYGypt1mgbeDnPUDhtJLXbuqEqFod5xVEbSNk4/5A+mlxlQiZnHGh0hf34q92OcHwoIppZxrP637Z668gjuHrjr0iTDXDhxY1zOAG25oBIN3Va8SsCWcMBoY6gtA4bLiSpqYidvNcxR08geicgUG2Ic8/9KhY6oUapd/AK7KBKYeV22QyxV31l0dmlwQego9vSNt3gZPtE2E6WfHbednmtnc1hh2HYD/8fyEy5nbW+lAVAQlMsFTxe3ireBsEZWOtzkptqlPOuhTmkTeKPXU/Q5Ngpz7F6v61JCcXqHMaFNydUiJkwO6s/AZg0YfnojlcV9A23LMpHF1R5AHASpg1EjsaikyPnawSkpCethw2iLt4wl1RBeW6Scz89zf0Zr4LPJ5Hcr7avy4r7Ti6RVZ3w1TchVcZRMKNHNPopcZY4BSkiRdZwM875EFtQBjNYADsLlQaDRuJt58cmGgqbOEw+kNrgKnbFXMp6o2c3tQB0wHnCyHse1iOHYerFqSr/JlJUxBs+fUzNapbZE70q81alPG9C1HF8+An0eG8TNk2LDWXavo939rLHryPIGbEfE8aRsVuyHKZG24K75sA= X-Microsoft-Antispam-Message-Info: px/AuN78tsGt0a9oIlN24tfyIc3ASc+RgdY9Jr6tEmQSzMd8qAQFHEx4gniJPZ6+7OkcHe+xpk2Rri0KWFzcUaaRZpzONbuxZO+yLoB8+A+OKHgwM4FfHNM+x7uqE8fzBTkY9FSiWaoGXfQqoOHPvU6eJU1s0kN8/294k6KtiIFWNypjdrtnbDQVij/v0tB4 X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1253; 6:13YTh695YEEkCuKhjkjV8Z8OaVSIIlBW/63NU/nN5f/evH84ps3XXFUapmc2WAqKfcw7cMYSpeV7wqscLWpVsijrOkvkMQUcdtX21KMJcTS4QDTyYGnZjYh7jtyFsd/RD0QI/mmli025H+mpIZtQqz3jiN1J76OOSnTDUelwIRdkGfNRQdzH4hZ3sEAWFKbdUvXXtx1ZeRR63ah1EtGHPDVwONVcwloWygCib5YFFQjTSL2Yx5/tktVtYj/z3v9Ojjzelge6RBmMBnM52oZ6utRQsBxzwfR5ltJSfewX+LdZOxRBaPjKuruBZq5arrtJIpi6iNDU5+IMU6dsK75vrIUERxrGCDhxJVgxbtPNJzkf+1PRJobVV6cAaV1S+aNy10Dm3GMF0wsvedCWP1yO0SP1c6POZIpu45emoXGMzdupvSfWRgifYSauP7Jcn8CxRBpSne+jeJTHW4xRRoczSQ==; 5:GasOdiCwGRUbBeJ9JBOLsXQlKDifeMJV1S1bYlnF/I2NE5qMY2UzdU+1BW1Mt3TK/XEKYUolp4XjqoAn7GCLOy5vZKOoLWElpDIm0sfjWMh/b/lwDi24qq5+dLb+bJcJYc3Ounp+i25lpsE1fuQYg9quUMBXcMXPRCrgxa6fu94=; 24:6VhoZDIEU7Zg/0SgOC34cgzsKWlD7+bv6XK3DUwuQQY6yBLIWo/TVwwhF6Sn5taqVn2GqLmOpkKbw04ulQ1oLuarBuQpTEio/Qg3ODSs1fA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR05MB1253; 7:RbW+yqyp6nqZ/pWoPFPs5aAdjtVNYB+WAN1cXSajtShas6eqlmFbUy/3425agCcHg8MpjVG6U0bM2Z14AmdSL5R/btv0QJSalRlR3DfyP75r+ZEge8iqs7WIOlZG2xXQPoZ1AeTommPUCl7oAHzTjjYhZOkJo42+T36fPu1DT/t8GmEyeElhF2DVVrgW3MMBYT8VtkDSruFa0RNk3aGc8iTQAzv2plHKKTQIIjUZiSAaCqeLaiZ/PZ0gnRAxqK5t X-MS-Office365-Filtering-Correlation-Id: 7e1d3d1d-875d-4092-8b3a-08d5b42cd127 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2018 15:11:31.1351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1d3d1d-875d-4092-8b3a-08d5b42cd127 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1253 Subject: [dpdk-dev] [PATCH v2] net/failsafe: fix starting failsafe with invalid MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hotplug alarm is the mechanism used to initialize the failsafe process (trying to reconfigure all failsafe sub devices every few seconds.) When starting failsafe with a MAC option, and giving it an invalid MAC address this will lead to a NULL pointer for the dev private field. Then when the hotplug alarm is called it will try to access this pointer, which will lead to a segmentation fault. This commit fixes this issue by removing the installed hotplug alarm in case of invalid MAC address. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. --- --- drivers/net/failsafe/failsafe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index 5e7a8ba..3a747c2 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -226,7 +226,7 @@ fs_eth_dev_create(struct rte_vdev_device *vdev) mac); if (ret) { ERROR("Failed to set default MAC address"); - goto free_args; + goto cancel_alarm; } } } else { @@ -260,6 +260,8 @@ fs_eth_dev_create(struct rte_vdev_device *vdev) .type = RTE_INTR_HANDLE_EXT, }; return 0; +cancel_alarm: + failsafe_hotplug_alarm_cancel(dev); free_args: failsafe_args_free(dev); free_subs: