From patchwork Wed May 9 15:57:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 39628 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F3F71B3F8; Wed, 9 May 2018 17:57:56 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0042.outbound.protection.outlook.com [104.47.0.42]) by dpdk.org (Postfix) with ESMTP id 5791D1B3E5; Wed, 9 May 2018 17:57:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aM97oEK8eUVhZCK2XW03hHxNGit+NbudlCRiHB1GIaU=; b=mCNnfbk6pfiCg/CEa96Jm8//Gm8G58cqe/UZ4ZGWFmjJyaKw803NlnyTFPZGsv/9rNI2Ov7DMAM99EJsCXJOzoSMQePvF/OhVH+H6c/ILxMmgUnmbCH1oyPNIL8vJlt5winlWjzc3xN3dLMjxj6NqA02xt+pPbhHtVxaL8iPbTg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR05MB1260.eurprd05.prod.outlook.com (2a01:111:e400:588a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.735.18; Wed, 9 May 2018 15:57:50 +0000 From: Raslan Darawsheh To: gaetan.rivet@6wind.com Cc: dev@dpdk.org, matan@mellanox.com, thomas@monjalon.net, ophirmu@mellanox.com, rasland@mellanox.com, stable@dpdk.org Date: Wed, 9 May 2018 18:57:39 +0300 Message-Id: <1525881459-3643-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR0102CA0094.eurprd01.prod.exchangelabs.com (2603:10a6:803:15::35) To HE1PR05MB1260.eurprd05.prod.outlook.com (2a01:111:e400:588a::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR05MB1260; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1260; 3:KLcwhpe9+CRy41KaICyAq0IUjGRslL0MhWd8hXH6SLAJEpYAoRAz+pygOBB9WEIAHCPP9MA1yZ7iIDPYomJp5muRIRRWjDFDEU36vXgWkNH7aZ744oir064KOHJdlcZrl640NYmIWShwaDu2im1mB0cwMzlemyJWrvPCFo7KLap9T9LVOOAmYc//XL/2glLivN1HenL2muvLTdv2KprLi767HFsCkp7DjqwTmFM/yjRVKAwKdTo1bgg/S0yqRwA9; 25:7wn0bVCl55Y4RvyrjxFnn9BT+zN0Lb2pBc5rIdfkjQ3DcTD7PBCHodEHtQbsgahyWuvownyt0z45syCnYUS9EcRPfP77A57s6O9BQVltlaUNh2cvpLS0uD6L4ZLp5VRGDp/L9/7B7uQJdWw/2b4of7gwtVKfRcdYKoJ06haSABp4fL2HvGtCMKC4ZoxqJ6nkzNbxXwM8+sXE9ikQB78ctYVp1zYin/Uw0zkdVcgp1IwVg12XXwU76gywR+FpUnhzDwh3rJ9q1Ohsr4d+goiaiS+3hZv1Fb8BkILadIunZn0Cr8xWfd/tWsJYiErGRH1el8WWbN2PoFb+ueHcJo3eYg==; 31:vWZrUunnYpYWEmyoHrqtQdnTccODUcIPgDRqWVEllA95p+mIoEFFQ/L4iQuzzjmaswgae6nDaPqbu2w2uCwZj7K7oXnJCjMbOQr/pyPuVWhWhYI8pavjxswgdyXlfME2Y5P4ASyuhckYL1Z2VcilyjKonmGu1g+mej3QKOkOLJTmm+v1CccDf+6hV+WUv00roWGJMA/wJXHjsr2kj0LWUmfp+APEzWz+AjbyFVrmy0w= X-MS-TrafficTypeDiagnostic: HE1PR05MB1260: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1260; 20:c/b7IRIH3+IzbHRDHH1cXplq/cW4Ln54u15Xrl3ITjcAR0oPGtoUJUKZuFEc866qgcAadk119V4lR6TRVVOSg7aB3JkJKZwmzjFf+vBbQO1tT3e2OxSJAL23tKZwrRBOfvp+kC9Zzc3te5i+eY/OXnDzjc+ow4xA2j4MusRyTJxuERPCluqksXv1TmK0Fx+q0FMuK8h3KkIUZP4Ae9N8rGZPqAV/8E1+/FCq2HUzIeq6KdI3tpBl8lN7U/xYbvb6SXQV3yTPQ7qk+PIInaNPNgzvBYxvw1GixGBPUfxhaFsRuyPgMRoXwMgOsPdZbLLh3bvwqa+vDo7n+uOMKVOXGDj/G/HduB0xUw9HHkGGVviAnV6cZnvJeIy1BwsdYVMar61T69GYuiE1WmZGewxFgSNmqOYvsVMnqi9Vq6AbpPsVQrKm/BcJ3Z0hfE6mhElcqttQUuFdeCWEz5CgX13+FbF1j55nwmfLpN8HXZpqUBPz2GptPIIo6XmFTNUIV9Mi; 4:ePAG9CMeIQr5jZEViYEOLD9u6qvRUQ4aB/vSbIt9eUgmMcy7NGMiXU/6Qa0SFEpH6XZ5ErUsPNT3x2zcdHvrZIWv/G4vsAyzEyogOMkZu+5+l6AejLfMjD9wEgNL6kimnVGlfIVzfoakq5dB4BCCFKhBeLoEUw4H2LT1XZCKIhOfMmRjY8oCiAgFkBOe7HQHx8kITicHUhvegA/QNNLDJS4Amsjo7OkgUyNXEcmlTc42/A84w4gmJf3snfmYDRUJuIDsy6TSt2p/422mIWPboQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR05MB1260; BCL:0; PCL:0; RULEID:; SRVR:HE1PR05MB1260; X-Forefront-PRVS: 0667289FF8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(39380400002)(376002)(39860400002)(189003)(199004)(186003)(52116002)(53936002)(55016002)(8676002)(6116002)(81166006)(3846002)(2361001)(7736002)(81156014)(6666003)(69596002)(2351001)(6916009)(16586007)(16526019)(5660300001)(25786009)(33026002)(51416003)(97736004)(26005)(478600001)(7696005)(59450400001)(66066001)(50226002)(476003)(316002)(48376002)(106356001)(956004)(2616005)(2906002)(86362001)(47776003)(50466002)(68736007)(4326008)(305945005)(36756003)(386003)(486006)(21086003)(8936002)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1260; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1260; 23:dZW6zR/biyz96fwSDnLrWdsuZ9su8ZIip6rzKyiJ0?= jdJlU+sjih6d3c4VzvVvBigDpBJA1WVeYxfQQNdGACHN2U/KQzJLSypaKTGvIkZTveXgaIPFkgoTlEFFXR/w43PqctVwVay27vZkAGL1zKsJRHRbEBc4cnQt/iRg6LGV83jlXbY5GvBfGriszPGoi6wKPMTnkzpU0yTzw6IRMWxxMXAyuf+2twSDgfv6a3C57xcxSWailEpohDtfvsbQR7AOfQHDxIbUrdeRRqq1G8t8uBFufNkyiIBQb/6Ph8hERsRFPk5OttC7gHZINWM/UD7JyNEUnTGTzfupH7X67QbfSo18XsFe5mnYUnLQF8E3IpxW3CBHyaEXoKzh6ilyLrJbqXwcN9407dmD10TAZt5bFnMj8rzQT89VxO8jgLidruuiBn1DU1+uwDmLpkdswVdldZa9lFDpKVtV8l8EHC5kd2Odz/SnQ7SVYlp7GFWFi2s0qlg762AxMyQ1HnRZFlqDUo1Z2B28pwTlCeiu6YBRHng49V5j6D5Cog54rqJcTSp8dz04Xm2GFWqAsy8V7GKUrvQ8T426RCwFJqTySxPu48RsHq8tLh5KBvsiOg0/YXaUsbnUmzWo2f6E7kXJKYjCL84OaQ6lF1dQ8LsBwaIE9zs4PGP8d+B6fCG1WsoqC1XM9AqE+Y7WubT4WBGHMNwLH3zZqg/ik9eqD3G2983MQN+XAkplAjRIKoGDBWBXOJtI1MnXUQ3rrqDXwbjrd9DMiplKQ/gF0COhr5Jk58CPY/RzSNLO3f/paS5KDp46gibfilr5eff9UfyzeIOa2MlAPj2YuSv9gmAHuXbQ3a8RfpdtHHlnfuhj/HpBXjFC5G3a5t2V4ei0wJholppv7BOReB0ZlUQrWc1Kr73xpHqJl0wcDqaeQ+Mnyv1o6hrlAwH+cyrV3FH7gxhWKbXqBOhXcW6/SjqvSzMR3AGdIscN10nIubVXelYwvkF1s3+EbUdj7/jHxXtqQsIjVo8NIVxQR2WsIMmqKiKwWmaIqplLOU6/S2KzDWmmeCDiv13JUfFv/o3y6yIK7YUQ9l0sxp514xrxgMQg+HIy3/l8D/ocPymP19ZdrZpEZm+ac9wbsolS5lJcsYKzD5aqSYNqAxeOtqpr5WkVp76g0KMzsXV9BXTesa/dnWQjkNkjLKu//hUE4DDvCKZwRX30TiMHdPBDw3smirehRFnQtCKJsWpMw== X-Microsoft-Antispam-Message-Info: dEv5sAn/T288UbeBqT1Wu1rtLJnX7hcgejO0yo1gGpbwvH+iyYs+ui0SJVQkmkUrmktKsF7lLILeMacZ6/tqFwESeoJts0CGJ6Vqc+Pf9tlqbBRcjzTTixkCQP8Jzuyyn96EU8y41j4MU1/jPk0Jot3kd7+5Spi52ZEUkh2MkcCxrUKhI7k27dJYdHPJC1yF X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1260; 6:CVrKleNVAPmOMyySLRpDnN3i+2200jZP5gGZtzrC9xyhRPmKBbUywxx14fnmtl2EYvn63jMZQ8FCHWEoXwe0CS/zstKBEqKzK8DSdJBFPqyeQ36cc5poN1Alz20mFSSzPUkoN/tCR2pCXrV4nh8LozwW6/iSuItBzs5T8DXTc6BJ9rExCiMqePvXTX6uAc8TfuNAFBwU1TF4vcHmqe3/x/l96rgeB2M839aCgM2+kIMyzvTMliZbcM9ggK5cAaSUokLKQ5Z3VlUFqXOCT07MLd4Fh6g8M7OImLdzFIvWM/HIMLGqYAwajICElE5/Qm02GsMnuleO7bzjAoBCaCq5wvm8tvt74p/inVqoQ+AWcMv0A1J8LBXzTBqaiLXAPx3xpl3CIAip+EIXax+QsQX9N9W0VAzfiBiL04v8968zaNLXCxkl/GXjMITKPdWuT6F7Q5TzmKhF+ABGM/fZEiEKjw==; 5:PnLJpEoIDiUAqTSjM4AknljEfjXOlxOuRJOsmJ1HiUsZ73A1jJ3lUXj/wSzaWYrONeXKd4JdQuDlaD5vOJgotE/yl5wDlgAQxqr/LLaMrxA3HMyS8d9AHh03XAF4wnuvjXaA72Vmg5GrSDcW7j3HEXGXv2adyJv6QHOBSovMGuk=; 24:6aOVfRZwkc8d6xPRE6JfpJBcs6XIM+OHB8ZZYgwSsYWBZgEpGCFfKSB+IjRW9bI5c6iiFvK5Tfnsy0Q849J3uTPFEu70jriCAvCzufcK0bY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1260; 7:JnUDIj+4V5RsmkeUNoWC6lh/ojklzIfFjvYNAhpAm0oa3w91+prBKFGImgaIHOuCCfw6bHk4drEoiQ6t3GhYrXDXViwi745bQP1NuGacyZlhZFj29VhtPHJ6RjUFNmUu/xcXOVHbuQpdcID2AcDjJ0IqVsN/2vzoMZAIBNKCDEHzUTdA02vLIrhbNd8bEHw1j1Y/xCWa10Sz8NBvj6GNaIZLSukjVcdfFOh9wRuKXdc/SmaLrglawY+CjUFcIyxO X-MS-Office365-Filtering-Correlation-Id: 0beb2a3b-f6b0-4193-285f-08d5b5c59e77 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2018 15:57:50.1461 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0beb2a3b-f6b0-4193-285f-08d5b5c59e77 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1260 Subject: [dpdk-dev] [PATCH v5] net/failsafe: fix probe cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The hot-plug alarm mechanism is responsible to practically execute both plug in and out operations. It periodically tries to detect missed sub-devices to be reconfigured and clean the resources of the removed sub-devices. The hot-plug alarm is started by the failsafe probe function, and it's wrongly not stopped if failsafe instance got an error. for example when starting failsafe with a MAC option, and giving it an invalid MAC address this will lead to a NULL pointer for the dev private field. Then when the hotplug alarm is called it will try to access this pointer, which will lead to a segmentation fault. Uninstall the hot-plug alarm in case of error in probe function. Fixes: ebea83f8 ("net/failsafe: add plug-in support") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Matan Azrad Acked-by: Gaetan Rivet --- v2 changes: Reword the commit log. v3 changes: Reword the commit log. v4 changes: Fix the fixes commit sha and title. v5 changes: added right Acked-by tags. --- --- drivers/net/failsafe/failsafe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index 5e7a8ba..3a747c2 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/failsafe/failsafe.c @@ -226,7 +226,7 @@ fs_eth_dev_create(struct rte_vdev_device *vdev) mac); if (ret) { ERROR("Failed to set default MAC address"); - goto free_args; + goto cancel_alarm; } } } else { @@ -260,6 +260,8 @@ fs_eth_dev_create(struct rte_vdev_device *vdev) .type = RTE_INTR_HANDLE_EXT, }; return 0; +cancel_alarm: + failsafe_hotplug_alarm_cancel(dev); free_args: failsafe_args_free(dev); free_subs: