From patchwork Tue Jun 5 23:03:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 40661 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 068AB1BB76; Wed, 6 Jun 2018 01:04:12 +0200 (CEST) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0068.outbound.protection.outlook.com [104.47.42.68]) by dpdk.org (Postfix) with ESMTP id E637B1BB6A; Wed, 6 Jun 2018 01:04:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9cOix3vigrBs5GRtcl14xpqXsJ87z6zei1M5uSANTD4=; b=Sdn7DyXVdr5SRJmja/4wHQ7Wa+LS56kQ8zISdNd11fP7SpRPM+ixIV3FTxpbb+QnvyJvVMC5hwoscEc6KQB5UBGVQFKLZrsI12weU7U1WUOd0JBjxZrvfe9wVlAYBBG+H8MqDrRo5UV921aAdh1V9xgXJzKDRGEcPM4zQfJodfs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.0.2) by DM5PR07MB4022.namprd07.prod.outlook.com (2603:10b6:4:b2::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Tue, 5 Jun 2018 23:04:06 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ktraynor@redhat.com, ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Tue, 5 Jun 2018 16:03:57 -0700 Message-Id: <1528239837-6424-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1527873381-23910-1-git-send-email-rasesh.mody@cavium.com> References: <1527873381-23910-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 X-Originating-IP: [198.186.0.2] X-ClientProxiedBy: BYAPR01CA0023.prod.exchangelabs.com (2603:10b6:a02:80::36) To DM5PR07MB4022.namprd07.prod.outlook.com (2603:10b6:4:b2::35) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB4022; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB4022; 3:q6mPfI+IEAnjNTWI1P/gUxdjRKlRKNVgj83oaMRDE8SxYBbDBwp630nwmx2flRpHSuSnLZbtkBd9Agtik5YQhkCDHnRyXHdF7D5fwx8I9nMhcKIWgTh5Ue+pZRn8w6v0SdSAKqDPiHlXXPx0jLxO0EO636BmUNDb6wtJE8WcRwqTuKMTlW2W7ipgy1sEawim+b2LFY7TN8+1glS0S59i+mQR3c5lJ1Ht+Ka6aNRmCGhJecs5NBK3/kxAz9tmI+o8; 25:+KZk1jpXtW+u+EKBijpmg7Q1UbUmC09IW25l7HWzcFQalHLGAx2iHDtqDX8od8NEijl4sNDz8XOxjRc/FZ6NjttzWbjfLbT0doFru4Z3CBCmEOrOWfhjF/5gFP4vulSTVMw61j/HwbEk0FoQNhVmQhLADV2r4j9MOD9LIidt1jyN+Qw7NK1yjGsInIOpaTBWtWl+AVOXzGW/Zsaz0JVHe5FGJH6oE+lG5lX/NtcoY8+6Uz05CIfTJMh50Kwrmo8yoko/75Nz/ueFVVkazQ6SfT0j5LXA9TF6nLxYHBv2VlYSa4225x6cQ+bfvpELQRaEvykALZzIOnZO8vjE3Tgazg==; 31:SSU/QFzRbAebkeNv3EBM8kls+OVKLv3e/Q0nry4ppn0oYIe96ywyaZL7lMB4g0QWzcL41XemLmwtrC1s2X/iEqyzU0Lj/uKGSg5jjSehgpTPbRTsBwWsn30dA1Npu+3fyjaUu18H8z5J++WY/Scoz0xG2nBkASVItm0fAqX5d7DQ6A2np0MpJSRzhq5274j2mSTSGBjZUb6N1iy8i0xUnv9Eyc071jJk+v6UYAWUrCc= X-MS-TrafficTypeDiagnostic: DM5PR07MB4022: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB4022; 20:iKjr56TeuMrZSzBTGiU7itvshR4B3lOOjP0rwmO/Zh0afBNB/ZDPpWK8LDKKjHlRFzLENRqOhSbfAQxyP5geXWyJ6klyb6C+Xy3KMDjTw4PvtvG3mGeIOW/kgeW/5QWqwI3xP7Gf2ANGf1sKrVktKubt2XZyrbC6BZ2bMDY6RNQ6nqnIwaROMTYrsqTWBiEEWoFa7T6Ai5plJdxT/GM4isw83r17sJqKObaibXSRibzZp2RwJ2xNMGFvDuBdz8DKhGiLzf5L05CQXQYlcweD4S00c6l22qRO7bIQ9TWRbmk5nYtW+79CVe24sM4wOI9GNZtCd+DeuVzU/DSXOuRmi4HLw2QB8LtPwSdpUaEuKS2LJT/K4377t5yQgtADvojiXxzGTuiDZxAcLIAzgc2y9/A67SfE6oab6EnDHkTGIV21wK2e5+BzHyKOCW9paYlD+pswnS7EJU7JxfmK5GHISe+fd2BRMimC4krNJ1eUT5VBcmk+MoAjbdZICmBB49k8; 4:tDqpfnxhE+g8v4N1NRFPd6mkqbzYC3zVhoyzRyxXGuee0pzFJ4f9UdAwlmZXuhx9QUm5QKwc3MuByEkoqc8PB9dTSUSaqSfzI3e1seBZu1fOUG47OrDx2cYOHAjswalvlz1+MryRXega69oTYWRpB8u4IkWdYroXjAG8254yRgPiFR7c3TB/3+YaGxe2wfOcCk+l9yKmOZepUI/nMaomtzgCbwaR8xiIVyT1W3xdsjWPqsxn0BHUTd+YZoNswyAeVBywSYGoHGWEsp4LXAOAbg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:DM5PR07MB4022; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB4022; X-Forefront-PRVS: 0694C54398 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(39380400002)(376002)(346002)(396003)(199004)(189003)(316002)(305945005)(36756003)(53936002)(16586007)(52116002)(7696005)(4326008)(51416003)(386003)(76176011)(59450400001)(2361001)(6116002)(3846002)(26005)(2351001)(66066001)(97736004)(55016002)(86362001)(25786009)(21086003)(2906002)(47776003)(486006)(44832011)(48376002)(11346002)(72206003)(478600001)(956004)(476003)(2616005)(50466002)(186003)(16526019)(106356001)(8936002)(50226002)(105586002)(81166006)(81156014)(7736002)(8676002)(6666003)(6916009)(68736007)(4720700003)(69596002)(446003)(5660300001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB4022; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB4022; 23:1QGIAenMQDz3w4r2JEnHG3NPB6G57s7DMXev0v0vc?= tP7y0hH0ggeTw/tkjCRan2ddUcay3cfeYF876LKkcU+pc2AOOzdKlCJvFV3V/EmlHvr212poD/oHqcRBkgVxIZA1N5VVedZtcaLzMjY/hPdIGSXhENaz41k710iw4/o0N1bxb6I4BYXrgVmTQmhDYPY0dNlVYD9Vrnls7TTLdMHtxRFZc7V+bsz+Eyltp7lXUNWAQqbsw01EgAhlluM4J1xOmG9DEdrZtb3HU81K5MSA3o5r71et7Xj6B2+dpjH/8rOFI2iDulLliQz4D6ls9eJGKqPw1CLgU/SY/OzFjtH0ouoLxJuCHjFehqSGuzmTNPZwD0mpLAAFBPGVg3vGtKHLnnWE1iLNUkr3kBsypvY/d4v+z2VYZ6Gy8uGzC7WiwZKsu9aAoVOWlrSZiGyzw3sxMAzd9aMYf/hvbjttbqWrrHrcEozP7vj1af2n18IYOG5qtG5v1BjzN9x9piazn4IRLA2CcDBMTJJG8A61Pu55wVwWE8klaR2Bi6A84NWXKq3zynfsY5qHTwv8Iv5XrOxc832W2XE05lLL3ssn8agWnD9sqF8zPzFrYIgsVwT+yfjawbXPJpn0OJfQqnQQw7NMPh2BHmsydM4n2kOVVsLMH6FLa/vUKjnEzKxdpxYS9rlVjMPdrjWyGubkM9pC4UJ17hmSl2+aI3slp4mKvbt4FIL7Y4+AO+MTAY4gJAlttFuWY2pmLdCP37BwqC7RZiKWhaAvVWAF1YqHtO4/gr7MWDYtvyALPjk7pVaQa9Bry4sQ+69P0XHY7Ob4P5xptcHGC+j3hsE94exTO8DK6ZbKznoP4sWaaiK8d1925R5fkbqIeJzUr5sTKoUXiba/yqd5Bu7hKlYKXrRV+8+QprnXQtlvgRu2+P3Z3+Tkfg6AcqSOjW9nVeGYMCwTzBygKf4+OhxMCPoEOZDo1yafT1yHiTe2CwBpAtcqEZ5U0ERwFQTjV5eNLiAZ1xW717Zp7R+ndiK5taEvyaXv3xSioyugByt8LOUZX7Puaf9dm/tR8JFUZ9nSEoeJklAjBS+yohHiNDX3Lb2oAXDE+0FEr/IvYZpHSNcXI3pvkfaUfNgGua+5Z2wDk/HfcdRh5IOotjqWKjpK9GWHoT2mpAkw6wZm0Em78ijpNoZb05+iaEkCf2HPzzYRWaXM8DL9Eh3ek7Owohx8krxW96+vjzFIY6tAGTlqlQEpRuoKTJVkeOpgpEHWp3up6jDAF6tXzJClP4EsxZp7iqKFrzq52OpDWDbPEnQhV/3ZQCUrz/5EWeZDqeT/uvwoKvVj8JIn82Eeok7 X-Microsoft-Antispam-Message-Info: i7HxaB/H8AwlVTghYBLH5zUWNJ+ZdS+697zxoP65kQjKOE36LtqXNkSbIsmpyKUYr+pzjOUYH0DeyhF+G6T3hihiKTvmmnpkOqZaRkGtGiwfUVMRFzZBsI5usQnUDpxApTPK/EClt3fkSdJszT6MG99S0rtP5o90a67axwlJgZuJbc/8gJE2+ds+VwUOemOx X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB4022; 6:8hpxl0RywOODQGahmMijNPQ8PudE35jU9AQlp+EUSCk6oThveO2HYN5ffFtX7Bjp14nApKDTiY4Yqy9EiKr3uEIITG/Qi1/gROrH2oCoP7Q2hJ1dFOasnj+Dl7eVfCfbpcleIHHce6JzOY+LelT5AYfyvKIZOQVxUGr0539gV2lP7egca2I0HIp/PBsmuDLdrvqKcCfIJ8WpWH6TLw2YLVtRAobGglwpkFQvXKtjQMACLtJXlloZ7xccolo9sFJyaEeSOR6Xsa03D+XzWUK95JKToSiY4V+oSpHH9pOc8Ilpil764I1lZuUTSdKR7JrrJ1+fviW+cciDgAdNcEVO5MJqdedksmMgD8oKA2fHwGm8KNWfh5ICeXjPh5tax8S8liRwEbPo1K+0vMwXfoLQPQDk8HOelr+CNZ7WQjJ2a+7Oq+ZcL+/9oSnnBeWBA7BBiMtUs8fTKvDzKpzF25FMPQ==; 5:3XjcQ9wL6YldkpnCgBV1s/hUBIuA4zCr5FXjGZaBXf0Qjy3HVJypIuuVwq71XCZLLRAfLriNw6wAqwWqqveAI/x2253wwmlFaMJQMDRkruS94ari6brICKhlEbtbXoFKDyPvA6qYtWr2CJv0RkIZzzeFF/+eWki4H3TUtwg90Pw=; 24:BFHH1fyeFvaUZVTl2hGnYvgAnDtEtzO6UEr0i9bO4uvQkHicppAuppTX9Nqk31IvInjxiVn9y7oI1IpIcOfiCsDXvUKGegqbvtGuihaWl08= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB4022; 7:0LBEocmXbgmibjtY+DAFQGS4mZbo07YTJvSOC5f9YtxOrdarhemfIxju+bkU+F33TKKrDcl1O5UE6et22k7T+cwRbNMrPF5LWdaeNb+w7xA/jp1X2Fo5CSjRfXQOVDdoSNMd6RROWDNUjqgX8YTzkzG2LAPq/Ew+TZcZ/zHHHqpk6UD7AkqI1zzBaUWL6SwFEfvoOyLhYg2QZ1Hgc37zTTz4OoNcIWiVL8j18A+GcAcdHI1q32YpRP7y8iKg20Sp X-MS-Office365-Filtering-Correlation-Id: 979fda39-f595-4709-440e-08d5cb38a3ff X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2018 23:04:06.8272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 979fda39-f595-4709-440e-08d5cb38a3ff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB4022 Subject: [dpdk-dev] [PATCH v2] net/qede: fix L2-handles used for RSS hash update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix fast path array index which is used for passing L2 handles to RSS indirection table, properly distribute rxq handles for indirection table. Currently, it is using the local copy of indirection table. When the RX queue configuration changes the local copy becomes invalid. Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody Reviewed-by: Kevin Traynor --- drivers/net/qede/qede_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 3206cc6..5a4071b 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -2210,7 +2210,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, vport_update_params.vport_id = 0; /* pass the L2 handles instead of qids */ for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { - idx = qdev->rss_ind_table[i]; + idx = i % QEDE_RSS_COUNT(qdev); rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq->handle; } vport_update_params.rss_params = &rss_params;