diff mbox series

[dpdk-dev] vhost: refine the vhost_new_device

Message ID 1528449484-8664-1-git-send-email-xiangxia.m.yue@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series [dpdk-dev] vhost: refine the vhost_new_device |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Tonghao Zhang June 8, 2018, 9:18 a.m. UTC 
  From: Tonghao Zhang <xiangxia.m.yue@gmail.com>

Make sure find avalid device id before allocating
virtio_net, if not, return directly. It may avoid
allocating and freeing virtio_net when there is
not valid device id.

Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
 lib/librte_vhost/vhost.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Maxime Coquelin June 8, 2018, 2:05 p.m. UTC | #1 
On 06/08/2018 11:18 AM, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> 
> Make sure find avalid device id before allocating
> virtio_net, if not, return directly. It may avoid
> allocating and freeing virtio_net when there is
> not valid device id.
> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
>   lib/librte_vhost/vhost.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Maxime Coquelin June 15, 2018, 8:01 a.m. UTC | #2 
On 06/08/2018 11:18 AM, xiangxia.m.yue@gmail.com wrote:
> From: Tonghao Zhang<xiangxia.m.yue@gmail.com>
> 
> Make sure find avalid device id before allocating
> virtio_net, if not, return directly. It may avoid
> allocating and freeing virtio_net when there is
> not valid device id.
> 
> Signed-off-by: Tonghao Zhang<xiangxia.m.yue@gmail.com>
> ---
>   lib/librte_vhost/vhost.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)

Applied to dpdk-next-virtio/master

Thanks,
Maxime
diff mbox series

Patch

diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index afded49..ed7b7ac 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -268,21 +268,21 @@ 
 	struct virtio_net *dev;
 	int i;
 
-	dev = rte_zmalloc(NULL, sizeof(struct virtio_net), 0);
-	if (dev == NULL) {
-		RTE_LOG(ERR, VHOST_CONFIG,
-			"Failed to allocate memory for new dev.\n");
-		return -1;
-	}
-
 	for (i = 0; i < MAX_VHOST_DEVICE; i++) {
 		if (vhost_devices[i] == NULL)
 			break;
 	}
+
 	if (i == MAX_VHOST_DEVICE) {
 		RTE_LOG(ERR, VHOST_CONFIG,
 			"Failed to find a free slot for new device.\n");
-		rte_free(dev);
+		return -1;
+	}
+
+	dev = rte_zmalloc(NULL, sizeof(struct virtio_net), 0);
+	if (dev == NULL) {
+		RTE_LOG(ERR, VHOST_CONFIG,
+			"Failed to allocate memory for new dev.\n");
 		return -1;
 	}