diff mbox series

[v3,01/16] bus/dpaa: fix phandle support for kernel 4.16

Message ID 1530864613-11754-1-git-send-email-hemant.agrawal@nxp.com (mailing list archive)
State Accepted, archived
Headers
Series [v3,01/16] bus/dpaa: fix phandle support for kernel 4.16 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Hemant Agrawal July 6, 2018, 8:09 a.m. UTC 
  From: Alok Makhariya <alok.makhariya@nxp.com>

Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning")
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: stable@dpdk.org

Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 drivers/bus/dpaa/base/fman/of.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Monjalon July 12, 2018, 12:49 p.m. UTC | #1 
06/07/2018 10:09, Hemant Agrawal:
> From: Alok Makhariya <alok.makhariya@nxp.com>
> 
> Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning")
> Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com>
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Series applied without last patch (because must be reworked).

This series has a lot of cleanups. Starting from now, I will consider
NXP drivers as mature enough. I won't accept anymore such patch without
(or not enough) explanation.
For your users and readers, please start considering to explain
what was wrong and what needs to be changed.
Thanks
diff mbox series

Patch

diff --git a/drivers/bus/dpaa/base/fman/of.c b/drivers/bus/dpaa/base/fman/of.c
index 1b2dbe2..eb55cb9 100644
--- a/drivers/bus/dpaa/base/fman/of.c
+++ b/drivers/bus/dpaa/base/fman/of.c
@@ -182,6 +182,11 @@  linear_dir(struct dt_dir *d)
 				DPAA_BUS_LOG(DEBUG, "Duplicate lphandle in %s",
 					     d->node.node.full_name);
 			d->lphandle = f;
+		} else if (!strcmp(f->node.node.name, "phandle")) {
+			if (d->lphandle)
+				DPAA_BUS_LOG(DEBUG, "Duplicate lphandle in %s",
+					     d->node.node.full_name);
+			d->lphandle = f;
 		} else if (!strcmp(f->node.node.name, "#address-cells")) {
 			if (d->a_cells)
 				DPAA_BUS_LOG(DEBUG, "Duplicate a_cells in %s",