[v3] examples/l3fw-power: do not exit on power lib init failure
Checks
Commit Message
Do not exit the application if power library fails to initialize
or high performance cores configuration cannot be used - this was the
behavior of the application before the patch that added the high/regular
performance option and also this is the normally expected behavior, the
application can be used with no power options, i.e. test framework.
Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
v3: updated commit msg
v2: updated init_power_library to return error code if any core init fails
examples/l3fwd-power/main.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
Comments
On 7/8/2018 2:24 PM, Radu Nicolau wrote:
> Do not exit the application if power library fails to initialize
> or high performance cores configuration cannot be used - this was the
> behavior of the application before the patch that added the high/regular
> performance option and also this is the normally expected behavior, the
> application can be used with no power options, i.e. test framework.
>
> Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf cores options")
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
Acked-by: David Hunt <david.hunt@intel.com>
On 8/7/2018 4:45 PM, Hunt, David wrote:
> On 7/8/2018 2:24 PM, Radu Nicolau wrote:
>> Do not exit the application if power library fails to initialize
>> or high performance cores configuration cannot be used - this was the
>> behavior of the application before the patch that added the high/regular
>> performance option and also this is the normally expected behavior, the
>> application can be used with no power options, i.e. test framework.
>>
>> Fixes: f88e7c175a68 ("examples/l3fwd-power: add high/regular perf
>> cores options")
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
>
> Acked-by: David Hunt <david.hunt@intel.com>
After further internal discussions we will revise the behavior of the
app when exiting due to failed init.
We will try to get a new patch for 18.11.
@@ -1638,11 +1638,13 @@ init_power_library(void)
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
if (rte_lcore_is_enabled(lcore_id)) {
/* init power management library */
- ret = rte_power_init(lcore_id);
- if (ret)
+ int cpi_ret = rte_power_init(lcore_id);
+ if (cpi_ret) {
RTE_LOG(ERR, POWER,
"Library initialization failed on core %u\n",
lcore_id);
+ ret = -1;
+ }
}
}
return ret;
@@ -1683,10 +1685,10 @@ main(int argc, char **argv)
rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
if (init_power_library())
- rte_exit(EXIT_FAILURE, "init_power_library failed\n");
+ RTE_LOG(ERR, POWER, "init_power_library failed\n");
if (update_lcore_params() < 0)
- rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");
+ RTE_LOG(ERR, POWER, "update_lcore_params failed\n");
if (check_lcore_params() < 0)
rte_exit(EXIT_FAILURE, "check_lcore_params failed\n");