doc/fix: add CCM to the QAT feature list

Message ID 1536686639-19057-1-git-send-email-tomaszx.cel@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series doc/fix: add CCM to the QAT feature list |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Cel, TomaszX Sept. 11, 2018, 5:23 p.m. UTC
  Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
 doc/guides/cryptodevs/features/qat.ini | 3 +++
 doc/guides/cryptodevs/qat.rst          | 1 +
 2 files changed, 4 insertions(+)
  

Comments

Kovacevic, Marko Sept. 13, 2018, 1:41 p.m. UTC | #1
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> ---
>  doc/guides/cryptodevs/features/qat.ini | 3 +++
>  doc/guides/cryptodevs/qat.rst          | 1 +
>  2 files changed, 4 insertions(+)


Hi Tomasz,

 I think the patch is ok there is just a few things as this is a fix you need to add a fixes
tag into the commit message here is a reference to the guides for it.
https://doc.dpdk.org/guides/contributing/patches.html?highlight=commit%20message

Excepted output:
-------------------------------------
doc: fix some parameter description

Update the docs, fixing description of some parameter.

Fixes: abcdefgh1234 ("doc: add some parameter")
Cc: author@example.com

Signed-off-by: Alex Smith <alex.smith@example.com>
-----------------------------------------------------------------------

Other thing is try and keep the sizes in order

 +AES CCM (128) = Y   > +AES CCM (128) = Y   
 +AES CCM (256) = Y   > +AES CCM (192) = Y
 +AES CCM (192) = Y   > +AES CCM (256) = Y



Marko K.
  

Patch

diff --git a/doc/guides/cryptodevs/features/qat.ini b/doc/guides/cryptodevs/features/qat.ini
index 29d865e..a37a1a1 100644
--- a/doc/guides/cryptodevs/features/qat.ini
+++ b/doc/guides/cryptodevs/features/qat.ini
@@ -56,3 +56,6 @@  ZUC EIA3     = Y
 AES GCM (128) = Y
 AES GCM (192) = Y
 AES GCM (256) = Y
+AES CCM (128) = Y
+AES CCM (256) = Y
+AES CCM (192) = Y
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index af10799..b09624f 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -66,6 +66,7 @@  Hash algorithms:
 Supported AEAD algorithms:
 
 * ``RTE_CRYPTO_AEAD_AES_GCM``
+* ``RTE_CRYPTO_AEAD_AES_CCM``
 
 
 Limitations