From patchwork Sat Sep 29 05:42:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Mody, Rasesh" X-Patchwork-Id: 45642 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A6221B11A; Sat, 29 Sep 2018 07:42:53 +0200 (CEST) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0045.outbound.protection.outlook.com [104.47.34.45]) by dpdk.org (Postfix) with ESMTP id 432921B104; Sat, 29 Sep 2018 07:42:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EKulMzUJUGfCraF6IlsblwUXhwy7oksrMqZ/8f0E+pU=; b=Y/ibn5jGlogDdeIawLE9Xf1nNuX72O4tswdtLL7AfFNZcIX0BiDM1QchJuk5OS/kaReyedrOECJmW4ebW2pa1zI33ZC4hORa4SDO3CyMpb/9AknD8jngvyFIbhPsXwgntCy6ODOULrt3AKzY8mrzdzyJbJ9MGXfFUnh6SyvyZ5w= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB5717.namprd07.prod.outlook.com (20.178.0.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1164.25; Sat, 29 Sep 2018 05:42:40 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.022; Sat, 29 Sep 2018 05:42:40 +0000 From: "Mody, Rasesh" To: "dev@dpdk.org" CC: "Mody, Rasesh" , "ferruh.yigit@intel.com" , Dept-Eng DPDK Dev , "stable@dpdk.org" Thread-Topic: [PATCH v2 4/5] net/bnx2x: fix call to link handling periodic function Thread-Index: AQHUV7c8VvoKqyBVA0m7mxi31aC6LA== Date: Sat, 29 Sep 2018 05:42:40 +0000 Message-ID: <1538199734-23357-4-git-send-email-rasesh.mody@cavium.com> References: <1537394318-17682-1-git-send-email-rasesh.mody@cavium.com> In-Reply-To: <1537394318-17682-1-git-send-email-rasesh.mody@cavium.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CO1PR15CA0075.namprd15.prod.outlook.com (2603:10b6:101:20::19) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [198.186.1.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5717; 6:9s4Zuo7gRcYzTxWsQca6ReOS9PLveWgFxLeaHqjChjrAaGCpq5b/TQlHLavVhVJC/ipIt+z5Gi0uyXWWS7ezZ4O9p4FLAlFoeF5KyY10saCUStov7zli6Z4Uk4VyY5EuOCTSyGA1WMcJ4fF6knTrgxIJuG30SXZd9ggZXAPrVAZHw7vdp5v5QfXs+0jtzLS2CuLFb0LxB+O3jI+/SPGXmnhXyVijKtPUzGSBosEN42oDOF0Inh+z6RXhrTxujdgb3kgZDoWGUVV4MzL2uo9fJ6ZALef/umcE9ILN2QVEIc2VXSoX4b6uq1SZOtzA+3fkZH35KLlyAIDCJ9aMYJoQ0iDMuqa7GU1pSAgL2TMEZ+MsK1ASjd58qqrr4aCFUxegQEItSaW/v2oH4QtE6hYTVnf6S07cBn29TA+zxyhZFMkyT+qzebbT75gTpqH3a7y141SAw4Y/U7cOEJOEcynCZw==; 5:9aFTfuEa8gbnuO5r/aa1gIcS+3bJ+q0KEQ79kCVQm0N2D8WWZYNI7aoqo02S07e60r3V2butJBQaI68Hy0S3KASvR2AkYu8ciRo+bsb1KigKJmwWIBrLLGctt7gOXHNGYVKO/CaCmftcd6+sL1Ajla6ohKNQePl7TLgVOuez9R0=; 7:f1IjfnnhXlUQPgTdGGFS25SdNml7mYWnfUQAJH5RbmjnbJi0X+jMO2I5jDceX9CULh5if2uF7znGnJUldl58arWwzy7UMcZ45bcfrJ82zDh/6M71Xy/Fj4GnVwi5/FzsNkzJ/zEfnw8a9E+0N9Y2dFKnoFTBoVJqZbdsxuKMiBHURO9mdWbuJrJaHY6cY628+fKPU45bsIsVCYIQD+/x2IIqek17q0oi1RwECbX1LDy+ktPCw3BfmXezNTfQt6Dp x-ms-office365-filtering-correlation-id: 0dfbc8e4-4fd6-4a68-da45-08d625ce5eb2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5717; x-ms-traffictypediagnostic: BYAPR07MB5717: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(10201501046)(93006095)(93001095)(3231355)(944501410)(52105095)(3002001)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BYAPR07MB5717; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5717; x-forefront-prvs: 0810818DA0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(1496009)(136003)(39860400002)(346002)(396003)(366004)(376002)(199004)(189003)(186003)(81156014)(81166006)(11346002)(6512007)(71190400001)(6486002)(8676002)(7736002)(53936002)(305945005)(446003)(6916009)(71200400001)(5660300001)(486006)(1730700003)(34290500001)(8936002)(2616005)(6436002)(76176011)(476003)(5640700003)(99286004)(105586002)(2351001)(52116002)(106356001)(54906003)(26005)(256004)(68736007)(36756003)(2906002)(2501003)(102836004)(4326008)(316002)(86362001)(2900100001)(14454004)(97736004)(3846002)(6116002)(6506007)(72206003)(5250100002)(386003)(25786009)(478600001)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5717; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /rLZ+iGQkT8CE6vhFP6TpKezYLWSKr9+8F3yoA4mRgWMWqftCHHoT6TeMRlWOhEhzTg+V0eEtY+RExTTeU5HmQYvGukXYyrVm/CyvjJY7hI5XifJrTnEedICR6u9aBZHUuNJLPmHl3LNxWsMLv70SrBlAQ5QDfNPcb0++daUiQD+nigndLH7Up+IU7Xna9lPJsTi2/mx8w6wpFnmInpz45qBvrtkJt4MdfqWdJ6E0fKCD1v2Tn4ugXA84ZrFFwWE0sKmRnTcH24DbWmjrlMhtxhYCV30sV2sRsNmZ2FfaYIjMMLCzbsTXVmdYjqUNgRg4c0g4/5k9wD/E2AbR4nhosv2Ppk95rd25LoqReU3KNc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dfbc8e4-4fd6-4a68-da45-08d625ce5eb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2018 05:42:40.5806 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5717 Subject: [dpdk-dev] [PATCH v2 4/5] net/bnx2x: fix call to link handling periodic function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 ("bnx2x: driver core") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index ae2e60a..0057843 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -131,7 +131,9 @@ struct rte_bnx2x_xstats_name_off { PMD_DEBUG_PERIODIC_LOG(INFO, sc, "Interrupt handled"); + atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP); bnx2x_interrupt_action(dev); + atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO); rte_intr_enable(&sc->pci_dev->intr_handle); }