[v1,06/11] config: add build enablement for IPN3KE
Checks
Commit Message
Add build enablement for Intel FPGA Acceleration
NIC IPN3KE.
Signed-off-by: Rosen Xu <rosen.xu@intel.com>
---
config/common_base | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On 2/28/2019 7:13 AM, Rosen Xu wrote:
> Add build enablement for Intel FPGA Acceleration
> NIC IPN3KE.
No need to make this a separate patch, can squash into previous one.
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
> config/common_base | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/config/common_base b/config/common_base
> index 7c6da51..4fac8ba 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -316,6 +316,12 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
> CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
>
> #
> +# Compile burst-oriented IPN3KE PMD driver
> +#
> +CONFIG_RTE_LIBRTE_IPN3KE_PMD=n
Why PMD is disabled by default?
> +CONFIG_RTE_LIBRTE_IPN3KE_DEBUG=n
_DEBUG seems not used at all, if so can you please remove it?
> +
> +#
> # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD
> #
> CONFIG_RTE_LIBRTE_MLX4_PMD=n
>
> -----Original Message-----
> From: Yigit, Ferruh [mailto:ferruh.yigit@linux.intel.com]
> Sent: Wednesday, March 06, 2019 20:45
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy
> <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 06/11] config: add build enablement for
> IPN3KE
>
> On 2/28/2019 7:13 AM, Rosen Xu wrote:
> > Add build enablement for Intel FPGA Acceleration NIC IPN3KE.
>
> No need to make this a separate patch, can squash into previous one.
I will merge it in patch v2.
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> > config/common_base | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > 7c6da51..4fac8ba 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -316,6 +316,12 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
> > CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
> >
> > #
> > +# Compile burst-oriented IPN3KE PMD driver #
> > +CONFIG_RTE_LIBRTE_IPN3KE_PMD=n
>
> Why PMD is disabled by default?
I will change it to y in patch v2.
> > +CONFIG_RTE_LIBRTE_IPN3KE_DEBUG=n
>
> _DEBUG seems not used at all, if so can you please remove it?
>
> > +
> > +#
> > # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD #
> > CONFIG_RTE_LIBRTE_MLX4_PMD=n
> >
Hi Ferruh,
It seems I have missed some comments, so just reply this again.
> -----Original Message-----
> From: Yigit, Ferruh [mailto:ferruh.yigit@linux.intel.com]
> Sent: Wednesday, March 06, 2019 20:45
> To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Wei, Dan <dan.wei@intel.com>; Pei, Andy
> <andy.pei@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Chen, Santos <santos.chen@intel.com>;
> Zhang, Zhang <zhang.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 06/11] config: add build enablement for
> IPN3KE
>
> On 2/28/2019 7:13 AM, Rosen Xu wrote:
> > Add build enablement for Intel FPGA Acceleration NIC IPN3KE.
>
> No need to make this a separate patch, can squash into previous one.
I will merge it in patch v2.
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> > config/common_base | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > 7c6da51..4fac8ba 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -316,6 +316,12 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
> > CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
> >
> > #
> > +# Compile burst-oriented IPN3KE PMD driver #
> > +CONFIG_RTE_LIBRTE_IPN3KE_PMD=n
>
> Why PMD is disabled by default?
It should not be disabled by default.
I will change it to y in patch v2.
> > +CONFIG_RTE_LIBRTE_IPN3KE_DEBUG=n
>
> _DEBUG seems not used at all, if so can you please remove it?
Currently it's not used, I will remove it in patch v2.
> > +
> > +#
> > # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD #
> > CONFIG_RTE_LIBRTE_MLX4_PMD=n
> >
@@ -316,6 +316,12 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
#
+# Compile burst-oriented IPN3KE PMD driver
+#
+CONFIG_RTE_LIBRTE_IPN3KE_PMD=n
+CONFIG_RTE_LIBRTE_IPN3KE_DEBUG=n
+
+#
# Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD
#
CONFIG_RTE_LIBRTE_MLX4_PMD=n