diff mbox series

net/iavf: move debug dump desc flag to config file

Message ID 1560172058-10742-1-git-send-email-lavanyax.govindarajan@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/iavf: move debug dump desc flag to config file |

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Lavanya Govindarajan June 10, 2019, 1:07 p.m. UTC 
  DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable
it user needs to edit the Makefile. It is felt that this method is not
good. Hence removing this flag from IAVF makefile and adding a flag
CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base.

Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
---
 config/common_base           | 1 +
 drivers/net/iavf/Makefile    | 3 ---
 drivers/net/iavf/iavf_rxtx.h | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

Comments

Qi Zhang June 18, 2019, 2:22 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lavanya
> Govindarajan
> Sent: Monday, June 10, 2019 9:08 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> Govindarajan, LavanyaX <lavanyax.govindarajan@intel.com>
> Subject: [dpdk-dev] [PATCH] net/iavf: move debug dump desc flag to config
> file
> 
> DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable it
> user needs to edit the Makefile. It is felt that this method is not good. Hence
> removing this flag from IAVF makefile and adding a flag
> CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base.
> 
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/config/common_base b/config/common_base
index 6b96e0e80..86cd27bb2 100644
--- a/config/common_base
+++ b/config/common_base
@@ -327,6 +327,7 @@  CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR=y
 CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX=n
 CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX_FREE=n
 CONFIG_RTE_LIBRTE_IAVF_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC=n
 CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=n
 #
 # Compile burst-oriented IPN3KE PMD driver
diff --git a/drivers/net/iavf/Makefile b/drivers/net/iavf/Makefile
index 3a0eb79ca..cd74e14ab 100644
--- a/drivers/net/iavf/Makefile
+++ b/drivers/net/iavf/Makefile
@@ -13,9 +13,6 @@  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
 LDLIBS += -lrte_bus_pci
 
-# used to dump HW descriptor for debugging
-# CFLAGS += -DDEBUG_DUMP_DESC
-
 EXPORT_MAP := rte_pmd_iavf_version.map
 
 LIBABIVER := 1
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index e821dcae6..c86720bda 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -255,7 +255,7 @@  void iavf_dump_tx_descriptor(const struct iavf_tx_queue *txq,
 	       tx_desc->cmd_type_offset_bsz);
 }
 
-#ifdef DEBUG_DUMP_DESC
+#ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC
 #define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \
 	iavf_dump_rx_descriptor(rxq, desc, rx_id)
 #define IAVF_DUMP_TX_DESC(txq, desc, tx_id) \