From patchwork Fri Jun 21 09:40:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 55164 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8C611D59E; Fri, 21 Jun 2019 11:41:03 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 2421D1D59C; Fri, 21 Jun 2019 11:41:02 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3106040059; Fri, 21 Jun 2019 09:41:01 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 21 Jun 2019 02:40:58 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Fri, 21 Jun 2019 02:40:57 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x5L9euND017266; Fri, 21 Jun 2019 10:40:56 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id B3FE81627D8; Fri, 21 Jun 2019 10:40:56 +0100 (BST) From: Andrew Rybchenko To: CC: Date: Fri, 21 Jun 2019 10:40:40 +0100 Message-ID: <1561110041-1795-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1561110041-1795-1-git-send-email-arybchenko@solarflare.com> References: <1561110041-1795-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24700.003 X-TM-AS-Result: No-2.295500-4.000000-10 X-TMASE-MatchedRID: pye3kvC3BNkn4llhB/GgfBouoVvF2i0Z6VTG9cZxEjKRoQLwUmtov+1v AbHwESsv0yhouuw21M8Wsp6eJb7A2yxppiUy9o4cA9lly13c/gGVKmGUZ/WnkWhLNmF22y36o8W MkQWv6iUoTQl7wNH8Pg1fA1QHegDv3QfwsVk0UbsIoUKaF27lxZufS/Oz+ixumAUwlb23XurX29 on0eXnhvb4qunKhBVzUq95rI2tXVwA95y+G4Ma8Pn74AaXdtiNATFxy0Lbdcm5k+hU/wlYOQ9cv Ed/Et5dVEc5IqztENReYfSkFq6uAb7jE6+wkCSenqg/VrSZEiM= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.295500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24700.003 X-MDID: 1561110061-ggcLYFPWkU25 Subject: [dpdk-dev] [PATCH 2/3] net/sfc: ensure that device is closed on removal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI device may be unplugged when ethdev is not closed yet. Fixes: aaa3f5f0f79d ("net/sfc: add configure and close stubs") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- drivers/net/sfc/sfc_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index be185d5e9..583f31b8c 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -2196,6 +2196,8 @@ sfc_eth_dev_uninit(struct rte_eth_dev *dev) return 0; } + sfc_dev_close(dev); + sa = sfc_adapter_by_eth_dev(dev); sfc_log_init(sa, "entry");