From patchwork Thu Jul 4 10:03:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 56077 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A47C71BDE4; Thu, 4 Jul 2019 12:04:07 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9F17D1BDF3; Thu, 4 Jul 2019 12:04:05 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id BBAB99C0066; Thu, 4 Jul 2019 10:04:04 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 4 Jul 2019 03:04:02 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 4 Jul 2019 03:04:01 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x64A40cX021421; Thu, 4 Jul 2019 11:04:00 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 959411613C2; Thu, 4 Jul 2019 11:04:00 +0100 (BST) From: Andrew Rybchenko To: Jerin Jacob , Liang Ma , "Peter Mccarthy" CC: , Dilshod Urazov , Date: Thu, 4 Jul 2019 11:03:32 +0100 Message-ID: <1562234612-631-4-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> References: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24738.005 X-TM-AS-Result: No-7.383800-4.000000-10 X-TMASE-MatchedRID: p9rK+f8v5s+mnG2tP+vqUW6HurDH4PpP9teeW6UfkyB0+P0tQGP+S51b YL8THayD6eCSFghTVfiaYG6s7Uku2+O3C1C2ZcTlnFVnNmvv47tLXPA26IG0hN9RlPzeVuQQXmr nY1Xus+2HUUm9FGrCb3FypV9HM4SoCyoWuBSi9xXHmyDJSEsI2805KBm2/UMhmyiLZetSf8mfop 0ytGwvXiq2rl3dzGQ1HyQ+JiGcJ0z/ITeMF4QpX3OrmhMVxztXYGX7BITnTWCeD+VpjsfJ6Q== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.383800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24738.005 X-MDID: 1562234645-IqDWJVzBYrnF Subject: [dpdk-dev] [PATCH 3/3] event/opdl: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dilshod Urazov Fixes: 0bf298e39286 ("event/opdl: add event port config get/set") Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") Cc: stable@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko Reviewed-by: David Marchand --- drivers/event/opdl/opdl_evdev.c | 10 +++++----- drivers/event/opdl/opdl_evdev_init.c | 12 ++++++------ drivers/event/opdl/opdl_ring.c | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c index d2d2be4..3beca89 100644 --- a/drivers/event/opdl/opdl_evdev.c +++ b/drivers/event/opdl/opdl_evdev.c @@ -102,7 +102,7 @@ dev->data->dev_id, queues[0], p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -113,7 +113,7 @@ dev->data->dev_id, num, p->id); - rte_errno = -EDQUOT; + rte_errno = EDQUOT; return 0; } @@ -123,7 +123,7 @@ dev->data->dev_id, p->id, queues[0]); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -134,7 +134,7 @@ p->id, p->external_qid, queues[0]); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } @@ -160,7 +160,7 @@ dev->data->dev_id, queues[0], p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } RTE_SET_USED(nb_unlinks); diff --git a/drivers/event/opdl/opdl_evdev_init.c b/drivers/event/opdl/opdl_evdev_init.c index 582ad69..15aae47 100644 --- a/drivers/event/opdl/opdl_evdev_init.c +++ b/drivers/event/opdl/opdl_evdev_init.c @@ -35,7 +35,7 @@ p->id, ev[i].queue_id, p->next_external_qid); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } } @@ -63,7 +63,7 @@ } else { if (num > 0 && ev[0].queue_id != p->next_external_qid) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } } @@ -116,7 +116,7 @@ RTE_SET_USED(ev); RTE_SET_USED(num); - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return 0; } @@ -145,7 +145,7 @@ if (enqueued < num) - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return enqueued; } @@ -164,7 +164,7 @@ RTE_SET_USED(ev); RTE_SET_USED(num); - rte_errno = -ENOSPC; + rte_errno = ENOSPC; return 0; } @@ -240,7 +240,7 @@ "Attempt to dequeue num of events larger than port (%d) max", opdl_pmd_dev_id(p->opdl), p->id); - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } diff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c index e988f1c..e8b29e2 100644 --- a/drivers/event/opdl/opdl_ring.c +++ b/drivers/event/opdl/opdl_ring.c @@ -756,7 +756,7 @@ struct opdl_ring { opdl_stage_disclaim(struct opdl_stage *s, uint32_t num_entries, bool block) { if (num_entries != s->num_event) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return 0; } if (s->threadsafe == false) {