net/mlx5: add ConnectX6-DX device id

Message ID 1573116011-1610-1-git-send-email-rasland@mellanox.com (mailing list archive)
State Superseded, archived
Headers
Series net/mlx5: add ConnectX6-DX device id |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Raslan Darawsheh Nov. 7, 2019, 8:40 a.m. UTC
  This adds new device id to the list of Mellanox devices
that runs mlx5 PMD.
	- ConnectX-6DX device ID
	- ConnectX-6DX SRIOV device ID

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 doc/guides/rel_notes/release_19_11.rst | 1 +
 drivers/net/mlx5/mlx5.h                | 2 ++
 2 files changed, 3 insertions(+)
  

Comments

Wisam Jaddo Nov. 7, 2019, 9:15 a.m. UTC | #1
Hey Raslan,

You are missing PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF in mlx5.c/mlx5_pci_probe()
Otherwise the PCI for CX6DXVF will not be recognized correctly

BRs,
Wisam Jaddo

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Raslan Darawsheh
Sent: Thursday, November 7, 2019 10:40 AM
To: Slava Ovsiienko
Cc: dev@dpdk.org; Asaf Penso
Subject: [dpdk-dev] [PATCH] net/mlx5: add ConnectX6-DX device id

This adds new device id to the list of Mellanox devices that runs mlx5 PMD.
	- ConnectX-6DX device ID
	- ConnectX-6DX SRIOV device ID

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 doc/guides/rel_notes/release_19_11.rst | 1 +
 drivers/net/mlx5/mlx5.h                | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
index 23182d1..2920fa2 100644
--- a/doc/guides/rel_notes/release_19_11.rst
+++ b/doc/guides/rel_notes/release_19_11.rst
@@ -169,6 +169,7 @@ New Features
   * Added support for VLAN set VID offload command.
   * Added support for matching on packets withe Geneve tunnel header.
   * Added hairpin support.
+  * Added ConnectX6-DX support.
 
 * **Updated the AF_XDP PMD.**
 
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index f644998..b56dae1 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -55,6 +55,8 @@ enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF = 0xa2d3,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6VF = 0x101c,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX = 0x101d,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 };
 
 /* Request types for IPC. */
--
2.7.4
  
Raslan Darawsheh Nov. 7, 2019, 9:25 a.m. UTC | #2
Thanks for noticing this, 
I forgot to add these in the commit, just sent a v2 with these included.

Kindest regards,
Raslan Darawsheh

> -----Original Message-----
> From: Wisam Monther <wisamm@mellanox.com>
> Sent: Thursday, November 7, 2019 11:15 AM
> To: Raslan Darawsheh <rasland@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org; Asaf Penso <asafp@mellanox.com>
> Subject: RE: [PATCH] net/mlx5: add ConnectX6-DX device id
> 
> Hey Raslan,
> 
> You are missing PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF in
> mlx5.c/mlx5_pci_probe()
> Otherwise the PCI for CX6DXVF will not be recognized correctly
> 
> BRs,
> Wisam Jaddo
> 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Raslan Darawsheh
> Sent: Thursday, November 7, 2019 10:40 AM
> To: Slava Ovsiienko
> Cc: dev@dpdk.org; Asaf Penso
> Subject: [dpdk-dev] [PATCH] net/mlx5: add ConnectX6-DX device id
> 
> This adds new device id to the list of Mellanox devices that runs mlx5 PMD.
> 	- ConnectX-6DX device ID
> 	- ConnectX-6DX SRIOV device ID
> 
> Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
>  doc/guides/rel_notes/release_19_11.rst | 1 +
>  drivers/net/mlx5/mlx5.h                | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_11.rst
> b/doc/guides/rel_notes/release_19_11.rst
> index 23182d1..2920fa2 100644
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -169,6 +169,7 @@ New Features
>    * Added support for VLAN set VID offload command.
>    * Added support for matching on packets withe Geneve tunnel header.
>    * Added hairpin support.
> +  * Added ConnectX6-DX support.
> 
>  * **Updated the AF_XDP PMD.**
> 
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> f644998..b56dae1 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -55,6 +55,8 @@ enum {
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF = 0xa2d3,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
>  	PCI_DEVICE_ID_MELLANOX_CONNECTX6VF = 0x101c,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX = 0x101d,
> +	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
>  };
> 
>  /* Request types for IPC. */
> --
> 2.7.4
  

Patch

diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
index 23182d1..2920fa2 100644
--- a/doc/guides/rel_notes/release_19_11.rst
+++ b/doc/guides/rel_notes/release_19_11.rst
@@ -169,6 +169,7 @@  New Features
   * Added support for VLAN set VID offload command.
   * Added support for matching on packets withe Geneve tunnel header.
   * Added hairpin support.
+  * Added ConnectX6-DX support.
 
 * **Updated the AF_XDP PMD.**
 
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index f644998..b56dae1 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -55,6 +55,8 @@  enum {
 	PCI_DEVICE_ID_MELLANOX_CONNECTX5BFVF = 0xa2d3,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6 = 0x101b,
 	PCI_DEVICE_ID_MELLANOX_CONNECTX6VF = 0x101c,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX6DX = 0x101d,
+	PCI_DEVICE_ID_MELLANOX_CONNECTX6DXVF = 0x101e,
 };
 
 /* Request types for IPC. */