From patchwork Thu Nov 14 16:40:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 63024 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48A33A04C5; Thu, 14 Nov 2019 17:41:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 801A72BBD; Thu, 14 Nov 2019 17:41:17 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id 8AB74374 for ; Thu, 14 Nov 2019 17:41:16 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id EE62A80008C; Thu, 14 Nov 2019 16:41:14 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 14 Nov 2019 08:41:12 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 14 Nov 2019 08:41:11 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id xAEGfAa4009575; Thu, 14 Nov 2019 16:41:10 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 5A51F1613C7; Thu, 14 Nov 2019 16:41:10 +0000 (GMT) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit CC: Date: Thu, 14 Nov 2019 16:40:51 +0000 Message-ID: <1573749654-30038-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com> References: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25042.005 X-TM-AS-Result: No-5.595800-4.000000-10 X-TMASE-MatchedRID: TQgQQfTgKyB8PxM8I4v8UWY+xOrx57jWab+ZPXqZNQIAjiw/nJICh0u9 e4S/+fL24RE0M7p0eo6lGIQvr65zt9ySVj0wBolScaD+wPaBYtYisyg/lfGoZ2z3xnx8b/qRgHx 1gp1CimprfJNHzOv42teR0j3/CuSfLGmmJTL2jhwD2WXLXdz+AX4kYxhimH/bpIgauMPGzMWjxY yRBa/qJSRXrdXDPmzYtVC7UY1n6yKyO81X3yak88ZwT1VqdfLt2QTR10karUpSxJ1VsH7SKIEL4 I7LYZ9OWbpD5p7FHdJ+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.595800-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25042.005 X-MDID: 1573749675-3KbsZFTq04GB Subject: [dpdk-dev] [PATCH 2/3] ethdev: decrease verbosity of not disabled offload logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Right now a PMD decides if it is critical that an offload cannot be disabled (i.e. not requested, but still enabled). If PMD treaks it as OK, we should not spam logs with corresponding messsages by default. Default log level in ethdev is INFO, so change the message level to DEBUG. Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit Acked-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index c43f9f5d14..19ca08b04a 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -1204,7 +1204,7 @@ validate_offloads(uint16_t port_id, uint64_t req_offloads, /* Chech if offload couldn't be disabled. */ if (offload & set_offloads) { - RTE_ETHDEV_LOG(INFO, + RTE_ETHDEV_LOG(DEBUG, "Port %u failed to disable %s offload %s\n", port_id, offload_type, offload_name(offload)); }