[v3,0/5] net/mlx: assert cleanup in mlx drivers
Message ID | 1580136153-84940-1-git-send-email-akozyrev@mellanox.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55553A0531; Mon, 27 Jan 2020 15:42:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 046FF1BFEE; Mon, 27 Jan 2020 15:42:39 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id F3D8E1BFE7 for <dev@dpdk.org>; Mon, 27 Jan 2020 15:42:36 +0100 (CET) Received: from Internal Mail-Server by MTLPINE2 (envelope-from akozyrev@mellanox.com) with ESMTPS (AES256-SHA encrypted); 27 Jan 2020 16:42:36 +0200 Received: from pegasus02.mtr.labs.mlnx. (pegasus02.mtr.labs.mlnx [10.210.16.122]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 00REgZ7n008031; Mon, 27 Jan 2020 16:42:35 +0200 From: Alexander Kozyrev <akozyrev@mellanox.com> To: dev@dpdk.org Cc: rasland@mellanox.com, matan@mellanox.com, viacheslavo@mellanox.com, ferruh.yigit@intel.com, thomas@monjalon.net Date: Mon, 27 Jan 2020 16:42:28 +0200 Message-Id: <1580136153-84940-1-git-send-email-akozyrev@mellanox.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1579789555-23239-1-git-send-email-akozyrev@mellanox.com> References: <1579789555-23239-1-git-send-email-akozyrev@mellanox.com> Subject: [dpdk-dev] [PATCH v3 0/5] net/mlx: assert cleanup in mlx drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Message
Alexander Kozyrev
Jan. 27, 2020, 2:42 p.m. UTC
The Mellanox PMD uses the NDEBUG definition to control built-in debug
features including the asserting one. The DPDK uses a bit different
approach and provides RTE_ASSERT macro and appropriate global
configuration option: CONFIG_RTE_ENABLE_ASSERT.
The patch set introduces the MLX_ASSERT macros that allows to follow
the DPDK approach in a unified fashion and, at the same time,
provides the opportunity to turn on Mellanox PMD assert feature with
dedicated local configuration options: CONFIG_RTE_LIBRTE_MLX_DEBUG.
Note that the direct configuration MLX_DEBUG is clearer than
double negation "ifndef NDEBUG" used before.
This patch set triggers another false positive warning with ICC.
To spare future development efforts we disable the treatments of
compilation warnings as errors in ICC config. GCC stays as a guard.
Signed-off-by: Alexander Kozyrev <akozyrev@mellanox.com>
---
v1: http://patches.dpdk.org/cover/65082/
v2: http://patches.dpdk.org/cover/65089/
- Corrects typos and make commit messages more accurate.
- Fixes broken compilation due to an undefined function in debug mode.
v3:
- Uses RTE_LIBRTE_MLX_DEBUG directly instead of MLX_DEBUG
Alexander Kozyrev (5):
mk/icc: disable treatment of warnings as errors
net/mlx4: use mlx4 debug flag instead of NDEBUG
net/mlx4: introduce the mlx4 version of the assert
net/mlx5: use mlx5 debug flag instead of NDEBUG
net/mlx5: introduce the mlx5 version of the assert
drivers/net/mlx4/Makefile | 4 +-
drivers/net/mlx4/meson.build | 4 +-
drivers/net/mlx4/mlx4.c | 29 ++--
drivers/net/mlx4/mlx4_ethdev.c | 5 +-
drivers/net/mlx4/mlx4_flow.c | 34 ++--
drivers/net/mlx4/mlx4_intr.c | 3 +-
drivers/net/mlx4/mlx4_mp.c | 25 ++-
drivers/net/mlx4/mlx4_mr.c | 74 ++++----
drivers/net/mlx4/mlx4_rxq.c | 53 +++---
drivers/net/mlx4/mlx4_rxtx.c | 29 ++--
drivers/net/mlx4/mlx4_txq.c | 17 +-
drivers/net/mlx4/mlx4_utils.c | 3 +-
drivers/net/mlx4/mlx4_utils.h | 15 +-
drivers/net/mlx5/Makefile | 4 +-
drivers/net/mlx5/meson.build | 4 +-
drivers/net/mlx5/mlx5.c | 83 +++++----
drivers/net/mlx5/mlx5_devx_cmds.c | 4 +-
drivers/net/mlx5/mlx5_ethdev.c | 69 ++++----
drivers/net/mlx5/mlx5_flow.c | 69 ++++----
drivers/net/mlx5/mlx5_flow_dv.c | 97 ++++++-----
drivers/net/mlx5/mlx5_flow_meter.c | 12 +-
drivers/net/mlx5/mlx5_flow_verbs.c | 4 +-
drivers/net/mlx5/mlx5_mac.c | 5 +-
drivers/net/mlx5/mlx5_mp.c | 29 ++--
drivers/net/mlx5/mlx5_mr.c | 71 ++++----
drivers/net/mlx5/mlx5_nl.c | 26 +--
drivers/net/mlx5/mlx5_prm.h | 3 +-
drivers/net/mlx5/mlx5_rss.c | 3 +-
drivers/net/mlx5/mlx5_rxq.c | 41 +++--
drivers/net/mlx5/mlx5_rxtx.c | 289 ++++++++++++++++---------------
drivers/net/mlx5/mlx5_rxtx.h | 6 +-
drivers/net/mlx5/mlx5_rxtx_vec.c | 1 -
drivers/net/mlx5/mlx5_rxtx_vec.h | 7 +-
drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 11 +-
drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 11 +-
drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 11 +-
drivers/net/mlx5/mlx5_socket.c | 4 +-
drivers/net/mlx5/mlx5_stats.c | 2 +-
drivers/net/mlx5/mlx5_txq.c | 59 ++++---
drivers/net/mlx5/mlx5_utils.c | 8 +-
drivers/net/mlx5/mlx5_utils.h | 36 ++--
drivers/net/mlx5/mlx5_vlan.c | 7 +-
mk/toolchain/icc/rte.vars.mk | 4 -
43 files changed, 632 insertions(+), 643 deletions(-)