From patchwork Mon Mar 15 19:34:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 89159 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 845FDA054F; Mon, 15 Mar 2021 20:34:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43D152427A8; Mon, 15 Mar 2021 20:34:49 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 392D14069F for ; Mon, 15 Mar 2021 20:34:48 +0100 (CET) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 7736320B26E1; Mon, 15 Mar 2021 12:34:47 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7736320B26E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1615836887; bh=05bZMImLp5cU5PM7VkY+ZLKIYjYEH440Eo9KV5dliJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ub8v6E+9oV5lth7pWk08qhl87eD/YAzSLOs+VhV9LsJH+PjoKhe6bFyOgwJ/TUD/K 47fewsX3LNaVkPpzGrOQVFneO+J+HKxeCM9X15ZNeRtj3AGJ/JfS4WKgdKy1ph+kUA Fq9wNGCg/l5YvVXbI5/hEKdCRtCKeJfu1leKceuQ= From: Tyler Retzlaff To: dev@dpdk.org Cc: anatoly.burakov@intel.com, ranjit.menon@intel.com, mb@smartsharesystems.com, mdr@ashroe.eu, nhorman@tuxdriver.com, stephen@networkplumber.org Date: Mon, 15 Mar 2021 12:34:38 -0700 Message-Id: <1615836878-23213-1-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> References: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> Subject: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The proposal has resulted from request to review [1] the following functions where there appeared to be inconsistency in return type or parameter type selections for the following inline functions. rte_bsf32() rte_bsf32_safe() rte_bsf64() rte_bsf64_safe() rte_fls_u32() rte_fls_u64() rte_log2_u32() rte_log2_u64() [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html Signed-off-by: Tyler Retzlaff Acked-by: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 64629e064..4934f4da4 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -17,6 +17,13 @@ Deprecation Notices * eal: The function ``rte_eal_remote_launch`` will return new error codes after read or write error on the pipe, instead of calling ``rte_panic``. +* eal: Fix inline function return and parameter types for rte_{bsf,fls} + inline functions to be consistent. + Change ``rte_bsf32_safe`` parameter ``v`` from ``uint64_t`` to ``uint32_t``. + Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``. + Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``. + Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``. + * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does not allow for writing optimized code for all the CPU architectures supported in DPDK. DPDK will adopt C11 atomic operations semantics and provide wrappers