diff mbox series

[v9,01/10] lib: build libraries that testpmd depends on

Message ID	1619805162-10684-2-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	From: Jie Zhou <jizh@linux.microsoft.com> To: dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com Date: Fri, 30 Apr 2021 10:52:33 -0700 Message-Id: <1619805162-10684-2-git-send-email-jizh@linux.microsoft.com> In-Reply-To: <1619805162-10684-1-git-send-email-jizh@linux.microsoft.com> References: <1619553721-5220-1-git-send-email-jizh@linux.microsoft.com> <1619805162-10684-1-git-send-email-jizh@linux.microsoft.com> Subject: [dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	app/testpmd: enable testpmd on Windows \| [v9,00/10] app/testpmd: enable testpmd on Windows [v9,01/10] lib: build libraries that testpmd depends on [v9,02/10] eal/windows: add necessary macros [v9,03/10] eal/windows: add device event stubs [v9,04/10] eal/Windows: add clock_gettime on Windows [v9,05/10] app/testpmd: resolve name collisions [v9,06/10] app/testpmd: fix parse_fec_mode return type [v9,07/10] app/testpmd: replace POSIX specific code [v9,08/10] app/testpmd: fix headers inclusion [v9,09/10] app/testpmd: fix unused function warnings [v9,10/10] app/testpmd: enable building testpmd on Windows

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jie Zhou April 30, 2021, 5:52 p.m. UTC

  Enable building libraries that testpmd depends on

Signed-off-by: Jie Zhou <jizh@microsoft.com>
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 lib/meson.build | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Tal Shnaiderman May 3, 2021, 5:36 p.m. UTC | #1

> Subject: [PATCH v9 01/10] lib: build libraries that testpmd depends on
> 
> External email: Use caution opening links or attachments
> 
> 
> Enable building libraries that testpmd depends on
> 

You should mention the change is for Windows only.

> Signed-off-by: Jie Zhou <jizh@microsoft.com>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---
>  lib/meson.build | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238
> 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -76,8 +76,15 @@ if is_windows
>              'ethdev',
>              'pci',
>              'cmdline',
> +            'metrics',
>              'hash',
> +            'timer',
> +            'bitratestats',
>              'cfgfile',
> +            'gro',
> +            'gso',
> +            'latencystats',
> +            'pdump',
>      ] # only supported libraries for windows  endif
> 
> --
> 2.30.0.vfs.0.2

Jie Zhou May 3, 2021, 9:38 p.m. UTC | #2

On Mon, May 03, 2021 at 05:36:30PM +0000, Tal Shnaiderman wrote:
> > Subject: [PATCH v9 01/10] lib: build libraries that testpmd depends on
> > 
> > External email: Use caution opening links or attachments
> > 
> > 
> > Enable building libraries that testpmd depends on
> > 
> 
> You should mention the change is for Windows only.

Will explicitly mention the change is for Windows only in V10.

> 
> > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> >  lib/meson.build | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238
> > 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -76,8 +76,15 @@ if is_windows
> >              'ethdev',
> >              'pci',
> >              'cmdline',
> > +            'metrics',
> >              'hash',
> > +            'timer',
> > +            'bitratestats',
> >              'cfgfile',
> > +            'gro',
> > +            'gso',
> > +            'latencystats',
> > +            'pdump',
> >      ] # only supported libraries for windows  endif
> > 
> > --
> > 2.30.0.vfs.0.2

diff mbox series

Patch

diff --git a/lib/meson.build b/lib/meson.build
index c9a20f65b..2d499b238 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -76,8 +76,15 @@  if is_windows
             'ethdev',
             'pci',
             'cmdline',
+            'metrics',
             'hash',
+            'timer',
+            'bitratestats',
             'cfgfile',
+            'gro',
+            'gso',
+            'latencystats',
+            'pdump',
     ] # only supported libraries for windows
 endif