diff mbox series

[v1,02/13] driver/mempool: build mempool stack on Windows

Message ID	1629267476-901-3-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Jie Zhou <jizh@linux.microsoft.com> To: dev@dpdk.org Cc: dmitry.kozliuk@gmail.com, roretzla@microsoft.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net, aconole@redhat.com Date: Tue, 17 Aug 2021 23:17:45 -0700 Message-Id: <1629267476-901-3-git-send-email-jizh@linux.microsoft.com> In-Reply-To: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com> Subject: [dpdk-dev] [PATCH v1 02/13] driver/mempool: build mempool stack on Windows Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	app/test: enable subset of tests on Windows \| [v1,00/13] app/test: enable subset of tests on Windows [v1,01/13] lib: build libraries that some tests depend on [v1,02/13] driver/mempool: build mempool stack on Windows [v1,03/13] eal/windows: return ENOTSUP for not supported API [v1,04/13] app/test: remove unnecessary headers [v1,05/13] app/test: replace POSIX specific code [v1,06/13] app/test: exclude ENOTSUP as failure [v1,07/13] app/test: skip interrupt tests on Windows [v1,08/13] app/test: temporarily "skip" one cmdline test case [v1,09/13] app/test: skip two logs_autotest cases on Windows [v1,10/13] app/test: differentiate a strerror on different OS [v1,11/13] app/test: remove two alarm_autotest cases [v1,12/13] app/test: replace .sh scripts with .py scripts [v1,13/13] app/test: enable subset of unit tests on Windows

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues

Commit Message

Jie Zhou Aug. 18, 2021, 6:17 a.m. UTC

  From: Jie Zhou <jizh@microsoft.com>

mempool_autotest failed on Windows at setting the "stack" handler
test case. Per debugging, in rte_mempool_ops_table, there are only
6 ring ops registered, and no "stack" ops registered which caused
the failure of rte_mempool_set_ops_byname and thus the test failed.
Per code investigation, the "stack" ops are registered in
rte_mempool_stack.c:
MEMPOOL_REGISTER_OPS(ops_stack);
MEMPOOL_REGISTER_OPS(ops_lf_stack);

The reason these two ops are not registered is because currently
driver\mempool\stack is not build on Windows. After building stack
on Windows, the mempool_autotest now completed as pass.

Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 drivers/mempool/stack/meson.build | 5 -----
 1 file changed, 5 deletions(-)

diff mbox series

Patch

diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
index 371cf131b1..580dde79eb 100644
--- a/drivers/mempool/stack/meson.build
+++ b/drivers/mempool/stack/meson.build
@@ -1,11 +1,6 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-endif
-
 sources = files('rte_mempool_stack.c')
 
 deps += ['stack']