flow_classify: remove eperimental tag from the API
Checks
Commit Message
This API was introduced in 17.11, removing experimental tag
to promote to stable state.
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
lib/flow_classify/rte_flow_classify.h | 7 -------
lib/flow_classify/version.map | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
Comments
s/eperimental/experimental/
On 15/09/2021 16:16, Bernard Iremonger wrote:
> This API was introduced in 17.11, removing experimental tag
> to promote to stable state.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
> lib/flow_classify/rte_flow_classify.h | 7 -------
> lib/flow_classify/version.map | 2 +-
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
The library is still listed as experimental
https://git.dpdk.org/dpdk/tree/lib/flow_classify/rte_flow_classify.h#n13
and you can remove the allow_experimental_apis from the example app now.
> diff --git a/lib/flow_classify/rte_flow_classify.h b/lib/flow_classify/rte_flow_classify.h
> index 82ea92b6a6..3759cd32af 100644
> --- a/lib/flow_classify/rte_flow_classify.h
> +++ b/lib/flow_classify/rte_flow_classify.h
> @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> * @return
> * Handle to flow classifier instance on success or NULL otherwise
> */
> -__rte_experimental
> struct rte_flow_classifier *
> rte_flow_classifier_create(struct rte_flow_classifier_params *params);
>
> @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classifier_free(struct rte_flow_classifier *cls);
>
> @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> struct rte_flow_classify_table_params *params);
> @@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise
> */
> -__rte_experimental
> int
> rte_flow_classify_validate(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
> * @return
> * A valid handle in case of success, NULL otherwise.
> */
> -__rte_experimental
> struct rte_flow_classify_rule *
> rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> const struct rte_flow_attr *attr,
> @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> struct rte_flow_classify_rule *rule);
> @@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> * @return
> * 0 on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_flow_classifier_query(struct rte_flow_classifier *cls,
> struct rte_mbuf **pkts,
> diff --git a/lib/flow_classify/version.map b/lib/flow_classify/version.map
> index 49bc25c6a0..b7a888053b 100644
> --- a/lib/flow_classify/version.map
> +++ b/lib/flow_classify/version.map
> @@ -1,4 +1,4 @@
> -EXPERIMENTAL {
> +DPDK_22 {
> global:
>
> rte_flow_classifier_create;
>
Hi Kevin,
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, September 22, 2021 3:48 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Kinsella, Ray
> <ray.kinsella@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from
> the API
>
> s/eperimental/experimental/
>
> On 15/09/2021 16:16, Bernard Iremonger wrote:
> > This API was introduced in 17.11, removing experimental tag to promote
> > to stable state.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > lib/flow_classify/rte_flow_classify.h | 7 -------
> > lib/flow_classify/version.map | 2 +-
> > 2 files changed, 1 insertion(+), 8 deletions(-)
> >
>
> The library is still listed as experimental
> https://git.dpdk.org/dpdk/tree/lib/flow_classify/rte_flow_classify.h#n13
>
> and you can remove the allow_experimental_apis from the example app
> now.
Good catch.
I will remove allow_experimental_apis from the flow_classify/meson.build file.
> > diff --git a/lib/flow_classify/rte_flow_classify.h
> > b/lib/flow_classify/rte_flow_classify.h
> > index 82ea92b6a6..3759cd32af 100644
> > --- a/lib/flow_classify/rte_flow_classify.h
> > +++ b/lib/flow_classify/rte_flow_classify.h
> > @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> > * @return
> > * Handle to flow classifier instance on success or NULL otherwise
> > */
> > -__rte_experimental
> > struct rte_flow_classifier *
> > rte_flow_classifier_create(struct rte_flow_classifier_params
> > *params);
> >
> > @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct
> rte_flow_classifier_params *params);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_free(struct rte_flow_classifier *cls);
> >
> > @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier
> *cls);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_table_params *params); @@ -205,7
> +202,6
> > @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_validate(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier
> *cls,
> > * @return
> > * A valid handle in case of success, NULL otherwise.
> > */
> > -__rte_experimental
> > struct rte_flow_classify_rule *
> > rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct
> rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_rule *rule); @@ -273,7 +267,6 @@
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_query(struct rte_flow_classifier *cls,
> > struct rte_mbuf **pkts,
> > diff --git a/lib/flow_classify/version.map
> > b/lib/flow_classify/version.map index 49bc25c6a0..b7a888053b 100644
> > --- a/lib/flow_classify/version.map
> > +++ b/lib/flow_classify/version.map
> > @@ -1,4 +1,4 @@
> > -EXPERIMENTAL {
> > +DPDK_22 {
> > global:
> >
> > rte_flow_classifier_create;
> >
Regards,
Bernard.
On Wed, 15 Sep 2021 16:16:35 +0100
Bernard Iremonger <bernard.iremonger@intel.com> wrote:
> This API was introduced in 17.11, removing experimental tag
> to promote to stable state.
>
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
The API is unmaintained and because of that likely to be deprecated in future.
Marking it as stable at this point would not be a good idea.
@@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
* @return
* Handle to flow classifier instance on success or NULL otherwise
*/
-__rte_experimental
struct rte_flow_classifier *
rte_flow_classifier_create(struct rte_flow_classifier_params *params);
@@ -169,7 +168,6 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classifier_free(struct rte_flow_classifier *cls);
@@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier *cls);
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_table_create(struct rte_flow_classifier *cls,
struct rte_flow_classify_table_params *params);
@@ -205,7 +202,6 @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise
*/
-__rte_experimental
int
rte_flow_classify_validate(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier *cls,
* @return
* A valid handle in case of success, NULL otherwise.
*/
-__rte_experimental
struct rte_flow_classify_rule *
rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
const struct rte_flow_attr *attr,
@@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
struct rte_flow_classify_rule *rule);
@@ -273,7 +267,6 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
* @return
* 0 on success, error code otherwise.
*/
-__rte_experimental
int
rte_flow_classifier_query(struct rte_flow_classifier *cls,
struct rte_mbuf **pkts,
@@ -1,4 +1,4 @@
-EXPERIMENTAL {
+DPDK_22 {
global:
rte_flow_classifier_create;