diff mbox series

[v2] mempool/stack: build on Windows

Message ID 1633049412-13409-1-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] mempool/stack: build on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-testing warning apply patch failure

Commit Message

Jie Zhou Oct. 1, 2021, 12:50 a.m. UTC 
  enable build mempool/stack on Windows

----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on


Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 drivers/mempool/stack/meson.build | 5 -----
 lib/meson.build                   | 1 +
 2 files changed, 1 insertion(+), 5 deletions(-)

Comments

Dmitry Kozlyuk Oct. 1, 2021, 7:42 a.m. UTC | #1 
2021-09-30 17:50 (UTC-0700), Jie Zhou:
> enable build mempool/stack on Windows

Nit: in commit body, we use correct capitalization, punctuation, and spelling.

> ----
> V2 change:
> - enable build lib stack on Windows which mempool/stack depends on
> 
> 
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Thomas Monjalon Oct. 1, 2021, 2:44 p.m. UTC | #2 
01/10/2021 09:42, Dmitry Kozlyuk:
> 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > enable build mempool/stack on Windows
> 
> Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> 
> > ----
> > V2 change:
> > - enable build lib stack on Windows which mempool/stack depends on
> > 
> > 
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks.
Thomas Monjalon Oct. 1, 2021, 2:52 p.m. UTC | #3 
01/10/2021 16:44, Thomas Monjalon:
> 01/10/2021 09:42, Dmitry Kozlyuk:
> > 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > > enable build mempool/stack on Windows
> > 
> > Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> > 
> > > ----
> > > V2 change:
> > > - enable build lib stack on Windows which mempool/stack depends on
> > > 
> > > 
> > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > 
> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> 
> Applied, thanks.

Note: I had to add #include <sys/queue.h> because of a recent commit.
diff mbox series

Patch

diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
index 371cf131b1..580dde79eb 100644
--- a/drivers/mempool/stack/meson.build
+++ b/drivers/mempool/stack/meson.build
@@ -1,11 +1,6 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017-2019 Intel Corporation
 
-if is_windows
-    build = false
-    reason = 'not supported on Windows'
-endif
-
 sources = files('rte_mempool_stack.c')
 
 deps += ['stack']
diff --git a/lib/meson.build b/lib/meson.build
index 1673ca4323..9c4841fe40 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -85,6 +85,7 @@  if is_windows
             'gso',
             'latencystats',
             'pdump',
+            'stack',
     ] # only supported libraries for windows
 endif