diff mbox series

[v6,01/12] lib: build libraries that some tests depend on

Message ID 1634228502-14701-2-git-send-email-jizh@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series app/test: enable subset of tests on Windows | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jie Zhou Oct. 14, 2021, 4:21 p.m. UTC
Enable building subset of libraries that tests depend on for Windows

Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
 lib/meson.build | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon Oct. 25, 2021, 3:38 p.m. UTC | #1
14/10/2021 18:21, Jie Zhou:
> Enable building subset of libraries that tests depend on for Windows
> 
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---
>  lib/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index b2ba7258d8..bd6c27deef 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -82,9 +82,11 @@ if is_windows
>              'bitratestats',
>              'cryptodev',
>              'cfgfile',
> +            'efd',
>              'gro',
>              'gso',
>              'latencystats',
> +            'lpm',
>              'pdump',
>              'stack',
>              'security',
> 

It needs to be rebased after the recent changes to disable libs on Windows.
But instead of such patch, I would prefer one patch per lib,
with Tested-by tags showing that the lib is tested and working on Windows.
Also you need to Cc the maintainer of the lib being enabled.
Jie Zhou Oct. 26, 2021, 12:47 a.m. UTC | #2
On Mon, Oct 25, 2021 at 05:38:42PM +0200, Thomas Monjalon wrote:
> 14/10/2021 18:21, Jie Zhou:
> > Enable building subset of libraries that tests depend on for Windows
> > 
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> >  lib/meson.build | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/meson.build b/lib/meson.build
> > index b2ba7258d8..bd6c27deef 100644
> > --- a/lib/meson.build
> > +++ b/lib/meson.build
> > @@ -82,9 +82,11 @@ if is_windows
> >              'bitratestats',
> >              'cryptodev',
> >              'cfgfile',
> > +            'efd',
> >              'gro',
> >              'gso',
> >              'latencystats',
> > +            'lpm',
> >              'pdump',
> >              'stack',
> >              'security',
> > 
> 
> It needs to be rebased after the recent changes to disable libs on Windows.
> But instead of such patch, I would prefer one patch per lib,
> with Tested-by tags showing that the lib is tested and working on Windows.
> Also you need to Cc the maintainer of the lib being enabled.
>
Thanks Thomas. Will rebase in V7, and will separately enabling efd, lpm, and their corresponding unit tests in two patches after this one.
Thomas Monjalon Oct. 26, 2021, 8:44 a.m. UTC | #3
26/10/2021 02:47, Jie Zhou:
> On Mon, Oct 25, 2021 at 05:38:42PM +0200, Thomas Monjalon wrote:
> > 14/10/2021 18:21, Jie Zhou:
> > > Enable building subset of libraries that tests depend on for Windows
> > > 
> > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > > ---
> > >  lib/meson.build | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/lib/meson.build b/lib/meson.build
> > > index b2ba7258d8..bd6c27deef 100644
> > > --- a/lib/meson.build
> > > +++ b/lib/meson.build
> > > @@ -82,9 +82,11 @@ if is_windows
> > >              'bitratestats',
> > >              'cryptodev',
> > >              'cfgfile',
> > > +            'efd',
> > >              'gro',
> > >              'gso',
> > >              'latencystats',
> > > +            'lpm',
> > >              'pdump',
> > >              'stack',
> > >              'security',
> > > 
> > 
> > It needs to be rebased after the recent changes to disable libs on Windows.
> > But instead of such patch, I would prefer one patch per lib,
> > with Tested-by tags showing that the lib is tested and working on Windows.
> > Also you need to Cc the maintainer of the lib being enabled.
> >
> Thanks Thomas. Will rebase in V7, and will separately enabling efd, lpm, and their corresponding unit tests in two patches after this one. 

I think it enabling can be done in separate patches out of the series.
There is a chance to merge such patch before the big series.
diff mbox series

Patch

diff --git a/lib/meson.build b/lib/meson.build
index b2ba7258d8..bd6c27deef 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -82,9 +82,11 @@  if is_windows
             'bitratestats',
             'cryptodev',
             'cfgfile',
+            'efd',
             'gro',
             'gso',
             'latencystats',
+            'lpm',
             'pdump',
             'stack',
             'security',