diff mbox series

[v1] config/arm: add armv7 native config

Message ID 1637232351-21856-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] config/arm: add armv7 native config |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Juraj Linkeš Nov. 18, 2021, 10:45 a.m. UTC 
  Arvm7 native build fails with this error:
../config/meson.build:364:1: ERROR: Problem encountered:
Number of CPU cores not specified.

This is because RTE_MAX_LCORE is not set. We also need to set
RTE_MAX_NUMA_NODES in armv7 native builds.

Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 config/arm/meson.build | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ruifeng Wang Dec. 31, 2021, 7:11 a.m. UTC | #1 
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Thursday, November 18, 2021 6:46 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; ferruh.yigit@intel.com;
> christian.ehrhardt@canonical.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: add armv7 native config
> 
> Arvm7 native build fails with this error:

Typo, 'Armv7'

> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
> 
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
> 
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  config/arm/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
>      else
>          # armv7 build
>          dpdk_conf.set('RTE_ARCH_ARMv7', true)
> +        dpdk_conf.set('RTE_MAX_LCORE', 128)
> +        dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
>          # the minimum architecture supported, armv7-a, needs the following,
>          machine_args += '-mfpu=neon'
>      endif
> --
> 2.20.1
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Stephen Hemminger Dec. 31, 2021, 5:23 p.m. UTC | #2 
On Thu, 18 Nov 2021 11:45:51 +0100
Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:

> Arvm7 native build fails with this error:
> ../config/meson.build:364:1: ERROR: Problem encountered:
> Number of CPU cores not specified.
> 
> This is because RTE_MAX_LCORE is not set. We also need to set
> RTE_MAX_NUMA_NODES in armv7 native builds.
> 
> Fixes: 8ef09fdc506b ("build: add optional NUMA and CPU counts detection")
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  config/arm/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 213324d262..57980661b2 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -432,6 +432,8 @@ if dpdk_conf.get('RTE_ARCH_32')
>      else
>          # armv7 build
>          dpdk_conf.set('RTE_ARCH_ARMv7', true)
> +        dpdk_conf.set('RTE_MAX_LCORE', 128)
> +        dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)

In DPDK 19.11 the ARMv7 config says armv7 does not support NUMA.
Pleas set NUMA_NODES to 1
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 213324d262..57980661b2 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -432,6 +432,8 @@  if dpdk_conf.get('RTE_ARCH_32')
     else
         # armv7 build
         dpdk_conf.set('RTE_ARCH_ARMv7', true)
+        dpdk_conf.set('RTE_MAX_LCORE', 128)
+        dpdk_conf.set('RTE_MAX_NUMA_NODES', 8)
         # the minimum architecture supported, armv7-a, needs the following,
         machine_args += '-mfpu=neon'
     endif