diff mbox series

[v2] vdpa/ifc: fix log info mismatch

Message ID 1639377367-123308-1-git-send-email-andy.pei@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series [v2] vdpa/ifc: fix log info mismatch |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Pei, Andy Dec. 13, 2021, 6:36 a.m. UTC 
  fix log info mismatch.

Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
Cc: xiao.w.wang@intel.com

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Comments

Xiao Wang Dec. 13, 2021, 7:29 a.m. UTC | #1 
Hi Andy,

BRs,
Xiao

> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Monday, December 13, 2021 2:36 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Subject: [PATCH v2] vdpa/ifc: fix log info mismatch
> 
> fix log info mismatch.

Use "Fix".

> 
> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> Cc: xiao.w.wang@intel.com

For fix patch, you need to Cc "stable@dpdk.org", not me.

> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c
> index 721cb1d..d10c1fd 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.c
> +++ b/drivers/vdpa/ifc/base/ifcvf.c
> @@ -94,12 +94,14 @@
>  		return -1;
>  	}
> 
> -	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
> -			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
> -			"multiplier: %u\n",
> -			hw->common_cfg, hw->dev_cfg,
> -			hw->isr, hw->notify_base,
> -			hw->notify_off_multiplier);
> +	DEBUGOUT("capability mapping:\n"
> +		 "common cfg: %p\n"
> +		 "notify base: %p\n"
> +		 "isr cfg: %p\n"
> +		 "device cfg: %p\n"
> +		 "multiplier: %u\n",
> +		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
> +		 hw->notify_off_multiplier);
> 
>  	return 0;
>  }
> --
> 1.8.3.1
Pei, Andy Dec. 13, 2021, 7:36 a.m. UTC | #2 
Hi Xiao,

Thanks for your reply.
I will send a V3 patch to address this.

-----Original Message-----
From: Wang, Xiao W <xiao.w.wang@intel.com> 
Sent: Monday, December 13, 2021 3:30 PM
To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
Cc: Xia, Chenbo <chenbo.xia@intel.com>
Subject: RE: [PATCH v2] vdpa/ifc: fix log info mismatch

Hi Andy,

BRs,
Xiao

> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Monday, December 13, 2021 2:36 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; Wang, Xiao W 
> <xiao.w.wang@intel.com>
> Subject: [PATCH v2] vdpa/ifc: fix log info mismatch
> 
> fix log info mismatch.

Use "Fix".

> 
> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> Cc: xiao.w.wang@intel.com

For fix patch, you need to Cc "stable@dpdk.org", not me.

> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/vdpa/ifc/base/ifcvf.c | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/base/ifcvf.c 
> b/drivers/vdpa/ifc/base/ifcvf.c index 721cb1d..d10c1fd 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.c
> +++ b/drivers/vdpa/ifc/base/ifcvf.c
> @@ -94,12 +94,14 @@
>  		return -1;
>  	}
> 
> -	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
> -			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
> -			"multiplier: %u\n",
> -			hw->common_cfg, hw->dev_cfg,
> -			hw->isr, hw->notify_base,
> -			hw->notify_off_multiplier);
> +	DEBUGOUT("capability mapping:\n"
> +		 "common cfg: %p\n"
> +		 "notify base: %p\n"
> +		 "isr cfg: %p\n"
> +		 "device cfg: %p\n"
> +		 "multiplier: %u\n",
> +		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
> +		 hw->notify_off_multiplier);
> 
>  	return 0;
>  }
> --
> 1.8.3.1
diff mbox series

Patch

diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c
index 721cb1d..d10c1fd 100644
--- a/drivers/vdpa/ifc/base/ifcvf.c
+++ b/drivers/vdpa/ifc/base/ifcvf.c
@@ -94,12 +94,14 @@ 
 		return -1;
 	}
 
-	DEBUGOUT("capability mapping:\ncommon cfg: %p\n"
-			"notify base: %p\nisr cfg: %p\ndevice cfg: %p\n"
-			"multiplier: %u\n",
-			hw->common_cfg, hw->dev_cfg,
-			hw->isr, hw->notify_base,
-			hw->notify_off_multiplier);
+	DEBUGOUT("capability mapping:\n"
+		 "common cfg: %p\n"
+		 "notify base: %p\n"
+		 "isr cfg: %p\n"
+		 "device cfg: %p\n"
+		 "multiplier: %u\n",
+		 hw->common_cfg, hw->notify_base, hw->isr, hw->dev_cfg,
+		 hw->notify_off_multiplier);
 
 	return 0;
 }