From patchwork Mon May 16 20:48:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Chautru, Nicolas" X-Patchwork-Id: 111200 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7952EA00BE; Mon, 16 May 2022 22:56:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF8E42B74; Mon, 16 May 2022 22:56:28 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 5C3D440E03 for ; Mon, 16 May 2022 22:56:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652734584; x=1684270584; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=9ocSml247WhQo0uFH9foT4ozYs8yTN6kx18Ws2L8Rh4=; b=IrY1hi1beQdUpSLuNWjUSTTmum83Tfsj8IWpaI7kSAnSwesXELcP1EtT +WWXemhd2IBvLrh6AxL7qnSYkkAykDkQvczw4N3Da809CXvU4m/mdvjoX LfS2/fqjuS0raK9nf1DTHuID38qIOrN5ty8MNI1Ba93izyM5W+2Somz5V 6ki1DMkwynVp8QqtLa9nyzoVrpWCN9h5ouE/F5T59I7xQZBvx+dZtUwx2 lAEzpci1QcBx77ECTb1vwnrbOOmuILBgWMYh5tduVzTbd+dI4scs8SO3I p7j+zpomOtWoA0nhkZEOXyz4ospplgfkSNVmtY2diMU0/hXSj7OWoj9aI w==; X-IronPort-AV: E=McAfee;i="6400,9594,10349"; a="251476096" X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="251476096" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2022 13:56:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,230,1647327600"; d="scan'208";a="574199177" Received: from skx-5gnr-sc12-4.sc.intel.com ([172.25.69.210]) by fmsmga007.fm.intel.com with ESMTP; 16 May 2022 13:56:21 -0700 From: Nicolas Chautru To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: thomas@monjalon.net, ray.kinsella@intel.com, bruce.richardson@intel.com, hemant.agrawal@nxp.com, hernan.vargas@intel.com, david.marchand@redhat.com, Nicolas Chautru Subject: [PATCH v3 4/4] baseband/acc100: add protection for some negative scenario Date: Mon, 16 May 2022 13:48:33 -0700 Message-Id: <1652734113-124047-5-git-send-email-nicolas.chautru@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1652734113-124047-1-git-send-email-nicolas.chautru@intel.com> References: <1651083423-33202-1-git-send-email-nicolas.chautru@intel.com> <1652734113-124047-1-git-send-email-nicolas.chautru@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Catch exception in PMD in case of invalid input parameter. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index b03cedc..b59c9d7 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -1237,6 +1237,8 @@ return (bg == 1 ? ACC100_K0_3_1 : ACC100_K0_3_2) * z_c; } /* LBRM case - includes a division by N */ + if (unlikely(z_c == 0)) + return 0; if (rv_index == 1) return (((bg == 1 ? ACC100_K0_1_1 : ACC100_K0_1_2) * n_cb) / n) * z_c; @@ -1912,6 +1914,10 @@ static inline uint32_t hq_index(uint32_t offset) /* Soft output */ if (check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_SOFT_OUTPUT)) { + if (op->turbo_dec.soft_output.data == 0) { + rte_bbdev_log(ERR, "Soft output is not defined"); + return -1; + } if (check_bit(op->turbo_dec.op_flags, RTE_BBDEV_TURBO_EQUALIZER)) *s_out_length = e;