From patchwork Mon Aug 8 21:21:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 114728 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32934A0540; Mon, 8 Aug 2022 23:21:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE04942BA4; Mon, 8 Aug 2022 23:21:40 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E060B42B83 for ; Mon, 8 Aug 2022 23:21:36 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 13E112109428; Mon, 8 Aug 2022 14:21:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 13E112109428 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1659993696; bh=M/P9myIibgAEdjsQiEX2+Ph8cqPxUuVjNGsHh/F3Z5Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RjFu+kmc6R5isQ2ioxcpdz6zS6d87QZvB1sgCAWn3OYNo3QtgQG8mqAwAby09ljxC ff+y0gpyIER1UgVabCoj0YKlY1Lr9frWsP0x4ZSlvbf2kFgXJWNExAAzmFZCyEVYI6 UyAIBuQLMzPTmDWG7qzFm7blSoGBF2q9+DmoPFHE= From: Tyler Retzlaff To: dev@dpdk.org Cc: thomas@monjalon.net, anatoly.burakov@intel.com, ranjit.menon@intel.com, mb@smartsharesystems.com, Tyler Retzlaff , Tyler Retzlaff Subject: [PATCH 1/3] doc: announce cleanup of rte_{bsf, fls} inline functions type use Date: Mon, 8 Aug 2022 14:21:30 -0700 Message-Id: <1659993692-17479-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1659993692-17479-1-git-send-email-roretzla@linux.microsoft.com> References: <1615418650-19513-1-git-send-email-roretzla@linux.microsoft.com> <1659993692-17479-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Tyler Retzlaff The cleanup resulted from request to review [1] the following functions where there appeared to be inconsistency in return type or parameter type selections for the following inline functions. rte_bsf32() rte_bsf32_safe() rte_bsf64() rte_bsf64_safe() rte_fls_u32() rte_fls_u64() rte_log2_u32() rte_log2_u64() [1] http://mails.dpdk.org/archives/dev/2021-March/201590.html Signed-off-by: Tyler Retzlaff --- doc/guides/rel_notes/deprecation.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index e7583ca..58f4c24 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -17,6 +17,12 @@ Deprecation Notices * eal: The function ``rte_eal_remote_launch`` will return new error codes after read or write error on the pipe, instead of calling ``rte_panic``. +* eal: Fix inline function return and parameter types for rte_{bsf,fls} + inline functions to be consistent in DPDK 22.11. + Change ``rte_bsf64`` return type to ``uint32_t`` instead of ``int``. + Change ``rte_fls_u32`` return type to ``uint32_t`` instead of ``int``. + Change ``rte_fls_u64`` return type to ``uint32_t`` instead of ``int``. + * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does not allow for writing optimized code for all the CPU architectures supported in DPDK. DPDK has adopted the atomic operations from