diff mbox series

[v2,1/8] vdpa/ifc: add new device ID

Message ID	1662616458-164613-2-git-send-email-andy.pei@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Maxime Coquelin
Headers	From: Andy Pei <andy.pei@intel.com> To: dev@dpdk.org Cc: chenbo.xia@intel.com, rosen.xu@intel.com, wei.huang@intel.com, gang.cao@intel.com, maxime.coquelin@redhat.com, Huang Wei <wei_huang@intel.com> Subject: [PATCH v2 1/8] vdpa/ifc: add new device ID Date: Thu, 8 Sep 2022 13:54:11 +0800 Message-Id: <1662616458-164613-2-git-send-email-andy.pei@intel.com> In-Reply-To: <1662616458-164613-1-git-send-email-andy.pei@intel.com> References: <1661229305-240952-2-git-send-email-andy.pei@intel.com> <1662616458-164613-1-git-send-email-andy.pei@intel.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	vdpa/ifc: add multi queue support \| [v2,0/8] vdpa/ifc: add multi queue support [v2,1/8] vdpa/ifc: add new device ID [v2,2/8] vdpa/ifc: add multi queue support [v2,3/8] vdpa/ifc: set max queues according to HW spec [v2,4/8] vdpa/ifc: write queue count to MQ register [v2,5/8] vdpa/ifc: only configure enabled queue [v2,6/8] vdpa/ifc: support dynamic enable/disable queue [v2,7/8] vhost: configure device when any queue is ready for BLK device [v2,8/8] vhost: vDPA BLK devices configure device when all queue callfds are set

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Pei, Andy Sept. 8, 2022, 5:54 a.m. UTC

  From: Huang Wei <wei_huang@intel.com>

Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000).

Signed-off-by: Huang Wei <wei_huang@intel.com>
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/vdpa/ifc/base/ifcvf.h | 4 +++-
 drivers/vdpa/ifc/ifcvf_vdpa.c | 9 ++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

Comments

Chenbo Xia Sept. 9, 2022, 12:29 a.m. UTC | #1

Hi Andy,

> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Thursday, September 8, 2022 1:54 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Huang, Wei <wei.huang@intel.com>; Cao, Gang <gang.cao@intel.com>;
> maxime.coquelin@redhat.com; Huang Wei <wei_huang@intel.com>
> Subject: [PATCH v2 1/8] vdpa/ifc: add new device ID

Title could be: add new device ID for legacy network device

> 
> From: Huang Wei <wei_huang@intel.com>
> 
> Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000).
> 
> Signed-off-by: Huang Wei <wei_huang@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/vdpa/ifc/base/ifcvf.h | 4 +++-
>  drivers/vdpa/ifc/ifcvf_vdpa.c | 9 ++++++++-
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index 9d95aac..7ede738 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -12,11 +12,13 @@
>  #define IFCVF_BLK	1
> 
>  #define IFCVF_VENDOR_ID                     0x1AF4
> -#define IFCVF_NET_DEVICE_ID                 0x1041
> +#define IFCVF_NET_MODERN_DEVICE_ID          0x1041
>  #define IFCVF_BLK_MODERN_DEVICE_ID          0x1042
> +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID    0x1000
>  #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID    0x1001
>  #define IFCVF_SUBSYS_VENDOR_ID              0x8086
>  #define IFCVF_SUBSYS_DEVICE_ID              0x001A
> +#define IFCVF_NET_DEVICE_ID                 0x0001

For subsystem device ID, I suggest to add _SUBSYS_, please check all
Subsystem device ID and make all the names well-defined.

Thanks,
Chenbo

>  #define IFCVF_BLK_DEVICE_ID                 0x0002
> 
>  #define IFCVF_MAX_QUEUES		1
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index ac42de9..61d0250 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1684,13 +1684,20 @@ struct rte_vdpa_dev_info dev_info[] = {
>  static const struct rte_pci_id pci_id_ifcvf_map[] = {
>  	{ .class_id = RTE_CLASS_ANY_ID,
>  	  .vendor_id = IFCVF_VENDOR_ID,
> -	  .device_id = IFCVF_NET_DEVICE_ID,
> +	  .device_id = IFCVF_NET_MODERN_DEVICE_ID,
>  	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
>  	  .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
>  	},
> 
>  	{ .class_id = RTE_CLASS_ANY_ID,
>  	  .vendor_id = IFCVF_VENDOR_ID,
> +	  .device_id = IFCVF_NET_TRANSITIONAL_DEVICE_ID,
> +	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> +	  .subsystem_device_id = IFCVF_NET_DEVICE_ID,
> +	},
> +
> +	{ .class_id = RTE_CLASS_ANY_ID,
> +	  .vendor_id = IFCVF_VENDOR_ID,
>  	  .device_id = IFCVF_BLK_TRANSITIONAL_DEVICE_ID,
>  	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
>  	  .subsystem_device_id = IFCVF_BLK_DEVICE_ID,
> --
> 1.8.3.1

Pei, Andy Sept. 9, 2022, 7:44 a.m. UTC | #2

Hi Chenbo, 

Thanks for your reply.
I will send V3 patch to address your 2 comments.

> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Friday, September 9, 2022 8:29 AM
> To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Huang, Wei <wei.huang@intel.com>; Cao,
> Gang <gang.cao@intel.com>; maxime.coquelin@redhat.com; Huang Wei
> <wei_huang@intel.com>
> Subject: RE: [PATCH v2 1/8] vdpa/ifc: add new device ID
> 
> Hi Andy,
> 
> > -----Original Message-----
> > From: Pei, Andy <andy.pei@intel.com>
> > Sent: Thursday, September 8, 2022 1:54 PM
> > To: dev@dpdk.org
> > Cc: Xia, Chenbo <chenbo.xia@intel.com>; Xu, Rosen
> > <rosen.xu@intel.com>; Huang, Wei <wei.huang@intel.com>; Cao, Gang
> > <gang.cao@intel.com>; maxime.coquelin@redhat.com; Huang Wei
> > <wei_huang@intel.com>
> > Subject: [PATCH v2 1/8] vdpa/ifc: add new device ID
> 
> Title could be: add new device ID for legacy network device
> 
> >
> > From: Huang Wei <wei_huang@intel.com>
> >
> > Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000).
> >
> > Signed-off-by: Huang Wei <wei_huang@intel.com>
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > ---
> >  drivers/vdpa/ifc/base/ifcvf.h | 4 +++-  drivers/vdpa/ifc/ifcvf_vdpa.c
> > | 9 ++++++++-
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/vdpa/ifc/base/ifcvf.h
> > b/drivers/vdpa/ifc/base/ifcvf.h index 9d95aac..7ede738 100644
> > --- a/drivers/vdpa/ifc/base/ifcvf.h
> > +++ b/drivers/vdpa/ifc/base/ifcvf.h
> > @@ -12,11 +12,13 @@
> >  #define IFCVF_BLK	1
> >
> >  #define IFCVF_VENDOR_ID                     0x1AF4
> > -#define IFCVF_NET_DEVICE_ID                 0x1041
> > +#define IFCVF_NET_MODERN_DEVICE_ID          0x1041
> >  #define IFCVF_BLK_MODERN_DEVICE_ID          0x1042
> > +#define IFCVF_NET_TRANSITIONAL_DEVICE_ID    0x1000
> >  #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID    0x1001
> >  #define IFCVF_SUBSYS_VENDOR_ID              0x8086
> >  #define IFCVF_SUBSYS_DEVICE_ID              0x001A
> > +#define IFCVF_NET_DEVICE_ID                 0x0001
> 
> For subsystem device ID, I suggest to add _SUBSYS_, please check all Subsystem
> device ID and make all the names well-defined.
> 
> Thanks,
> Chenbo
> 
> >  #define IFCVF_BLK_DEVICE_ID                 0x0002
> >
> >  #define IFCVF_MAX_QUEUES		1
> > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > b/drivers/vdpa/ifc/ifcvf_vdpa.c index ac42de9..61d0250 100644
> > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> > @@ -1684,13 +1684,20 @@ struct rte_vdpa_dev_info dev_info[] = {
> > static const struct rte_pci_id pci_id_ifcvf_map[] = {
> >  	{ .class_id = RTE_CLASS_ANY_ID,
> >  	  .vendor_id = IFCVF_VENDOR_ID,
> > -	  .device_id = IFCVF_NET_DEVICE_ID,
> > +	  .device_id = IFCVF_NET_MODERN_DEVICE_ID,
> >  	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> >  	  .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
> >  	},
> >
> >  	{ .class_id = RTE_CLASS_ANY_ID,
> >  	  .vendor_id = IFCVF_VENDOR_ID,
> > +	  .device_id = IFCVF_NET_TRANSITIONAL_DEVICE_ID,
> > +	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> > +	  .subsystem_device_id = IFCVF_NET_DEVICE_ID,
> > +	},
> > +
> > +	{ .class_id = RTE_CLASS_ANY_ID,
> > +	  .vendor_id = IFCVF_VENDOR_ID,
> >  	  .device_id = IFCVF_BLK_TRANSITIONAL_DEVICE_ID,
> >  	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> >  	  .subsystem_device_id = IFCVF_BLK_DEVICE_ID,
> > --
> > 1.8.3.1

diff mbox series

Patch

diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
index 9d95aac..7ede738 100644
--- a/drivers/vdpa/ifc/base/ifcvf.h
+++ b/drivers/vdpa/ifc/base/ifcvf.h
@@ -12,11 +12,13 @@ 
 #define IFCVF_BLK	1
 
 #define IFCVF_VENDOR_ID                     0x1AF4
-#define IFCVF_NET_DEVICE_ID                 0x1041
+#define IFCVF_NET_MODERN_DEVICE_ID          0x1041
 #define IFCVF_BLK_MODERN_DEVICE_ID          0x1042
+#define IFCVF_NET_TRANSITIONAL_DEVICE_ID    0x1000
 #define IFCVF_BLK_TRANSITIONAL_DEVICE_ID    0x1001
 #define IFCVF_SUBSYS_VENDOR_ID              0x8086
 #define IFCVF_SUBSYS_DEVICE_ID              0x001A
+#define IFCVF_NET_DEVICE_ID                 0x0001
 #define IFCVF_BLK_DEVICE_ID                 0x0002
 
 #define IFCVF_MAX_QUEUES		1
diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index ac42de9..61d0250 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1684,13 +1684,20 @@  struct rte_vdpa_dev_info dev_info[] = {
 static const struct rte_pci_id pci_id_ifcvf_map[] = {
 	{ .class_id = RTE_CLASS_ANY_ID,
 	  .vendor_id = IFCVF_VENDOR_ID,
-	  .device_id = IFCVF_NET_DEVICE_ID,
+	  .device_id = IFCVF_NET_MODERN_DEVICE_ID,
 	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
 	  .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
 	},
 
 	{ .class_id = RTE_CLASS_ANY_ID,
 	  .vendor_id = IFCVF_VENDOR_ID,
+	  .device_id = IFCVF_NET_TRANSITIONAL_DEVICE_ID,
+	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
+	  .subsystem_device_id = IFCVF_NET_DEVICE_ID,
+	},
+
+	{ .class_id = RTE_CLASS_ANY_ID,
+	  .vendor_id = IFCVF_VENDOR_ID,
 	  .device_id = IFCVF_BLK_TRANSITIONAL_DEVICE_ID,
 	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
 	  .subsystem_device_id = IFCVF_BLK_DEVICE_ID,