diff mbox series

[v8,07/12] vdpa/ifc: change internal function name

Message ID 1666094871-25721-8-git-send-email-andy.pei@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series vdpa/ifc: add multi queue support |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Pei, Andy Oct. 18, 2022, 12:07 p.m. UTC 
  Change internal function name "find_internal_resource_by_dev"
to "find_internal_resource_by_pci_dev".

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Maxime Coquelin Oct. 18, 2022, 1:44 p.m. UTC | #1 
On 10/18/22 14:07, Andy Pei wrote:
> Change internal function name "find_internal_resource_by_dev"
> to "find_internal_resource_by_pci_dev".
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>   drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 9c49f9c..73d04ed 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -121,7 +121,7 @@ struct rte_vdpa_dev_info {
>   }
>   
>   static struct internal_list *
> -find_internal_resource_by_dev(struct rte_pci_device *pdev)
> +find_internal_resource_by_pci_dev(struct rte_pci_device *pdev)
>   {
>   	int found = 0;
>   	struct internal_list *list;
> @@ -1746,7 +1746,7 @@ struct rte_vdpa_dev_info dev_info[] = {
>   	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>   		return 0;
>   
> -	list = find_internal_resource_by_dev(pci_dev);
> +	list = find_internal_resource_by_pci_dev(pci_dev);
>   	if (list == NULL) {
>   		DRV_LOG(ERR, "Invalid device: %s", pci_dev->name);
>   		return -1;

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Pei, Andy Oct. 18, 2022, 1:47 p.m. UTC | #2 
Hi Maxime,

Thanks for your efforts.

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Tuesday, October 18, 2022 9:45 PM
> To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
> Cc: Xia, Chenbo <Chenbo.Xia@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Huang, Wei <wei.huang@intel.com>; Cao, Gang <gang.cao@intel.com>
> Subject: Re: [PATCH v8 07/12] vdpa/ifc: change internal function name
> 
> 
> 
> On 10/18/22 14:07, Andy Pei wrote:
> > Change internal function name "find_internal_resource_by_dev"
> > to "find_internal_resource_by_pci_dev".
> >
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > ---
> >   drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 9c49f9c..73d04ed 100644
> > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> > @@ -121,7 +121,7 @@ struct rte_vdpa_dev_info {
> >   }
> >
> >   static struct internal_list *
> > -find_internal_resource_by_dev(struct rte_pci_device *pdev)
> > +find_internal_resource_by_pci_dev(struct rte_pci_device *pdev)
> >   {
> >   	int found = 0;
> >   	struct internal_list *list;
> > @@ -1746,7 +1746,7 @@ struct rte_vdpa_dev_info dev_info[] = {
> >   	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> >   		return 0;
> >
> > -	list = find_internal_resource_by_dev(pci_dev);
> > +	list = find_internal_resource_by_pci_dev(pci_dev);
> >   	if (list == NULL) {
> >   		DRV_LOG(ERR, "Invalid device: %s", pci_dev->name);
> >   		return -1;
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime
Chenbo Xia Oct. 19, 2022, 6:59 a.m. UTC | #3 
> -----Original Message-----
> From: Pei, Andy <andy.pei@intel.com>
> Sent: Tuesday, October 18, 2022 8:08 PM
> To: dev@dpdk.org
> Cc: Xia, Chenbo <chenbo.xia@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Huang, Wei <wei.huang@intel.com>; Cao, Gang <gang.cao@intel.com>;
> maxime.coquelin@redhat.com
> Subject: [PATCH v8 07/12] vdpa/ifc: change internal function name
> 
> Change internal function name "find_internal_resource_by_dev"
> to "find_internal_resource_by_pci_dev".
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 9c49f9c..73d04ed 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -121,7 +121,7 @@ struct rte_vdpa_dev_info {
>  }
> 
>  static struct internal_list *
> -find_internal_resource_by_dev(struct rte_pci_device *pdev)
> +find_internal_resource_by_pci_dev(struct rte_pci_device *pdev)
>  {
>  	int found = 0;
>  	struct internal_list *list;
> @@ -1746,7 +1746,7 @@ struct rte_vdpa_dev_info dev_info[] = {
>  	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
>  		return 0;
> 
> -	list = find_internal_resource_by_dev(pci_dev);
> +	list = find_internal_resource_by_pci_dev(pci_dev);
>  	if (list == NULL) {
>  		DRV_LOG(ERR, "Invalid device: %s", pci_dev->name);
>  		return -1;
> --
> 1.8.3.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Pei, Andy Oct. 19, 2022, 9:41 a.m. UTC | #4 
HI Chenbo,

Thanks for your review.

> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Wednesday, October 19, 2022 2:59 PM
> To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Huang, Wei <wei.huang@intel.com>;
> Cao, Gang <gang.cao@intel.com>; maxime.coquelin@redhat.com
> Subject: RE: [PATCH v8 07/12] vdpa/ifc: change internal function name
> 
> > -----Original Message-----
> > From: Pei, Andy <andy.pei@intel.com>
> > Sent: Tuesday, October 18, 2022 8:08 PM
> > To: dev@dpdk.org
> > Cc: Xia, Chenbo <chenbo.xia@intel.com>; Xu, Rosen
> > <rosen.xu@intel.com>; Huang, Wei <wei.huang@intel.com>; Cao, Gang
> > <gang.cao@intel.com>; maxime.coquelin@redhat.com
> > Subject: [PATCH v8 07/12] vdpa/ifc: change internal function name
> >
> > Change internal function name "find_internal_resource_by_dev"
> > to "find_internal_resource_by_pci_dev".
> >
> > Signed-off-by: Andy Pei <andy.pei@intel.com>
> > ---
> >  drivers/vdpa/ifc/ifcvf_vdpa.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 9c49f9c..73d04ed 100644
> > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> > @@ -121,7 +121,7 @@ struct rte_vdpa_dev_info {  }
> >
> >  static struct internal_list *
> > -find_internal_resource_by_dev(struct rte_pci_device *pdev)
> > +find_internal_resource_by_pci_dev(struct rte_pci_device *pdev)
> >  {
> >  	int found = 0;
> >  	struct internal_list *list;
> > @@ -1746,7 +1746,7 @@ struct rte_vdpa_dev_info dev_info[] = {
> >  	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
> >  		return 0;
> >
> > -	list = find_internal_resource_by_dev(pci_dev);
> > +	list = find_internal_resource_by_pci_dev(pci_dev);
> >  	if (list == NULL) {
> >  		DRV_LOG(ERR, "Invalid device: %s", pci_dev->name);
> >  		return -1;
> > --
> > 1.8.3.1
> 
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
diff mbox series

Patch

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 9c49f9c..73d04ed 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -121,7 +121,7 @@  struct rte_vdpa_dev_info {
 }
 
 static struct internal_list *
-find_internal_resource_by_dev(struct rte_pci_device *pdev)
+find_internal_resource_by_pci_dev(struct rte_pci_device *pdev)
 {
 	int found = 0;
 	struct internal_list *list;
@@ -1746,7 +1746,7 @@  struct rte_vdpa_dev_info dev_info[] = {
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
 		return 0;
 
-	list = find_internal_resource_by_dev(pci_dev);
+	list = find_internal_resource_by_pci_dev(pci_dev);
 	if (list == NULL) {
 		DRV_LOG(ERR, "Invalid device: %s", pci_dev->name);
 		return -1;