diff mbox series

[v9,4/4] eal: deprecation notice for rte thread setname API

Message ID 1674583351-15292-5-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series add rte_thread_set_name API for rte_thread_t |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Tyler Retzlaff Jan. 24, 2023, 6:02 p.m. UTC 
  Notify deprecation of rte_thread_setname API, it will be removed as it
exposes platform-specific thread details. The functionality it provided
is now available via the new rte_lcore_set_name API.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: David Marchand <david.marchand@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Monjalon Jan. 24, 2023, 6:05 p.m. UTC | #1 
24/01/2023 19:02, Tyler Retzlaff:
> +* eal: The function ``rte_thread_setname`` is planned to be deprecated
> +  starting with the 23.03 release subject to the replacement API
> +  rte_thread_set_name being marked as stable and planned to be removed
> +  by the 23.11 release.

You are introducing rte_thread_set_name as experimental in 23.03.
So we are supposed to wait at least a release to make it stable.
Let's deprecate it in 23.07 and remove in 23.11.
Tyler Retzlaff Jan. 24, 2023, 6:21 p.m. UTC | #2 
On Tue, Jan 24, 2023 at 07:05:18PM +0100, Thomas Monjalon wrote:
> 24/01/2023 19:02, Tyler Retzlaff:
> > +* eal: The function ``rte_thread_setname`` is planned to be deprecated
> > +  starting with the 23.03 release subject to the replacement API
> > +  rte_thread_set_name being marked as stable and planned to be removed
> > +  by the 23.11 release.
> 
> You are introducing rte_thread_set_name as experimental in 23.03.
> So we are supposed to wait at least a release to make it stable.
> Let's deprecate it in 23.07 and remove in 23.11.
> 

updated with recommended date.

thanks
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index e18ac34..5eb930f 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -18,6 +18,11 @@  Deprecation Notices
   in the future. Applications can use ``devtools/cocci/func_or_ret.cocci``
   to update their code.
 
+* eal: The function ``rte_thread_setname`` is planned to be deprecated
+  starting with the 23.03 release subject to the replacement API
+  rte_thread_set_name being marked as stable and planned to be removed
+  by the 23.11 release.
+
 * rte_atomicNN_xxx: These APIs do not take memory order parameter. This does
   not allow for writing optimized code for all the CPU architectures supported
   in DPDK. DPDK has adopted the atomic operations from