From patchwork Wed Aug 2 05:31:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 129809 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E72F742FB4; Wed, 2 Aug 2023 07:32:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1774243253; Wed, 2 Aug 2023 07:32:02 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0FC2F41153 for ; Wed, 2 Aug 2023 07:32:00 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 30629238AF6D; Tue, 1 Aug 2023 22:31:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 30629238AF6D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1690954319; bh=Mt3xMBwV/FxB1gWzuliMBl/8PMkAJlWII9nC7xbV+bo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FlSbu+xr+zGeHMVwiZWO8b7/ge2ZOlulKu+VJpw/1VHA029ssDUaQrSLOr4sXFFlG mdkOWnZj/09NPzDF5Ln6NT+0Ixj9s+1wuf5bnZ4+NRpmAo6O3INmPameppndSaj7sy I6sHxcSaI0mU8Iy96OihQmIGjoJyzREAl9QDrpJA= From: Tyler Retzlaff To: dev@dpdk.org Cc: Gaetan Rivet , Bruce Richardson , Thomas Monjalon , Nicolas Chautru , Yipeng Wang , Sameh Gobriel , Vladimir Medvedkin , Honnappa Nagarahalli , Konstantin Ananyev , Anatoly Burakov , Olivier Matz , Andrew Rybchenko , Joyce Kong , Erik Gabriel Carrillo , Liang Ma , Peter Mccarthy , Jerin Jacob , Maciej Czekaj , David Hunt , Ruifeng Wang , Min Zhou , David Christensen , Stanislaw Kardach , david.marchand@redhat.com, stephen@networkplumber.org, mb@smartsharesystems.com, Tyler Retzlaff Subject: [PATCH v4 2/4] devtools: forbid use of GCC atomic builtins Date: Tue, 1 Aug 2023 22:31:56 -0700 Message-Id: <1690954318-3126-3-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com> References: <1690837661-27573-1-git-send-email-roretzla@linux.microsoft.com> <1690954318-3126-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Refrain from using compiler __atomic_xxx builtins DPDK now uses standard C11 atomics atomic_xxx. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- devtools/checkpatches.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 43f5e36..a32f02e 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -102,6 +102,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # refrain from using compiler __atomic_xxx builtins + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS="__atomic_.*\\\(" \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __atomic_xxx builtins' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # refrain from using compiler __atomic_thread_fence() # It should be avoided on x86 for SMP case. awk -v FOLDERS="lib drivers app examples" \