diff mbox series

windows: install sched.h header

Message ID 1703017057-22336-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series windows: install sched.h header |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Tyler Retzlaff Dec. 19, 2023, 8:17 p.m. UTC 
  rte_os.h includes sched.h so install sched.h to allow DPDK installed to
DESTDIR to be usable.

Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
 lib/eal/windows/include/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson Dec. 20, 2023, 9:11 a.m. UTC | #1 
On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Jan. 30, 2024, 4:52 p.m. UTC | #2 
20/12/2023 10:11, Bruce Richardson:
> On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > DESTDIR to be usable.

Why other files don't need to be exported as well?

> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

That's a fix which may need to be backported.
Tyler Retzlaff March 12, 2024, 5:55 p.m. UTC | #3 
On Tue, Jan 30, 2024 at 05:52:54PM +0100, Thomas Monjalon wrote:
> 20/12/2023 10:11, Bruce Richardson:
> > On Tue, Dec 19, 2023 at 12:17:37PM -0800, Tyler Retzlaff wrote:
> > > rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> > > DESTDIR to be usable.
> 
> Why other files don't need to be exported as well?

after reviewing all other files it was found that only sched.h is being
included by an installed / public header. all other headers in
windows/include are used internally only.
> 
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > ---
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> That's a fix which may need to be backported.

found the commit that added sched.h and added a Fixes tag.

thanks!
diff mbox series

Patch

diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index 5fb1962..e985a77 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -6,4 +6,5 @@  includes += include_directories('.')
 headers += files(
         'rte_os.h',
         'rte_windows.h',
+        'sched.h',
 )