From patchwork Thu Feb 29 19:53:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 137537 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDA6D43BAB; Thu, 29 Feb 2024 20:55:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EC454328F; Thu, 29 Feb 2024 20:54:35 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1EF8642DBD for ; Thu, 29 Feb 2024 20:53:57 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 2298C20B74D5; Thu, 29 Feb 2024 11:53:55 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2298C20B74D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1709236436; bh=uD7RuhFP/vudMb3PWhGP4UKJ+4+N9z+oaNod5tFDSz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oN5s6dR3X04bHZsZFEGaHR5LF1mbDj9CAoZx66PnZT+Rh96mjZvUIFAmqJQgaPf+9 Jc/3epsKYo5rC/DP/9Grwerm4tLeumDegi5jkfQL339hhHG8xqsx1gFtVEjszaxzpp 9+deQe1yzHf6i6y6cBRE7uRTe+qkbug1A3swlOOY= From: Tyler Retzlaff To: dev@dpdk.org Cc: Anatoly Burakov , Ashish Gupta , Chenbo Xia , Cristian Dumitrescu , David Hunt , Fan Zhang , Hemant Agrawal , Honnappa Nagarahalli , Jasvinder Singh , Jerin Jacob , Konstantin Ananyev , Maxime Coquelin , Reshma Pattan , Sachin Saxena , Sivaprasad Tummala , Srikanth Yalavarthi , Stephen Hemminger , Sunil Kumar Kori , bruce.richardson@intel.com, mb@smartsharesystems.com, thomas@monjalon.net, Tyler Retzlaff Subject: [PATCH v4 21/22] node: stop using variadic argument pack extension Date: Thu, 29 Feb 2024 11:53:52 -0800 Message-Id: <1709236433-15428-22-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com> References: <1707774557-16012-1-git-send-email-roretzla@linux.microsoft.com> <1709236433-15428-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/node/node_private.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/node/node_private.h b/lib/node/node_private.h index 2b9bad1..3498b15 100644 --- a/lib/node/node_private.h +++ b/lib/node/node_private.h @@ -16,10 +16,8 @@ #define RTE_LOGTYPE_NODE rte_node_logtype #define NODE_LOG(level, node_name, ...) \ - RTE_LOG_LINE(level, NODE, \ - RTE_FMT("%s: %s():%u " RTE_FMT_HEAD(__VA_ARGS__ ,), \ - node_name, __func__, __LINE__, \ - RTE_FMT_TAIL(__VA_ARGS__ ,))) + RTE_LOG_LINE_PREFIX(level, NODE, "%s: %s():%u ", \ + node_name RTE_LOG_COMMA __func__ RTE_LOG_COMMA __LINE__, __VA_ARGS__) #define node_err(node_name, ...) NODE_LOG(ERR, node_name, __VA_ARGS__) #define node_info(node_name, ...) NODE_LOG(INFO, node_name, __VA_ARGS__)