From patchwork Wed Mar 20 15:37:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 138536 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B31C43D05; Wed, 20 Mar 2024 16:43:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3FF442E52; Wed, 20 Mar 2024 16:39:20 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4BF4C42D7A for ; Wed, 20 Mar 2024 16:38:34 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 06F6F20B9C37; Wed, 20 Mar 2024 08:38:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 06F6F20B9C37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1710949104; bh=nVy1cBTgjdPcd43KAYDHM/dJBYE3Bfj93dkVneo1D2w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jwn81nqFklMkBplAIO9kkhPsXT2fQ5hp50j1y/+H8VhgPgIhOLIJkwM+8w+34wtki q9/Oql24WGF0+KmhKmO9vIUNBq7S07pmxds9588dnM4XSN3Xdh6vwzVzRME/uuQ3eP BY+2Wme7mwqaorBwsnGvAhD6+/Rngpkp0Gh+aLgU= From: Tyler Retzlaff To: dev@dpdk.org Cc: =?utf-8?q?Mattias_R=C3=B6nnblom?= , "Min Hu (Connor)" , =?utf-8?q?Morten_Br=C3=B8rup?= , Abdullah Sevincer , Ajit Khaparde , Akhil Goyal , Alok Prasad , Amit Bernstein , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Ankur Dwivedi , Anoob Joseph , Ashish Gupta , Ashwin Sekhar T K , Bruce Richardson , Byron Marohn , Chaoyong He , Chas Williams , Chenbo Xia , Chengwen Feng , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Fan Zhang , Gagandeep Singh , Guoyang Zhou , Harman Kalra , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Hyong Youb Kim , Jakub Grajciar , Jerin Jacob , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , John Daley , John Miller , Joyce Kong , Junfeng Guo , Kai Ji , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Lee Daly , Liang Ma , Liron Himi , Long Li , Maciej Czekaj , Matan Azrad , Matt Peters , Maxime Coquelin , Michael Shamis , Nagadheeraj Rottela , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pablo de Lara , Pavan Nikhilesh , Peter Mccarthy , Radu Nicolau , Rahul Lakkireddy , Rakesh Kudurumalla , Raveendra Padasalagi , Reshma Pattan , Ron Beider , Ruifeng Wang , Sachin Saxena , Selwin Sebastian , Shai Brandes , Shepard Siegel , Shijith Thotton , Sivaprasad Tummala , Somnath Kotur , Srikanth Yalavarthi , Stephen Hemminger , Steven Webster , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Sunila Sahu , Tejasree Kondoj , Viacheslav Ovsiienko , Vikas Gupta , Volodymyr Fialko , Wajeeh Atrash , Wisam Jaddo , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Zhangfei Gao , Zhirun Yan , Ziyang Xuan , Tyler Retzlaff Subject: [PATCH 45/83] event/dlb2: move alignment attribute on types Date: Wed, 20 Mar 2024 08:37:38 -0700 Message-Id: <1710949096-5786-46-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Move location of __rte_aligned(a) to new conventional location. The new placement between {struct,union} and the tag allows the desired alignment to be imparted on the type regardless of the toolchain being used for both C and C++. Additionally, it avoids confusion by Doxygen when generating documentation. Signed-off-by: Tyler Retzlaff --- drivers/event/dlb2/dlb2_priv.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/event/dlb2/dlb2_priv.h b/drivers/event/dlb2/dlb2_priv.h index 31a3bee..49f1c66 100644 --- a/drivers/event/dlb2/dlb2_priv.h +++ b/drivers/event/dlb2/dlb2_priv.h @@ -429,13 +429,13 @@ enum dlb2_cos { DLB2_COS_NUM_VALS }; -struct dlb2_hw_dev { +struct __rte_cache_aligned dlb2_hw_dev { struct dlb2_config cfg; struct dlb2_hw_resource_info info; void *pf_dev; /* opaque pointer to PF PMD dev (struct dlb2_dev) */ uint32_t domain_id; rte_spinlock_t resource_lock; /* for MP support */ -} __rte_cache_aligned; +}; /* End HW related defines and structs */ @@ -516,13 +516,13 @@ struct dlb2_port_stats { struct dlb2_queue_stats queue[DLB2_MAX_NUM_QUEUES_ALL]; }; -struct dlb2_eventdev_port { +struct __rte_cache_aligned dlb2_eventdev_port { struct dlb2_port qm_port; /* hw specific data structure */ struct rte_event_port_conf conf; /* user-supplied configuration */ uint16_t inflight_credits; /* num credits this port has right now */ uint16_t credit_update_quanta; struct dlb2_eventdev *dlb2; /* backlink optimization */ - struct dlb2_port_stats stats __rte_cache_aligned; + alignas(RTE_CACHE_LINE_SIZE) struct dlb2_port_stats stats; struct dlb2_event_queue_link link[DLB2_MAX_NUM_QIDS_PER_LDB_CQ]; int num_links; uint32_t id; /* port id */ @@ -539,7 +539,7 @@ struct dlb2_eventdev_port { uint8_t implicit_release; /* release events before dequeuing */ uint32_t cq_weight; /* DLB2.5 and above ldb ports only */ int cos_id; /*ldb port class of service */ -} __rte_cache_aligned; +}; struct dlb2_queue { uint32_t num_qid_inflights; /* User config */ @@ -624,14 +624,14 @@ struct dlb2_eventdev { uint16_t max_ldb_credits; uint16_t max_dir_credits; /* use __atomic builtins */ /* shared hw cred */ - uint32_t ldb_credit_pool __rte_cache_aligned; + alignas(RTE_CACHE_LINE_SIZE) uint32_t ldb_credit_pool; /* use __atomic builtins */ /* shared hw cred */ - uint32_t dir_credit_pool __rte_cache_aligned; + alignas(RTE_CACHE_LINE_SIZE) uint32_t dir_credit_pool; }; struct { uint16_t max_credits; /* use __atomic builtins */ /* shared hw cred */ - uint32_t credit_pool __rte_cache_aligned; + alignas(RTE_CACHE_LINE_SIZE) uint32_t credit_pool; }; }; uint32_t cos_ports[DLB2_COS_NUM_VALS]; /* total ldb ports in each class */