[dpdk-dev,3/8] driver/virtio:add vhost TX offload support capability in virtio-net

Message ID 1ED644BD7E0A5F4091CF203DAFB8E4CC22BC533F@SHSMSX101.ccr.corp.intel.com (mailing list archive)
State Not Applicable, archived
Headers

Commit Message

Jijiang Liu Oct. 30, 2015, 8:15 a.m. UTC
  From: David Marchand [mailto:david.marchand@6wind.com]

Sent: Thursday, October 29, 2015 8:45 PM
To: Liu, Jijiang
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net

Hello Jijiang,

On Wed, Oct 21, 2015 at 6:46 AM, Jijiang Liu <jijiang.liu@intel.com<mailto:jijiang.liu@intel.com>> wrote:
Add vhost TX checksum and TSO capabilities in virtio-net lib.

Signed-off-by: Jijiang Liu <jijiang.liu@intel.com<mailto:jijiang.liu@intel.com>>

---
 drivers/net/virtio/virtio_ethdev.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)


--
David Marchand

You meant that I should update the tx offload capabilities in the virtio_dev_info_get() function, correct?
  

Patch

diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h
index 9026d42..6ee95c6 100644
--- a/drivers/net/virtio/virtio_ethdev.h
+++ b/drivers/net/virtio/virtio_ethdev.h
@@ -64,7 +64,10 @@ 
         1u << VIRTIO_NET_F_CTRL_VQ       |     \
         1u << VIRTIO_NET_F_CTRL_RX       |     \
         1u << VIRTIO_NET_F_CTRL_VLAN     |     \
-        1u << VIRTIO_NET_F_MRG_RXBUF)
+        1u << VIRTIO_NET_F_MRG_RXBUF     |     \
+        1u << VIRTIO_NET_F_HOST_TSO4     |     \
+        1u << VIRTIO_NET_F_HOST_TSO6     |     \
+        1u << VIRTIO_NET_F_CSUM)

You did not update tx offload capabilities field in dev_info.