From patchwork Fri Oct 30 08:15:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jijiang Liu X-Patchwork-Id: 8336 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 128F08E7B; Fri, 30 Oct 2015 09:16:51 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2306F8E78 for ; Fri, 30 Oct 2015 09:16:48 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 30 Oct 2015 01:16:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,217,1444719600"; d="scan'208,217";a="822969642" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2015 01:16:47 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 30 Oct 2015 01:16:09 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by shsmsx102.ccr.corp.intel.com ([169.254.2.253]) with mapi id 14.03.0248.002; Fri, 30 Oct 2015 16:15:52 +0800 From: "Liu, Jijiang" To: David Marchand Thread-Topic: [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net Thread-Index: AQHRC7uOBMEbeN83IUaWLwALO2Gm5p6B8YmAgAHMivA= Date: Fri, 30 Oct 2015 08:15:52 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BC533F@SHSMSX101.ccr.corp.intel.com> References: <1445402801-27806-1-git-send-email-jijiang.liu@intel.com> <1445402801-27806-4-git-send-email-jijiang.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: David Marchand [mailto:david.marchand@6wind.com] Sent: Thursday, October 29, 2015 8:45 PM To: Liu, Jijiang Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net Hello Jijiang, On Wed, Oct 21, 2015 at 6:46 AM, Jijiang Liu > wrote: Add vhost TX checksum and TSO capabilities in virtio-net lib. Signed-off-by: Jijiang Liu > --- drivers/net/virtio/virtio_ethdev.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) -- David Marchand You meant that I should update the tx offload capabilities in the virtio_dev_info_get() function, correct? diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 9026d42..6ee95c6 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -64,7 +64,10 @@ 1u << VIRTIO_NET_F_CTRL_VQ | \ 1u << VIRTIO_NET_F_CTRL_RX | \ 1u << VIRTIO_NET_F_CTRL_VLAN | \ - 1u << VIRTIO_NET_F_MRG_RXBUF) + 1u << VIRTIO_NET_F_MRG_RXBUF | \ + 1u << VIRTIO_NET_F_HOST_TSO4 | \ + 1u << VIRTIO_NET_F_HOST_TSO6 | \ + 1u << VIRTIO_NET_F_CSUM) You did not update tx offload capabilities field in dev_info.