TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

Message ID 1c1df455cdb640c9889d359186d38637@huawei.com (mailing list archive)
State Changes Requested
Delegated to: Thomas Monjalon
Headers
Series TCP data length is incorrectly calculated in the gro_tcp4_reassemble function. |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-testing warning apply patch failure

Commit Message

jiangheng (G) Sept. 28, 2022, 2:10 p.m. UTC
  Hello:
In gro_tcp4_reassemble function, tcp data len is calculated:
tcp_dl = pkt->pkt_len - hdr_len;
https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232

if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is incorrectly calculated. this will result the wrong data length after gro.
  

Comments

Stephen Hemminger Oct. 31, 2023, 6:55 p.m. UTC | #1
On Wed, 28 Sep 2022 14:10:52 +0000
"jiangheng (G)" <jiangheng14@huawei.com> wrote:

> Hello:
> In gro_tcp4_reassemble function, tcp data len is calculated:
> tcp_dl = pkt->pkt_len - hdr_len;
> https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232
> 
> if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is incorrectly calculated. this will result the wrong data length after gro.
> 
> diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c
> index 7498c66141..cbba9fed5e 100644
> --- a/lib/gro/gro_tcp4.c
> +++ b/lib/gro/gro_tcp4.c
> @@ -229,7 +229,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
>          * Don't process the packet whose payload length is less than or
>          * equal to 0.
>          */
> -       tcp_dl = pkt->pkt_len - hdr_len;
> +       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
>         if (tcp_dl <= 0)
>                 return -1;

Yes, this patch looks correct. But it is not formatted correctly as reported
by checkpatch.
	1. DPDK uses tab character for indent
	2. Commit messages are supposed to be wrapped and not long lines

Could you resubmit?
  
jiangheng (G) Nov. 1, 2023, 1:12 a.m. UTC | #2
Hi:
This issue has been fixed:
https://github.com/DPDK/dpdk/commit/b8a55871d5af6f5b8694b1cb5eacbc629734e403 
https://github.com/DPDK/dpdk/commit/72f51b097a71fb9bdea13bdd254ff620b34c852e


-----邮件原件-----
发件人: Stephen Hemminger <stephen@networkplumber.org> 
发送时间: 2023年11月1日 2:56
收件人: jiangheng (G) <jiangheng14@huawei.com>
抄送: dev@dpdk.org
主题: Re: [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

On Wed, 28 Sep 2022 14:10:52 +0000
"jiangheng (G)" <jiangheng14@huawei.com> wrote:

> Hello:
> In gro_tcp4_reassemble function, tcp data len is calculated:
> tcp_dl = pkt->pkt_len - hdr_len;
> https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232
> 
> if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is incorrectly calculated. this will result the wrong data length after gro.
> 
> diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c index 
> 7498c66141..cbba9fed5e 100644
> --- a/lib/gro/gro_tcp4.c
> +++ b/lib/gro/gro_tcp4.c
> @@ -229,7 +229,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
>          * Don't process the packet whose payload length is less than or
>          * equal to 0.
>          */
> -       tcp_dl = pkt->pkt_len - hdr_len;
> +       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
>         if (tcp_dl <= 0)
>                 return -1;

Yes, this patch looks correct. But it is not formatted correctly as reported by checkpatch.
	1. DPDK uses tab character for indent
	2. Commit messages are supposed to be wrapped and not long lines

Could you resubmit?
  

Patch

diff --git a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c
index 7498c66141..cbba9fed5e 100644
--- a/lib/gro/gro_tcp4.c
+++ b/lib/gro/gro_tcp4.c
@@ -229,7 +229,7 @@  gro_tcp4_reassemble(struct rte_mbuf *pkt,
         * Don't process the packet whose payload length is less than or
         * equal to 0.
         */
-       tcp_dl = pkt->pkt_len - hdr_len;
+       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
        if (tcp_dl <= 0)
                return -1;