From patchwork Sun Sep 11 09:59:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt X-Patchwork-Id: 15759 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 72A8C2C17; Sun, 11 Sep 2016 11:59:26 +0200 (CEST) Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 17CB52C07 for ; Sun, 11 Sep 2016 11:59:25 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id g202so6515328pfb.1 for ; Sun, 11 Sep 2016 02:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SKSOhq8VOQAigiezIqTkUI7L7dqId29o+nGAgU0PrsI=; b=QylB4xrIRaMKyyoLSjQKlkj3dE9DOI9bt6iiD/JDzmlQr0JWx3Qk8XYUs5jDmJcxvM 8GJ1ABKRSaUw+PInapUTbjpfcWafL/94RBrE7MfVwEAPmqHyGiUduIjJauwIaAjfM7ci vtsLVHY3CVw1NEC/ubJOdo3ur7OP5nX02ntVWDwaHvaqhk6OQzYHNAcoEUZvc8mcoSdu UIbId4JU3Rh0yXs9b/WM8SunnURAA5WouNNh+YCWlSjNLXrw5uM9m+DUFt5oksIwClTm ExfyAvUF77fAUyQkfx2V8EwvqtVSqcA3ZXP+QJ3cCa6Yoq8e0RmLnVHh/7dngVDmJUUf UC1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SKSOhq8VOQAigiezIqTkUI7L7dqId29o+nGAgU0PrsI=; b=Tn7oO7H9OGzTHrLcY+8NJ3sRt+PxXvye6MXj9piG7L1BocEf6cerays5Zkujh6m3QR QY1VeDs87yeh9pQvELh+o2JLUoZpcePxNyCPISKq4MpxbHfvf5uZZo9HCEurXJGKAaWy OsvEjzoXyKM+y2cr9UixxL9frUEt5QqSEBvot4iI+N1/bdD92Flp6o6uawcwDYCPStxq SFkF26eJscLxIrbFkupCaRUPJk+6VLKDuojx2M20xLzhc44Vz2WdCgcEbkAB9y3ljn2o Fn8bqHfhqCqOcXVedytpGRvk8Y/Nfg6FoWNDbqm1/uCyWuFwrZGAUpGiyAceNWQEHzoZ hBrA== X-Gm-Message-State: AE9vXwME4MgtNxf44veSvUK/8/GSOT12d4PuQn44YkVErOMBmzfSfdGff+C5OI4aQoJ+/A== X-Received: by 10.98.77.70 with SMTP id a67mr22789323pfb.151.1473587964445; Sun, 11 Sep 2016 02:59:24 -0700 (PDT) Received: from localhost.localdomain ([175.25.175.116]) by smtp.gmail.com with ESMTPSA id 10sm15607438paq.20.2016.09.11.02.59.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Sep 2016 02:59:23 -0700 (PDT) From: zhouyangchao To: ferruh.yigit@intel.com Cc: dev@dpdk.org, zhouyangchao Date: Sun, 11 Sep 2016 17:59:23 +0800 Message-Id: <20160911095923.7923-1-zhouyates@gmail.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: References: Subject: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Signed-off-by: zhouyangchao Acked-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/kni_misc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 67e9b7d..5c58a83 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c @@ -545,7 +545,9 @@ kni_ioctl_create(struct net *net, if (ret) { KNI_ERR("error %i registering device \"%s\"\n", ret, dev_info.name); + kni->net_dev = NULL; kni_dev_remove(kni); + free_netdev(net_dev); return -ENODEV; }