From patchwork Thu Feb 9 14:29:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 20318 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id DAD77FA73; Thu, 9 Feb 2017 15:31:20 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 047D5F976 for ; Thu, 9 Feb 2017 15:30:26 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 73457C04BD25; Thu, 9 Feb 2017 14:30:26 +0000 (UTC) Received: from dhcp-25-97.bos.redhat.com (unknown [10.10.123.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id DA1216E909; Thu, 9 Feb 2017 14:30:24 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Date: Thu, 9 Feb 2017 09:29:49 -0500 Message-Id: <20170209142953.8167-22-aconole@redhat.com> In-Reply-To: <20170209142953.8167-1-aconole@redhat.com> References: <20170208185142.28678-1-aconole@redhat.com> <20170209142953.8167-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 09 Feb 2017 14:30:26 +0000 (UTC) Subject: [dpdk-dev] [PATCH v3 21/25] eal: do not panic on failed PCI probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It may even be possible to simply log the error and continue on letting the user check the logs and restart the application when things are failed. Signed-off-by: Aaron Conole --- lib/librte_eal/linuxapp/eal/eal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 31a5986..3458d41 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -938,8 +938,11 @@ rte_eal_init(int argc, char **argv) rte_panic("Cannot probe devices\n"); /* Probe & Initialize PCI devices */ - if (rte_eal_pci_probe()) - rte_panic("Cannot probe PCI\n"); + if (rte_eal_pci_probe()) { + RTE_LOG(ERR, EAL, "Cannot probe PCI\n"); + rte_errno = ENOTSUP; + return -1; + } if (rte_eal_dev_init() < 0) rte_panic("Cannot init pmd devices\n");