From patchwork Fri Apr 28 06:49:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 23987 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id DDBF62C18; Fri, 28 Apr 2017 08:50:43 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B4A892935 for ; Fri, 28 Apr 2017 08:50:42 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 23:50:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.37,387,1488873600"; d="scan'208"; a="1141185534" Received: from sivswdev02.ir.intel.com ([10.237.217.46]) by fmsmga001.fm.intel.com with ESMTP; 27 Apr 2017 23:50:38 -0700 From: Ferruh Yigit To: Allain Legacy ; Matt Peters Cc: dev@dpdk.org, Ferruh Yigit Date: Fri, 28 Apr 2017 07:49:03 +0100 Message-Id: <20170428064903.19286-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.8.4 Subject: [dpdk-dev] [PATCH] net/avp: fix interrupt migration check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bitwise OR within if statement is always true, fix bitwise operator. Coverity issue: 1423906 Fixes: 82e140b84995 ("net/avp: handle interrupt migration") Signed-off-by: Ferruh Yigit Acked-by: Allain Legacy --- drivers/net/avp/avp_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/avp/avp_ethdev.c b/drivers/net/avp/avp_ethdev.c index 9ca2786..fe6849f 100644 --- a/drivers/net/avp/avp_ethdev.c +++ b/drivers/net/avp/avp_ethdev.c @@ -712,7 +712,7 @@ avp_dev_interrupt_handler(void *data) RTE_PTR_ADD(registers, RTE_AVP_INTERRUPT_STATUS_OFFSET)); - if (status | RTE_AVP_MIGRATION_INTERRUPT_MASK) { + if (status & RTE_AVP_MIGRATION_INTERRUPT_MASK) { /* handle interrupt based on current status */ value = AVP_READ32( RTE_PTR_ADD(registers,