From patchwork Wed May 10 17:30:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 24206 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 84E022952; Wed, 10 May 2017 19:30:40 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0066.outbound.protection.outlook.com [104.47.0.66]) by dpdk.org (Postfix) with ESMTP id 17BCCF72; Wed, 10 May 2017 19:30:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FHjmVAR4/weMatcYYPQ08MrJlnixyLs6r/q0RlA1mUA=; b=b0BDCG1dYEjXCEhF8l9ieERFBUFYtepvKVR3gvRknZ3TIvVSIuO8Xhkj7oY0+yxDg0vhIIhAVYewOjeKM2n8f/DEcfzOyVvnYFcbj6EgPHQm77IHhQhto65PadS5l2vv+5rjW2MlI3ucSIBEaL/6Qs7eUSV6MV1IgeKg5wICFjg= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (12.250.235.110) by VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Wed, 10 May 2017 17:30:32 +0000 From: Yongseok Koh To: CC: , , , Yongseok Koh , Date: Wed, 10 May 2017 10:30:16 -0700 Message-ID: <20170510173016.7989-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: CY4PR13CA0028.namprd13.prod.outlook.com (10.173.156.142) To VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89564d97-09e7-42de-eae5-08d497ca437b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:rD4hN8mJXnde4dOie6rftxqGS2aDJraVpNbwXKWe7gU4s+iyNcw9oH4+cuumiwIYd1M1B791cz6jGc7HC/oAF0dbtG5OHUC5LBz2FX1YGdCqsZFUmMnlyx5Mvn13WLTU0mAMj1eGFSqrGCWRIIdwOxG1+aGzJBk4OCX7BYkzepPcq5PYzklXVdmjzYPonB3b1o1xKp0DO/IJtZnOpetNg8JG8gL5IlNvQAF1i+9A5YKjUQ7syObMxDtdURKWuuMfIyyjceOt24oOtzotEe+aQs2x+SDfA+btGaJdwlVlxjCYzzeTClf8fCtQQeCBQdWfW2b4sdU3R23/DVi15XWQhWI5PT8EqQ89a6gbPcjQ1PQ=; 25:nJ9q1jVDSCUukmN4TlIV2fr1Y1XbzfYCfGo+49B3r3NOtzr0Cdd4rb2CxsJG78BHNqu/Q33QbZ0WevCnZMpxN2Mecm9qY2wp+oGGRHKGDnVvnLrf8/CDJLtHiDoFKy9L9XvnBYHPEHmB59xseN7QLNNnXG8iNSmeJBGz2j9hF+CyDJ8pEl1ip1ioz22UwyZYxZ3hugIh0MTCvHuoSv89kknfEVJXW1Xr2wbMmq1F9HxL735YGgK8nzq9d2JwJ84PL8qQs5NyNmePYWmWXHanVa0H5O4FLOv8ERPf/fZxJoVA12+comIhC6T4JRMq+xOaupT7zZ73m4rl354dlm/2uR5odDT7wrkBn03lxRA2rPOqDRy9JM62rF/vTNbDvta79+cFt+j43zPHR1L+5R6O56ebxv37PFos6kvF1HOHWN4zEztxJ95Ilfopk3eTGomCgpLR9lywQ8tGbnfM+jxqjC74GrT6XzWsY0MFLsPg/ZM= X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 31:7ytD4Jx0zsTTQAMFq3gf7mbhgwj0Ex/1aM+ks8/c/s9td7mIxoQOfhYV0kwmeWBK67eojc8a4lpp03yzbbgHUusrP3Cxxu14WY8iV5xKcW9Uxrw4IHYAUnLWN4KFwDSbGi3V6M5EVV0TiWaNTsZy6ljI84PjhPmD63Bdiei61BefnYl4m1rcNVesYI5NOkm7HiBF0ypLsD/gp7RiAfhbbKddTo+6bujMZbwwfoMooNeXGibpc6RPyD5VovAMgSFi; 20:uBhSRhgq7R+HNcPUExkz3QOrZjP7N5YcnSYeSwQJ/ZL47ZcqhTyICCCbWz+n3H+WbvMvCzXhWZTOjcMHi3767FRprNoGOUf4x52FnbDA/4SSyCvsLBWn9kVNGUB3TvmAONkm0w7OphqriokRIc6mrU18O6iUQbLFjJknPKhoAIyaGNRO05eghrk96oUfy9QYKVi6WrqqjSpWFjS0CQVHMGiiqgLiXyFmZDgs/CkOy+m7AFucWWtR6hBm0Tr87dznKcbYjmI9TMgKGJ/WuwoZT8xYQPI4gfaGzUx8ZBD44khLSKOSJdEaFwUvSzARfUEz/wrmWNU0rgQTs0fd2RYdoAzLdYtwglQIZkfe2U9RribVSP7LDyQUfVODHL4VYMLkVfYwCnJ6YqVMm+tUKoH/UMQcbM1Q3GbtqBu3cDfJCYd9CjZmAq4fmFN8DP6TZ5GseU80M3X7Pjl6aWM28Wclzi0VVi6R47tJ4keCvLOEhD0ieNLlWq2XqyqEpgEKd/ZV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(6072148); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 4:0AjIDWpVpviRL7ZW4obzVxPCI29c7P9NoQDeV1bLtxyBDuuflnqM62rgVKWM0nhUNljfVaTYSLHLtLLSJ5o6VlFZsjbMy/oM7a+Zav3rnY3aQIYYnKlqetjbBinf60eI5fp69D1e+soOjMixs8zwsObXh3hNaikqNNs58QnlOS8R3MAo6K1wMN2HORkxBoGna7gJcu74dAlUDsrjA4qbFpjlYrSKCVY6cUT1J5sVyMC2L5YYed/A+Sm8QTiLfqkWjqShvYC7ihRZ5m4Teu3z2kIKiY2zjgK8ZQB/WWFbQwsoLcEu8K51psU7YYSXk+XkCu+YbiMWUg1SFsUcjWfllQOLeekJpW6lEVifYdrc6iJgRCASZR22UwJysMJp21Wzc4/8M5ZjNT/hshRTvbRgw60s8zh9JApxG8I5GWx7O5SpT2rZ3yLw90/U3j1tLz9MwjyayWd9fWVR8wLPhcL1zdH668eAYTcsyupsh1xAnZNjJPp+kYl+N/3orsnOelm7Q7gvA9B+Do3aFjvRHB7wAAdsZw62UE6GWfycg+Ij/I+qOGv6BXQahJoCitT9R5wpEGkIJT9PALlK/jMzRPZptXyZEfRjJcxCgDMetLFddLe4tEfwCmqJSXlzTRBDsNXBLduC5ZVk+bFKtrBbDJUb3mMPDwDztG6fCYoTfD1N024Y6w3PeyTdQKensk4b9WQ2VlH+DvaVgqpRd2bFPVLV00OyLKemOM4gKh21YvK1CUfRxq+5EWDNZLIQYOkxfgSw9i8vMeHrdQlp/H1cvdV5AD0WBknFnJV1aylf+lnPLz6EoowJQti8p9JM8CQgN8ul X-Forefront-PRVS: 03030B9493 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39400400002)(39450400003)(39410400002)(39860400002)(39850400002)(6666003)(5003940100001)(2906002)(8676002)(54906002)(6916009)(86362001)(189998001)(81166006)(5660300001)(50226002)(55016002)(4326008)(2351001)(33646002)(66066001)(47776003)(50986999)(478600001)(36756003)(25786009)(42186005)(1076002)(305945005)(7736002)(50466002)(48376002)(53936002)(6116002)(3846002)(33026002)(38730400002)(110136004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:nF3VGWI4ue3eGDRpI/QlXWPnfvWMkXfdBzGqhHP?= M1fgRHCuUKljecOhFzHC4PkQVhq60v1qeSUa+JYlPpLiFAkMX49gn2jde99sJnVau/lJmu8HSmkPeZndw+4tOQAl0vQXFqDuB98uBSQpODIjPAicyztLFnYP2QvwbOcufBU6SDtE0/l3uplyvG+8HoRp6ZQ/4Y/M4uNtCh5Y101n8coaedjqckbthcTeGk+lgeZS0ijjqo3ACF5xyPk69YeuPcaHRiAKSdiJs5cmZQ6RnN88frl8uHRfHvZaS4bY/aKTqoHSvzhMXoc1dFFZOgoT2jlk5i2PAgqw+jtretzozyH8qxuSDyUKJBXhGR1gv38E9lbpR6faP/8cPsVsp4Kdgm2eoKs+xFoHXTZBp3J85VWvn6FVf+ai+aYGKaBFrtnnkb1iDEaBnkQaPXW5M8BUf7FDyrWpJ+l/pRvZLN7gjdVZF3Idc0tm2yiUHYYKYwxy8EsEcDaU5mua3TzTklTz+xwGxKQ4yf7bAo4xkfQUfJJU+WNOjPUOVeAZtGzyxsejsT0pvhvkA4KZyvasiyWd7hgAiuwvk7/vMOD3oo5zQTmqnNxcNjmHJg2TtaImMxXMvfdMmIH+1eVyQf5kaQKlGLWuQuJEqOWdTfgJtSIZZjsT6CvCFqcfOvtd31DrkX+TSL8tSJg2pzeJLpEQCJ40p34dlDIjKG+VWJAbEfAH1aaJ5X4iOuIhsZWYPgO1Ep2g8PgR3KwIbR507DQlx62/+kqyGOruH2VZSg6XDKXua9J3g/ReQJ2/bsRFYTAzyl9s5+yX6ueiDAZCvRBV+DruJqU8CYlSIzfFkh+95Ex7whuJQDfTdnVs2B53IRRw94MhyHiKXFLU9tWeXKow0sICN5CQEf/dbwbxxvtnGMl3kbfkxhAct3fL98/asvjYTlL20kOX30atf1M0YfPWyFmr/uZn57sMk5fVyQJeU53g7ngCqMX5QYFhNJxF4rfNK0C8RxEES/zy5AG5DRY4w5K00BJvj/pKjwD86IeZTQqWgJrTYs2ik2LlnPzezaqOsHww= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:c6nxXmOGXIllywbao+qbcJSnBxesIfyIhUuiUTjJabWTMvS0tLIlJgYqhyosNZwdBuu4RQOn01SGBpS3YGXkxXce9ZOFMuJpWpk7moMi9S5f8i0Nh3Phf72k1kOOTuRgst/d5JQrFLH3CNlI4PpCWrQzAxz3ItCvvzGmn/xw78zA4GRgqdM8HZI7z7vkW9RTLFhBHl/WdOhTlOigJ5JaUjdvCEJgD0W85bm2QA/m43mow1EUcTDZxXyukbUguPFUgEcBXjKt8iVmx5r974H6RqKOZbWbjgX6ptB5Cswu9hBo4FjPQxJv2aA+1+zHYsDhCuxYsoJyxpJeq7XtCNyoyQNBa1uoRKDR8m2NEVDrIkQWYO0HVMxyO7Rxdjg+7fE/DSPGR1VBmedpXq+GHaskK15EOMbN2w88rFfoPDJetJuMiS/AYBaD7/nT4bXgWCwTnahB6wzOpc2sZ3HQzZCqu0l0pkOnMjR71PTk2mshCi39h5bMK+b6TYLOrVy62Y4BtqA0e1gPXO5WL3cgasCsvvdRXWVjDlBK57QwQy11ZT0=; 5:dLqoltL0i0v85wGMNTWf8iziwRDiVq1tw5xcRt279t0p0WEjfsmqVvVJZhUHphBK0p+EUyZ8YhQkhkSlQvsXsu5Ly4yBVq46U+IfUFQuk67Yqg6SJJYLREAeDuH45znQJHrfoGcKIhy4A/J1Tq2e6A==; 24:dqysqhqSHmXODpr21xGvMDs0U+voMJ6tYBXXM6UIMfKS9xVvNgPEwRRWVZy0tXlvspNhAz0PBeUHLwDKH0BbKqlkq8BPbrT1Kih/dZd/QMI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 7:Tkfy5kBZZuJjmABgmlcDE21QU19/wl7ggVIh6qJcpPKZzUApaaiiAMFr1GuWEBO7MvM7tpb7Agsg15Cv1vlw0M/NIA/E7oEQnzo34nQvsG8v0Hr+f9MLO/8AQ5utuW471uW2d8a9Lv/V8oUY+p1fZp4hqsRJqBVEkNwNrcAn/+4MmYJ/iLbWrN08FjUfH15UtHYSEUSVikU+ZsdTXzOxxKloIboimRjDUOO6lZLpJbBtttl87xPvo+C2nlZRkxjeZ8HtmoJqrynt764NbK5pvRT1mfVLYMjxZaFv/HUqWRCLRPvnAV5CmDdIa7bneRvSQ69bpNhO7XFF3hqfYuYW7Q== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2017 17:30:32.2623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-dev] [PATCH] net/mlx5: fix rollback when starting device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In mlx5_dev_start(), the spinlock isn't released when returning error. Fixes: c8d4ee50cc85 ("net/mlx5: fix startup when flow cannot be applied") Cc: stable@dpdk.org Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_trigger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 229b05e79..8c5aa6910 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -109,6 +109,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) priv_mac_addrs_disable(priv); priv_destroy_hash_rxqs(priv); priv_flow_stop(priv); + priv_unlock(priv); return -err; }