From patchwork Wed May 17 14:31:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Lilja X-Patchwork-Id: 24342 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 8D9E73245; Wed, 17 May 2017 16:31:30 +0200 (CEST) Received: from mail01.napatech.com (mail01.napatech.com [188.120.77.121]) by dpdk.org (Postfix) with ESMTP id 150E72986 for ; Wed, 17 May 2017 16:31:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; i=@napatech.com; q=dns/txt; s=mar2017; t=1495031489; x=1526567489; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=ETHmdPxyASEBpJySRUjhZtI52kbM4i6zyhtWqnWEbkE=; b=XG2pLB1tXLgtsjXyUndJxUeVOdp7cx8kQATzzq4+9GUvsozQS7t8wouz 40oHMZazhapj8VUOdb71x+vwqd4kCmgrG224TrFe7DcP5G6tccnVtjLOF qBBMR0A90O9hlvsfhfYmywuZmhVNF2T13spKBcfX6XQAKge0uHjb/Qeq0 SH3JeqPnJrwesv10nWknfYJNAQHTysAJprqzHafQXnlg17KQTPkMVHt0B CNFeSpFC8mBhexLBmS3oqm+1up9CrCQjeA4kUmOExVyoyw7RX9FAZuY5h pg/+ki7hgBEu6CgaZOawe6WDyAHoPm4ZQV0oe0m/4NfaAsClHd6EtDfXC A==; IronPort-PHdr: 9a23:iafHWh0+LEwKFYHzsmDT+DRfVm0co7zxezQtwd8Zse0UL/ad9pjvdHbS+e9qxAeQG96KtLQd1KGJ7ujJYi8p2d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL1LdrWev4jEMBx7xKRR6JvjvGo7Vks+7y/2+94fdbghMhjexe65+IRe5oQjTtsQdnJdvJLs2xhbVuHVDZv5YxXlvJVKdnhb84tm/8Zt++ClOuPwv6tBNX7zic6s3UbJXAjImM3so5MLwrhnMURGP5noHXWoIlBdDHhXI4wv7Xpf1tSv6q/Z91SyHNsD4Ubw4RTKv5LptRRT1iikIKiQ5/XnXhMJukaxVrhGvqRt9zI7ab46aKPt+c7jBfd8GX2dNQtxcWzBdDo66coABD/ABPeFdr4TloFUOrAexBQm2C+zxzj9Dm3n43aw+0+QjCw7NwQstH9cKsHnPqtX6Lr8SXvqpzKbW0TrDb+la1iv66IjNax0sp+yHU7FoccfJ1EUjCxnJgkufpID5JT+Zy/4BvmuU4uZ4SO6jl3Qrpx9+rzWh3Msgl5XFipgUx13A8yhy3Zw7KseiSEFhZN6pCJ5QtyaHOIRoWs4iWGRouDoiyr0BpJ67YDAGyJQ5yB7bbPyKa42I7QjiVOaVOzt4gmhqeKqliBau70ev1u38WtOo31ZNqypJitjMtnYT2BzP8sWLV+dx8l2/1TuAywzf8PxILVo3mKfUM5Ihx6Q/lpsXsUTNBC/2n0D2gbeTdkUg4eWo7f7oYq38qZ+AKYB7lgH+Pr4ylcy4BOQ0KhIOUHSD+eSgyL3j+lX0T6hUgf0oiaTWrYjaKtkYpqKjBA9VyIkjuF6DCGLy0NkcnH9BPlJMfh2vjo71NlWIK/f9W7P311atljhpxvbJeKL8KpTLMnXH1rzmeOAuxVRbzV8WzNtf7p9QQpUAJPD6Ehv0sPTeBwcwLwG/w6DsD9ArhdBWYn6GHqLMaPCailSP/O96e+Q= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2G4AACBXRxZ/1QB8ApcGgEBAQECAQEBAQgBAQEBFQEBAQECAQEBAQgBAQEBhRgHjX6nW4IPHIYIAoYaGAEBAQEBAQEBAQEBAoEQgjMigkQGJ1IQUVcGAQ0FuRQ6iwUBAQEBAQEEAQEBAQEBIgkBhlWBXo1wBYk/B4g5jBGTDoIRj2mJAYtFH4FDLyAIGRWHPnSHW4ENAQEB X-IPAS-Result: A2G4AACBXRxZ/1QB8ApcGgEBAQECAQEBAQgBAQEBFQEBAQECAQEBAQgBAQEBhRgHjX6nW4IPHIYIAoYaGAEBAQEBAQEBAQEBAoEQgjMigkQGJ1IQUVcGAQ0FuRQ6iwUBAQEBAQEEAQEBAQEBIgkBhlWBXo1wBYk/B4g5jBGTDoIRj2mJAYtFH4FDLyAIGRWHPnSHW4ENAQEB Received: from localhost.localdomain (10.243.10.69) by cph-gen-exch02.napatech.com (10.240.1.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 17 May 2017 16:31:27 +0200 From: Michael Lilja To: , CC: , Michael Lilja Date: Wed, 17 May 2017 16:31:20 +0200 Message-ID: <20170517143120.18306-1-ml@napatech.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170517103807.18746-1-ml@napatech.com> References: <20170517103807.18746-1-ml@napatech.com> MIME-Version: 1.0 X-Originating-IP: [10.243.10.69] X-ClientProxiedBy: cph-gen-exch02.napatech.com (10.240.1.84) To cph-gen-exch02.napatech.com (10.240.1.84) Subject: [dpdk-dev] [PATCH v7] net/i40e: improved FDIR programming times X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously, the FDIR programming time is +11ms on i40e. This patch will result in an average programming time of 22usec with a max of 60usec . Signed-off-by: Michael Lilja --- v7: * Code style changes v6: * Fixed code style issues v5: * Reinitialization of "i" inconsistent with original intent v4: * Code style fix v3: * Replaced commit message v2: * Code style fix v1: * Initial version --- --- drivers/net/i40e/i40e_fdir.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 28cc554f5..1192d5831 100644 --- a/drivers/net/i40e/i40e_fdir.c +++ b/drivers/net/i40e/i40e_fdir.c @@ -76,6 +76,7 @@ /* Wait count and interval for fdir filter programming */ #define I40E_FDIR_WAIT_COUNT 10 #define I40E_FDIR_WAIT_INTERVAL_US 1000 +#define I40E_FDIR_MAX_WAIT (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US) /* Wait count and interval for fdir filter flush */ #define I40E_FDIR_FLUSH_RETRY 50 @@ -1295,28 +1296,27 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, /* Update the tx tail register */ rte_wmb(); I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); - - for (i = 0; i < I40E_FDIR_WAIT_COUNT; i++) { - rte_delay_us(I40E_FDIR_WAIT_INTERVAL_US); + for (i = 0; i < I40E_FDIR_MAX_WAIT; i++) { if ((txdp->cmd_type_offset_bsz & rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) == rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) break; + rte_delay_us(1); } - if (i >= I40E_FDIR_WAIT_COUNT) { + if (i >= I40E_FDIR_MAX_WAIT) { PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" " time out to get DD on tx queue."); return -ETIMEDOUT; } /* totally delay 10 ms to check programming status*/ - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * I40E_FDIR_WAIT_INTERVAL_US); - if (i40e_check_fdir_programming_status(rxq) < 0) { - PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" - " programming status reported."); - return -ENOSYS; + for (; i < I40E_FDIR_MAX_WAIT; i++) { + if (i40e_check_fdir_programming_status(rxq) >= 0) + return 0; + rte_delay_us(1); } - - return 0; + PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" + " programming status reported."); + return -ETIMEDOUT; } /*