From patchwork Wed May 31 17:48:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yongseok Koh X-Patchwork-Id: 24906 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 3323D7CE4; Wed, 31 May 2017 19:49:00 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0042.outbound.protection.outlook.com [104.47.0.42]) by dpdk.org (Postfix) with ESMTP id 441F57CE3; Wed, 31 May 2017 19:48:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SiFcm6j0q3bmleXqVGPJE8zoQHCkeBbAVtiHRV+K6oQ=; b=OF4gwl+Wo/HsDm1ZVC4kHAwhajUldfJlcF9bJBNZzcfN9JmmkmOPrSp2R91hGvaKyDT37mxubM/Sv4Co4ZuzTyOd3+MGmJPVMaG98IhvGHKke/LZUyT5+A1ft2l3zubaAUz8B7qQ1ReDoujYDu/CEHWH5iyyVtpyr7MPspM5OV0= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none; intel.com; dmarc=none action=none header.from=mellanox.com; Received: from mellanox.com (12.250.235.110) by VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Wed, 31 May 2017 17:48:56 +0000 From: Yongseok Koh To: CC: , , , Yongseok Koh , Date: Wed, 31 May 2017 10:48:45 -0700 Message-ID: <20170531174845.35951-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Originating-IP: [12.250.235.110] X-ClientProxiedBy: BN6PR16CA0008.namprd16.prod.outlook.com (2603:10b6:404:f5::18) To VI1PR0501MB2045.eurprd05.prod.outlook.com (2603:10a6:800:36::19) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0501MB2045: X-MS-Office365-Filtering-Correlation-Id: 0dc8b0e6-6ac7-4094-931e-08d4a84d5004 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 3:80qU33BMNfzdmVE664bZTah961q3X8tn2gYEnJIkTICSeP07VT/hCsKdFa5p/2q/0E5CQxDiT1HxARa0ZBqs6OfP399cl9M0FbdT3BYQNOtjyrQlB6cothXmkzMHGtQrVVDLVAqBvA8py7Tb1ncSty5DPxDs9ekunUf7InB6x8xymnYia/FpjL8TUA/Ns2gRBBkKvUbTlgwaATHoPo9qUmMVRnwefsiFrOpoiWOs5DoNkuJVtys91Cc55/LoA7ZhRtKRHzwhV3PtmxYNAlKU3kG2UbfXHfitR48iydzJqmF8xlD1tdF+yxQLwKIh+xe87gYCcbvw2AKf76utWF+4euGDSOvO4bG6LOiQwI16G20=; 25:1XBpajvxstj+ODTvpaRdAXevVl1o0V341kMy4ynNLLblSl5TzVH/nfQKWyA8NoilG1mp0/BXWlxGVMmfy9vPyorQjolMQpLdVEtXUtkKYT6fGsNj1sAxh6aRwiGiBMk18fW9iWQsM5vXDt7jfLRZI23nK7UpXf4B3GgOknWEgO1yLMla3pU2qINEfRZgc/x4vvhV66vbJL8WgzoE0h6eI43H+O6g0YDsg3mSYBmEpabE4avwBAiVCJN966DOrdaO2A3d3cfMOpLLEWGPat+FvI5nO+eitRkGHACWLzf9bpxCxbi0T8PSDXkIHZec/aJIZqgcOYjLV++xgnUeebdSxv46qlI6rWxwGY1IbY7oouKyg5RcVDGMxjZ50I0PSeWmJZnL14v4y/QwvABgCLDTbIG2oS3QfPLUcR6EkucmomnkGHsQGV0N/QUcEIOWvEONUOMsjLAw9XbulUp65EfvRYnCQxsTFc+OWUx5FX+148U= X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 31:kX8ItKJJbJagfhr+vZLeGSwa90qujgPXUO4SWEy+rMTRSov8tUluwTyP3tAU63W89IaLL/8+x8snF5RGZRlC1RT12rejpZgyyAThzdV2wJBqppcuG/QsQxPs6ZOgZg96+kkM3VdqFUGXlQjyA6A2xnIDRjr/USF/5B1nR8+UaVdCVJVEjLJy5P5kFA0y5KI0npM1/R/FINMfdRrely5Uaovtomx15qjfKTqik0TyZsA=; 20:wSPnGn+QfUG9Rx67PgWkYg5t3g6ywGznWMBYW2FQPmwkw04rEn5nPArzALeAgDrCZUgG17JQP3oatpebQ8HaCmH/mWEEPOw/Ka6lJuYj9KKP7F9RLFDX6/8PzcN1K59fJ8LKkCit130UW9IMJem8UYi9tWGUOwPbsvo/ac6XTS6PDHnNBckCPGumDqVfAcUC8TVtxwY1GlQN6UsLI71pDrQKG+SSjrs/AMkG36kZodC4gkxzsG8p5RtMHgv13hC3IPKzObZqmEKrQcNCCzrJQ2HngsN3rbruivIVnbNjhgx05Nw7zv5BxKQ9qrGiH1V8Is8oBGjP2xA13HcyyZhlXFXaaZQ+PycxMF2exbOhI6qTWxVIzy5lFlprX/3vYu5JH2FQkmFlc2l3Ny9yME6gQsD+0j5kcE78201ccPiTcJAbQVdvLP55iy73E6EtSi7BLMytaxCsgk/6cgjRHPxUsAMY21qTgda69SPVGBUEwYolsxP6fZ4synKjR31L7MBz X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703073)(100105400095)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(6072148)(100000704073)(100105200095)(100000705073)(100105500095); SRVR:VI1PR0501MB2045; BCL:0; PCL:0; RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095); SRVR:VI1PR0501MB2045; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 4:r06G9SVQOYJtKopOOWy7Yc4ZJfvDttkTbi1CI9Jq?= Guegm+8FEcIWtyWW7aLgb6mbIdghmiDNOKvujqGdTHgdeG/8oWB0QqF3xRgyPkYVVP570fh9QR8wCj/TZJVJQPTSmnetd6bvAw/wgdZxL/QqNNM6/oKOmghY+MfT+Hwja1nx03Wq9CgQJqZSxHn4sAW0SU735cywD5wgxBJCi4LIU8kAv18ha3FcCyIdmW3SnStczIzasjD6QFSiUSmUeLsZ+AF6J0W0RiOKkq1aEgjxVh8CrIBkrzasR+x9TI0tLAX3x0Irb+3wAmKCp/4K+V2VhzYzRaWVz7Kgpm/v/+Gr0CnEQLXg3Dd/h10P+7Z+IqbrlcRgbV9pksKARDY95GJOMGPUZ9MR+RaFrGSweVSM91mE2sfWg6oMyAwV4VUNP7ArL9yrchXdPnbi0fITp6gmJAk3bjQ+lr4WUwMvFF5OfBfKB0Oih8Fug5b9ragK+GmBzC2R+GkhOh3UmV5Pob1wV8zU8fAWOzzybWndtNvfyl/BmdE6olV0L2NGegHvneixZwaxCf/rRVnU8EnW+ZB2LnEkFpt3HRyuLelNLqabZkNgiAX8tqT5qDKaI0TztU2KcWu0JJfn7wXcr6kqcS9/vgZMNCSawHB5gyF4jSAJWboN1qYOIjZRcI6j8awdUwiHB0MDKeNwEyuQwthbGpQSFjqUn2Xjevy2tAmyJo5vnKylhrJPTNGfxujD919l69f7YTypAx+k5DBZZkuDQ5mRh1kKkhmslHyu6yhLD2c1Jxjw/f3ZENeSGQvJZWMzYWcwfzKHN8/T9PGDYFig56oSDoyqgG8TrXabx6ihBrQMPcG6zRZsS3szDEkFWPZyHcuy2k1mikXRjwPjRWdMUIJOtIeSNA0Efp88piD6XoGK5ydIEtJ6eqsg6eqXSJEWkCI23YW9AMWGt++ky3aGlrwGA1w1IpuWFEG30V5WHvrUHZ/uDGJ2B6uSPvdME30BXSRvbQNern4/oaj+vSsAmnvn4PBijOUSSHDvTttIuY4+OcBllQgkq3PjZnrXvTDrGwb5yB92dxnviAC0etBJzK/ec32UIv/wLh7y9qb3hhB9rh5i2yHQAOQiw1yYYxpN1CBDak5bOM52GIivwCD0pQVD7MnuViyTtTcBe51S+DeqbQ== X-Forefront-PRVS: 0324C2C0E2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39850400002)(39400400002)(39860400002)(39410400002)(39840400002)(39450400003)(54906002)(33646002)(38730400002)(110136004)(53936002)(55016002)(2351001)(4326008)(86362001)(6116002)(1076002)(3846002)(478600001)(50466002)(33026002)(50986999)(47776003)(48376002)(66066001)(7736002)(50226002)(8676002)(6666003)(81166006)(42186005)(5660300001)(36756003)(305945005)(5003940100001)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2045; H:mellanox.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2045; 23:KIA9Jghi/FBA3cZAn5rhdomSj+n9libwgFkWKF4?= ibL0CJ+whlSg4HUordSz0YSF3kAVlXDdsZmqngzz14wmp59Db87eQfGYeJkSGUHWGODHRXOhCzk9hm26jhYuY90fznEWvfQjlsfuVTvBy/MJ0lWd1AV4f/CzlXgbdA9a5xlukq1MsM/pU1ygEMhoolGZjWnKTsJgmtZLGGwzc8D4zTYWPKqQwmLfdVPWaP9VKEMS4fCRjDfQCCZt1UyH02FeLL7XaQUi6qL4b8SxbZuJnRcsbBcdAAv6LknNTei3d6B8cfMqrzlOFIRt2t2osTYfg/zfo5iKOuccDE2pYILgJheyjv9Ro0pQ4qpmeAuOdoY9vmauB5EJCEN4B5XNEp6WgT3JEkoyzNiI/EbxmQ5FgPlzy0F7E1ADf6aBKtBx4IOQ8QXnVUg0vWwIuzNt50yDZ/03OgbemSUEpHJaNfKGk6hAUaqSozAsHycukebZd/N6GS52iw9Kk7LkzU3ZjijYwCeTHJ72avhQfU+afoWPp76llT99bsefIiYT9/8TPgmAt/ixPxTOUfgOHsjlh+ldKhzbnYXMgzuuK4ecol5QiQM07tWmPb32rN5BNaHdTMV/kgYbf1QrNh40GuTjuLpTginqmMY/odHojEuJeSd60b/YtY6n7c7P2xd4ak3CsvjfrIze922nfv7UlFWLNONAvjLGQwgRgNoG57sIhrNhMjA+Xje9tFWUAwfZ31lawGTcFviuABWR6tYLg5PeVr467ab/zQEE1CpZtVWvgTeKlx1Art5oxxO0ZYtQxVRcfRdBLTuTW3kg21qMlWfSRf6mnw6Et4qGL9FAl4T/1y+3rPQszdl4glgX1LEn9QiMWCt+Ct60ZRiKZG5M2tO0II4hpBlSIlAIt/uFl0KKDUcqARWF0vVWGOlQV2HQAklw2Eo7AoSZBWltEvjrUZzMiNTNoWHBGVSnJ1lDTunp4OxC1DrqUNeObrAn08EOGJmAq4W8= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 6:1SN8s2CLtsIibnOf+r2MexAYJ8HDJXEOi6HVjvwvQJZtWXhvmCk7EgQuOFTrtBWewr9uS8xZHcCiBOa7a+upzDMYuUoeTeBt/1pGYotZ8xTNdF9rV4VcMZfKg3ULK7vGfXj8FFfEoow+1gcP8q1re5irSsSZTfw/BpUqbakK0zJ4waQMamKbjk3s3LaA8sorf8qcq8feH5T5aS+6xUNa+WHtuuzwlB0KaLrqkroC9zrtc1k/S/+rr+JMU/43Yy/SVm7PV6vhKR390nSapgw1kp/y+Fs+8W2K6zmNL0O5q3fRVbD1+H/uSE+EmXt8pKFtKlitfvkouYK7sxT+Ex1tY+jHl1+oGL5711PKRW2LPEfo0qzrieRhmy06YRmhUHv/nlD22MvwyXR8vi5dJHXaUd+frbOmiZ99tPLyDeezMjkPagRS8rkYaGpkj9gObqbWnx2AWO5enOG+6830qLli7KPmwqKdkMFgKf6iIFVeETPFcHRPONsbiiU5jJ0sQuKIUWNgq/1Cmyv1KrPZCr//erPdnSlBsGcqLiaf/Hy+I9Y= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 5:ROD/Xb39UNZXYu/sVpOXwbGRyFGpf5UGQEEKq3U9ykUFRpPuUJwTiyV2yr8GZljasm+smjIRwzZLeCzCbef6sLqTCVxfGfqx1iaHXt3uYuutQ8nul8hyKqKRUW9JC+diNVbsY2yGIK8Ike7VTYkgQB5qvJuIeOEg9i563mCiwaLh82kj5n3mDhzvuzMYaKVg93jrHtbbgvJasmwnsQmRikMw9IRHBkiYKJvHSVPAEA/xfEL26d8k/aluXB5nGIyb/JPdj0C0ZWBCGXGSEaMV8BZiD2Vb0A0ze5XQei/iIaPlzp6kprJKiEBoyutINiMRy3nrN5JSltfy+KVP/o9+uPFpoZVzzHTtcyrVFfycsHS1DDHGSu1K6gjBjJmSYp5/0f1+MWmiD0+iIgQRxG8J1hmQ/0T6H5r9eF5iCltk5WMtCAxcOMy2ocykg71wlcotBiO5LvAjg0YOztzF66+Q3e3CjiwG2SjaNy2SwL193W96x2z9cL7V/CXQvkxhPYmY; 24:ijwLtz3NvBvl/vXslNjnrGlM2vDIqd6Zo8V1cOZqIvVoCrQmGZdosT4B8drCpi8/+6g9SjJWYN4huBkjc4mqre4++f8U4XxgQesqKgu3MLE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2045; 7:tn7214GE6gLO8brHxa2bzHI3Heg4BifS3FPtbXEcHQfz8LP8heWB2/kLwlM2vw40tUigZyRLWKZlYIIN1LVC5koHEzDhLxqmR4GLN6TOZbjd1zfhHLdg9lIf7j8uDrDTnUEiMmwNofGKpZk4gi+N1ljjBKdD5ZU83QAwiqS6QnFy5AeN6hmnNzlfUS7tJs5g5jQgRzjkdt7UGfK9lNeMVRLUodVb8MKhcxJij9ojJ2ZyA4QARJQWFqG5hJxKCgd3/+FyMyh1lrtCFtS7KByQosnTrMnUPLxoEVq54HNTjG9g5d19xaMDtSUegJQ0TFT8C8twefMlmUfn241iVUxDUQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 17:48:56.1016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2045 Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SW completion ring of Tx (txq->elts) stores individual mbufs even if a multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when cleaning up the completion ring. Otherwise, chained mbufs are redundantly freed and finally it would cause a crash. CC: stable@dpdk.org Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 6c1387e56..bf72468d5 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -117,7 +117,7 @@ txq_free_elts(struct txq_ctrl *txq_ctrl) struct rte_mbuf *elt = (*elts)[elts_tail]; assert(elt != NULL); - rte_pktmbuf_free(elt); + rte_pktmbuf_free_seg(elt); #ifndef NDEBUG /* Poisoning. */ memset(&(*elts)[elts_tail],