From patchwork Fri Jun 2 11:20:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerin Jacob X-Patchwork-Id: 25033 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 0A07F7D3B; Fri, 2 Jun 2017 13:21:27 +0200 (CEST) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0072.outbound.protection.outlook.com [104.47.41.72]) by dpdk.org (Postfix) with ESMTP id D2BFD7D30; Fri, 2 Jun 2017 13:21:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fG7x4bwoOhuJTBFB+Z+wncU1rnkzmmfJWpnjPDq7k8Y=; b=dAjFPTro+leWm0OQrH9aTNp2cfStXRIZdNU2wnfML8oe0KdfxQm+lXyGqM+NAKYOj/MuhHWITRMDtg/oksEqs9HBn3WQmo7awHm7taCHhFrpIPpRSEqn+i/DKNJKPabsbYltte6uOgomwYj2I0TrwaOkZEvd2WtomD2tJGbzgck= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin.caveonetworks.com (111.93.218.67) by BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Fri, 2 Jun 2017 11:21:20 +0000 From: Jerin Jacob To: dev@dpdk.org Cc: bruce.richardson@intel.com, thomas@monjalon.net, cristian.dumitrescu@intel.com, yuanhan.liu@linux.intel.com, maxime.coquelin@redhat.com, Jerin Jacob , stable@dpdk.org Date: Fri, 2 Jun 2017 16:50:31 +0530 Message-Id: <20170602112031.9112-4-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170602112031.9112-1-jerin.jacob@caviumnetworks.com> References: <20170602112031.9112-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: MA1PR01CA0087.INDPRD01.PROD.OUTLOOK.COM (10.174.56.27) To BLUPR0701MB1714.namprd07.prod.outlook.com (10.163.85.140) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BLUPR0701MB1714: X-MS-Office365-Filtering-Correlation-Id: ae2d0ced-24cb-49d4-3445-08d4a9a97fef X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 3:dfBZbgDKy0VESLXDOwiTPRuu04UwjLhDjs9ec8nAeB1YZwq4wXfZju6EJoEM0qi1kvEsDozBJmdw4YryRQmOn0eBQOEyVQ7jXG8XKc2cV4QnlusUqcTLdh69fjdmMtU/+MudOTzGF0Ng5jaBTeTyFF6hf8Hj1Aq8t0JJbHnKts9z48xJzGp56XGRdr/IinobunnzCCku8PGwqFwNgEsrud0WRmj3Q+946d+a6volxlwL/cbDC+fa6ObDNXybI9LPSBAoCAtqdphH3zi4Mlg0HDBQTy65CMgKxcR0ZmlP8M2GDNEUmX+5MrV5BXiDNUrOwbM2GufgoPqRlfNbKPxvQQ==; 25:i8fS1nCGFSgB4rnUWTnAM1VlZalUsVM5DwGtkYWV6n3EmeVr8tRDQKNwXMgB+mgkZ6dibuiGwGbS/pGZLBPbHAiCYh7PexvPQ3CiJeZxHBh9tC8qkC6CbMuNft6i4PGLQ3mpc2R7/ZIUnU6GF23rkjTrscy7sR5JSaspwO/566LB2ygGZqBicaLpxiIL0OIMGyykQi1oYh3FKRQpCth69uiyZeciZfzbLUZm2e0WQF8pU/mpx2Lh8jVOIOrcu5pc4FX0aj2cQfAb0QbAJs1w7/EOhiyMQR40zBwiLxHIVxrrWQTasLHGZlqvdqzujin6YnXqRLCz3pf5qi2/YskUenIDDGH+H1JtI+2KcQjP31fM5jIk2+r/kXio3x7r6xaKYCoMlIE1q0FUzNMwEVG5eE12Vu4IzZI+xsqWLJXNMUYQzslbziRmFAH5cWqjRerTf6QCzFoZGTG2ctHk5THT7PRTz1u7XS0468vaRwGtJSw= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 31:05osapaasbtLODQUjweHTYT6f7au1dpRRjqbob5+STV//+h22zMBDzFi9fjRivPVbcLEkic30ILYwFcxRtf4dRDJLfWqwyEZiFlN8hAZdCYdN+epVs6ZN/FyLfib4dFL2+fksQ9kDWpwYq88eqcYnUcAe9l2cFffVkav8kggnRa9TVzcs2Dy1lxY25YNTiDk15eUgX+NS7aEm5wB9CtNsP/At92ZymfWf4tCSbTsPAM=; 20:/UCJLdxbcWPN55IanxlmRbaFv6KSXEho55U2XN01vBfYvqqC5FWQkBZZNJQ4IDUSkfzn4RC3fFlWSa4zTGDmHtyC5+x5WLRIXMMBn5G5zBAKtVchqE2ZS108yFdvzddfG18G70K/oki8HwNUpONUrsY28NcdKd5iAkRjjpa9mIMSIeicDkUO3my91S7fjp3dzBkS/q2zzgwrzVQsKa1zDxV6G/0UhY9w3klkaCd0zC/DL2EvV4irKM8zSkjQkVSWpkc2yzXV261lRExGoncU9uL5yK0TlatTfYSqXZ7kx6/Qga+1UqjauAutIgbWXPoYEleL+iGVQgHwIBirD2RCLivVrBLDy81HldB7dS5my2pDHy1QAld7G4GEVFLpXJZ5KZsZh5XURqZhZ7WN+BkHahY/yqlvss3WFqT756x1S/LNb3C/Dn6KNhMBmuNJOR1FC1D17M8isHuah8324ymqThQXkY3PDRSl2sKGEs3+X2y3tKs6iwEcvgiHyF01sgsrdfDLt9STmKqPJXFDi7vAev88Vet4APDPJdMZxpKkrLwbTKftkNa2REKwD3vCcUxXqs8kMyWne5/S6EzIs23oZ8vCB4ewxcFa8XNVG/zM3AM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(93006095)(100000703101)(100105400095)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BLUPR0701MB1714; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BLUPR0701MB1714; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBLUPR0701MB1714=3B4=3Af/e?= =?utf-8?q?KMKkAkfGqbP7cHV+rxciSL/mqZ1hlJ9B1yVPxBDRYE2IeHdtb9ZTGqc6?= =?utf-8?q?awFF04GrWXI/bxqH3mfIE53zKDPmnTU6yZ40epiQAStTcawWO7yfZIp7?= =?utf-8?q?2otc14QiQwLUtu8weOGm9lV8rRd1liHol1J/tYFYp/+dmnm28bj4pNEj?= =?utf-8?q?clGQBIEdv+C3/zRkkNj20qZKHT3zG0awCoo97EgT91DJRfGdIsoG0KCi?= =?utf-8?q?Joee15Te3OUIgBVZy9iH1X4I22X/a7feohDIXt3J4QaWZMqU/DH+phtf?= =?utf-8?q?Vi4qcTmljzUfTfs9oOY2EcCK4+rLRpgr1+HjvvSsRZ2YCV+1BBufutwa?= =?utf-8?q?9aDeHTsXy6ueqAdDUB76rMLxe8em9VpfCDOC7Y6p6S1tL5ocLgTHd5sV?= =?utf-8?q?t/Ek9uDP+gib5SgwXdD0m3nzVHw248ED8R1hUweIahAqssKqJejTHJU/?= =?utf-8?q?OdNN/pzKIjpAIoa3T82AlerxR23gFVFzo0fUt5tmJzrLQZy/A3iFteGA?= =?utf-8?q?6aUbBOYmaaxGAQfGOmHViJgtvFd3nuUO1RbQXjXoOn7fnEFmeolymlMc?= =?utf-8?q?bo442xnf2O+MB09dcHegli7sv+cDSHwdn/EcvRsMPiDnUgGzNtdG3S5M?= =?utf-8?q?whVmlkI9/I7ZRvt81i84b2eacn+y8dIEGE4P2FIYd8ZVJPGkVsQVbvlm?= =?utf-8?q?niT96yRidESsopK9T8kMMWcycYhxfj4vxMpTr/IqpMHtGLJKtLluzVER?= =?utf-8?q?GbGzPArCFwP3ohmnm6NiF8lhICkXFiUBIzFst++/QqM+4eMKJxc3NLvt?= =?utf-8?q?mu0fNepQ5krN2wTrAPx7btjejSTwIE/H9yiRwcr8K9NgGDemyGfSa4N0?= =?utf-8?q?tUyVUrcRMdGWotIpVjAJYdDTN2FzocsRu39zvkrWk1X4xAxE4+TXQYUp?= =?utf-8?q?esYHEvIme6DU9LqFXO9lECEM2R4ueQ/b9ueAfd2iotawTgXdNKKgnsV2?= =?utf-8?q?zlqCvgGIsoTsUWzkNqe9GuS5rs6hgD2h99nQKQh7jwlk2DslshLQ5WKa?= =?utf-8?q?AAInfgjhRt6nweNvH7JgNY+pm7we1xjMGIxtqEfSm38RZRZqaCzgtyKU?= =?utf-8?q?0BguItIapwq/clXRoB0UH8YmZkiy41rnJv2RdM4ChDhiJG6xeK9oZkum?= =?utf-8?q?YKeLniaE=3D?= X-Forefront-PRVS: 03264AEA72 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(979002)(6009001)(39840400002)(39450400003)(39410400002)(39400400002)(39850400002)(3846002)(1076002)(6512007)(6116002)(6486002)(53936002)(23676002)(53416004)(2351001)(305945005)(50986999)(4326008)(5009440100003)(7736002)(2361001)(5660300001)(33646002)(38730400002)(189998001)(6506006)(50226002)(110136004)(76176999)(42186005)(2870700001)(81166006)(72206003)(8676002)(47776003)(2950100002)(36756003)(66066001)(6916009)(6666003)(42882006)(478600001)(25786009)(50466002)(2906002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1714; H:jerin.caveonetworks.com; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBLUPR0701MB1714=3B23=3AS0?= =?utf-8?q?PsMCHZskRnRFGjPYfyxrmxHBWeHqxpoYxxpPDID8sBLrwVkKjiNdgtr+?= =?utf-8?q?9zJxdR9kE5pf4T9f5ieOfow2Xq8z2GKaHy/NY13foYb0crVs8ooLc/9Z?= =?utf-8?q?+myQZnUqFXwclIac6FNyZAgSpuqlC4FduEdxVkC4zRBuAFa3B8iRN/T9?= =?utf-8?q?OlrwsB8iOpsZNa7FYOwuM2b1xuvx1hAw21MguSvXoyRlMd6GeOiKoRAD?= =?utf-8?q?OM0/VOknJJ/7KMoQWTDzbGZHbg0nRmbXJ6bNWd7n/5MY5dgD0Klp8nML?= =?utf-8?q?UoZQLHBwjiL6MbIoTTDqUGlXVp/fI5U3GJrflyFCJUAl9CvjnlidaqwS?= =?utf-8?q?3/vTZU5E/ynNMlyrmutQdZj+yw0GlP/BLYEoK9iy1Jd2FgI8+uAbfJvf?= =?utf-8?q?V4kUWps1N/wu7nOr+/GgmahmiH9lI3Y6AffygYz1LgHv4NNdpIPhHFLi?= =?utf-8?q?9URBBtuqUGVwuO6InBFy3AU2d9sqG4mchda/bElaAe6hSHRhom48A/L1?= =?utf-8?q?phyBarbkLaofZQWm6asJBvoIg40tSQWs93ZxAGcjS3Lsmf832Het9Bpw?= =?utf-8?q?LSlbznrTuOiBHwRuhXKmbvXKYHkAWuRHmdmc9kj5oY09FkIQoDP4s3wN?= =?utf-8?q?0eoMZ8klIuYW5nkn17MkAmsKr4nLDqqHdItS/Y3tKL2CKNfXjBXyjbrG?= =?utf-8?q?m3ay3uPsy3hqztH1vTp4GR6p6Uo0hDc8iD/6+ukI5ThRbBC/27mzp4gS?= =?utf-8?q?3CzLXSSnjAWLfgvPnJ+EOzc3rjaOWDk3YmJ8ngE9eaS6+iPOfXceCcBE?= =?utf-8?q?kHWuEfQY9WhZrT6W5XkJo8fcVkide7Irnu7s5Yy8UnUY6VdIcUBTjeXe?= =?utf-8?q?siyFf8S++2QC7UaNhkbCghkaxzdvCVjQcsgIbofh+ml2tk8r9N77Ca3K?= =?utf-8?q?98Az5ztbCOIDJYhd5xSc6QLbfk4CzLjNIxwkULCW0VoJ/w5Ee4Mqcdw8?= =?utf-8?q?NVd6JwixWPOyyl8sHtaRVgcDQxa6P+lku9UPzgSSGbl6WhPQjHhtck8g?= =?utf-8?q?Fky+ylE6Bw08XqvIh7gp6cbsnlDYG4Fbd51tbPfzZkDGf/q25OLB3meP?= =?utf-8?q?OaGEMYFmdSYe+1Dd+lmgvMnUsq2284tA1LGfX9xgCqlgbh0uNkFEbcQe?= =?utf-8?q?a71+hkZnebDbnwsBJ2gCGs5LOqfHOTCq2m46bo47PoOX/0xrfqwM/teS?= =?utf-8?q?YCVhvkTKuEzk43dn/n8WGMCnuq1QrXqcbS/bZly2EIy0VbUhtGzH0Mwt?= =?utf-8?q?rhGDWrk8RjtUJnolz7Bt6+o+4=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 6:Uy05anZKwI+QqCQ0YrPN4oHqNsng8xk6t2KXXj7Rpy1D+BYT9+/hqy7PUEpN17Kv/O6mVIobh9qcUJkPLSgM2U2RI8P40tGwF6t/ysqPVfER2TnOnbEqwIblT7nvR/DuCs/aeeL8G1IDF+xQAL4jm4IT5qO3RY9p9c3zPwAZIaETNjuNNMDDdHORKzU1Pc7pMvBneC3N7Yr9v/cp4WfGmI5p7frhclvuRfH26fjPJ8vm9bUPkvavfyL423ocSsDYIUvhQvVteC7ggCs7/DOyjeKuVK/4TayuNET/j2ukn2qTbGSyIoMAnMfQwR7dOWLfpdb8yVi5g7ChkSYi8ZSxABRX0LN/zRnu9O4zaYANtcT2LiLDVVfRCz8Z+D9oz4Y7KRFpOaVoK9LVeeY+Ydegb1IouL9iLKV52QyXnlt1NOS82GF7cNYS3RubzHbflD1oCS6WI6UezDiT4sy5uDhvQPzQETJ05mmhhRvqoTkIhfPaatbvAXe+C3pp70Ar+QYLFykX2HTOQZXGaXwc1dbjMg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 5:Ca1cyokwIXjMXH5iI9aw1d9PDi7S5vBte7BD6MUXJvjinuUhyChCzb1jEXfmphXYfCy04/23q80amwko9ML+aQ5OSTBmh2XreAQW7iQakWsHACAgDu70rvXsu5o4m0W2gcfbCdsvALsgyjiEPIYz5bEr2DRurQnSlVW45SWw1qBPYdDL5RC8Hw2f0dbzlbONVyuhgfTiYthWWRNhgYLLQ6xC7hd/oAgXAWvd8551uapXqexlbyjTGD67nKhXbSNlGmfCIvjeNXUaItVEJkVJJE7rtr3gitr1s5MYMK5dH5hkt/Jtdi/aqgl62DN+lmAySvlt4v0LR2CIZ7V5GVPC1kyrY1UXaI6WFNUnaEZi8uG7zGFxLhtKjXwyVs0x2nXpQW6FXKnQMv27PR4yvk9443lun4SYzL7KkpxDV3ADLs9PVyNNXGhENQCrggQkovXd7SHru4TfrsgRYpg4Vy6rdzmeZFIi3wuLlmvsJH3l0ur4GiUd0AW1EnOCPrAd5Xez; 24:N19FUSMYiUhbbmuG2Fsjs55QpoNVxhFluAS4NEFXjqsRz8P3/veB/bYbL0azZaesJ7+wpXME43Im6WqeYgzFU2bJB/7FKfizghlfurmoLjQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1714; 7:cICpM4ofyBbTw08k2tGvYHdetWf4ZhPNcO6BBHC3mNoWb6LS2EpBAYYbzw99QKe9JSnmiUjW9n2i07FWI+4DdC/Zm09XapAmrcVbeeZLUOs4C2a7I/cmq6/TNVs+TKNpwcpkVXi2Uiw8ZtUTig5cYoM8kGXcjS+ueiQeT3szZhZzGVWpNM/9RsuMHIzpNU3ZnVaG/u7UpvA0RJD1UK4hCL5Sj2dR22XoRlGahaDpXTpmwLA/24Jwjf/eRD8IRf4v7pqK88IJgpRegIO7btq4xodhtLkzf8CCZzltEkTsBgavFTX5FvobHmPeOtsDO7Ci/SKuY0OtGnvvbTSw5AmVfw== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2017 11:21:20.1562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1714 Subject: [dpdk-dev] [PATCH 4/4] examples/vhost: fix uninitialized desc indexes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixing the below error by returning from the function early when count == 0. Issue flagged by GCC 7.1.1 examples/vhost/virtio_net.c:370:38: error: ‘desc_indexes[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] rte_prefetch0(&vr->desc[desc_indexes[0]]); Fixes: ca059fa5e290 ("examples/vhost: demonstrate the new generic APIs") Cc: stable@dpdk.org Signed-off-by: Jerin Jacob Reviewed-by: Maxime Coquelin --- examples/vhost/virtio_net.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/vhost/virtio_net.c b/examples/vhost/virtio_net.c index cc2c3d882..5e1ed44a5 100644 --- a/examples/vhost/virtio_net.c +++ b/examples/vhost/virtio_net.c @@ -350,6 +350,9 @@ vs_dequeue_pkts(struct vhost_dev *dev, uint16_t queue_id, count = RTE_MIN(count, MAX_PKT_BURST); count = RTE_MIN(count, free_entries); + if (unlikely(count == 0)) + return 0; + /* * Retrieve all of the head indexes first and pre-update used entries * to avoid caching issues. @@ -385,8 +388,6 @@ vs_dequeue_pkts(struct vhost_dev *dev, uint16_t queue_id, } } - if (!i) - return 0; queue->last_avail_idx += i; queue->last_used_idx += i;